Re: [PATCH v2 1/2] gdb, amd-dbgapi-target: use pulongest more

[Lancelot SIX <Lancelot.Six@amd.com>]

On 03/07/2026 14:42, Tankut Baris Aktemur wrote:
> The group id coordinates and the wave number in workgroup that are
> being formatted to a string in wave_coordinates::to_string are
> uint32_t.  Use pulongest to print them.

Hi,

this looks good to me, thanks.

Approved-by: Lancelot Six <lancelot.six@amd.com> (amdgpu)

Best,
Lancelot.

> ---
>   gdb/amd-dbgapi-target.c | 7 ++++---
>   1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/gdb/amd-dbgapi-target.c b/gdb/amd-dbgapi-target.c
> index caae9a98501..6f71f5ff5d0 100644
> --- a/gdb/amd-dbgapi-target.c
> +++ b/gdb/amd-dbgapi-target.c
> @@ -406,12 +406,13 @@ wave_coordinates::to_string () const
>     str += string_printf (":%s", pulongest (wave_id.handle));
>   
>     str += (group_ids[0] != UINT32_MAX
> -	  ? string_printf (" (%d,%d,%d)", group_ids[0], group_ids[1],
> -			   group_ids[2])
> +	  ? string_printf (" (%s,%s,%s)", pulongest (group_ids[0]),
> +			   pulongest (group_ids[1]),
> +			   pulongest (group_ids[2]))
>   	  : " (?,?,?)");
>   
>     str += (wave_in_group != UINT32_MAX
> -	  ? string_printf ("/%d", wave_in_group)
> +	  ? string_printf ("/%s", pulongest (wave_in_group))
>   	  : "/?");
>   
>     return str;