From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id WdJsHTKES2qqqCkAWB0awg (envelope-from ) for ; Mon, 06 Jul 2026 06:32:18 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=oqLXxrl3; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 72B201E098; Mon, 06 Jul 2026 06:32:18 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=unavailable autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id F18CA1E070 for ; Mon, 06 Jul 2026 06:32:17 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id EBACD4BA2E08 for ; Mon, 6 Jul 2026 10:32:16 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EBACD4BA2E08 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=oqLXxrl3 Received: from BYAPR05CU005.outbound.protection.outlook.com (mail-westusazon11010008.outbound.protection.outlook.com [52.101.85.8]) by sourceware.org (Postfix) with ESMTPS id D6C594BA2E04 for ; Mon, 6 Jul 2026 10:31:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D6C594BA2E04 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=amd.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D6C594BA2E04 Authentication-Results: sourceware.org; arc=pass smtp.remote-ip=52.101.85.8 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1783333910; cv=pass; b=wu6EDOu1INo0fi0jqt32MYugyqejlttSbMJ1+LFnX3cu7EuBj7D7AT/WG6Kv2gGD3KjLSSugTodP6l1RsOFX3qxHbSrjGVO8eIYvpsZk5TgiO5R/ehhndOBWafcwzJnhd8mvBV5f8bBy1rgilVfmm974FvkxFWC7zBjC0gf/NXY= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1783333910; c=relaxed/simple; bh=fuHJrAAGsovAYAlaKQjjMWSd9puBbFkR0x+d0ujBBy8=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=gewicQqCb1oGEUMuqqZrgg38TTvNvBOXo/+HthieFjZ6oIPKgRv6C66ovxrDnTLtmrpw4fnWGqoHe4XZEc9IzXYhEL9yYuixtn0cdc8JZBXeNRcYqVDB+p8MhmTzYUxGQp0KYCBghRZRjWf+ZUOrLVCbvtJ8pXVZ2rl8yasJuwA= ARC-Authentication-Results: i=2; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=oqLXxrl3 DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D6C594BA2E04 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=p+f+evDu9iq5CSImxREuvVNCmOg1Q3GbN5w/0ruBvgCHVANrSICyYF9Y/cFAcNfD2PH0+I8weEKaF/rGYisrK9VtjcQBHT+0yxBBjeRUWO6DP7cgIYzizCE7RIPrWtJw0NfIzawZNtxx0O+U6y0MhNNH9MXQF42BE2oKiJLmWVLk95JBpjxXUWdNf/0xoGPPoJ46n+n2UCVO140zIDkTVPXH7biQcSDaF9abIc6X/7C306aIUeJhloJofHKPdJyiRg7/qO9jtUiTseD68kiqaqJLl1+1tE8z6Bq+dJfitdaRUw4oID0Hpw5NQlfWBfsr6r2R7VJnVfafRmnzyWVXnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=grvyIlmUsZWhRzpnoTeODcOcUXdtFNsqWW8zQbyRJ1I=; b=NZUehMt7CrQ9TqQ4cQeEeGKOZ2vnPjzLNRpjQTkesNQfGD/CoL6rQ6Y0URlowcvnlo6AobaZgpRHrDVdKoc3Hx+pjP2aIgKIZ9R+AS/pXXB4tMwDpSokLO2lHDfXz3msjJoYkImoj8Jbphltgfw5fzqogiLbvmLP6fsVhOFGvmypvqXgTnTAFqdyw52IloitJ7JGrYZz/NvnYgYv6G8TvfCe9pIJx5AUypOeBpu8DM+mdMapzGU/wHFVwxEoze3+z9HUb7td8bT4LAzx3br7eHA4EJo3h7PEp5btBTKoGRlkSeeXcf6ZbW0mkhcq4Nl+a3bHEaoh+tkNuEkku5P3ng== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=grvyIlmUsZWhRzpnoTeODcOcUXdtFNsqWW8zQbyRJ1I=; b=oqLXxrl3bpBqfhpM8eSfAaEio5ut6ORjcaqdBvhjJks/fBdG/zmp1xyc0KoNX4YN9+25imCuqAhvkuKCt/+HWgLAUaWn9CK3rrRtVqJVtY5NOLiS4ddVFDLQfC6VrCcKT6DhT1ss7spifO6hvpRuXhwa2WS7g/5BMERuEt7X27I= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH3PR12MB9079.namprd12.prod.outlook.com (2603:10b6:610:1a1::9) by LV2PR12MB6014.namprd12.prod.outlook.com (2603:10b6:408:170::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.11; Mon, 6 Jul 2026 10:31:39 +0000 Received: from CH3PR12MB9079.namprd12.prod.outlook.com ([fe80::5a7a:2adf:1862:35c3]) by CH3PR12MB9079.namprd12.prod.outlook.com ([fe80::5a7a:2adf:1862:35c3%5]) with mapi id 15.21.0181.009; Mon, 6 Jul 2026 10:31:38 +0000 Message-ID: <263f84ce-f41d-432f-9381-e390a737690d@amd.com> Date: Mon, 6 Jul 2026 11:31:34 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/2] gdb, amd-dbgapi-target: use pulongest more To: Tankut Baris Aktemur , gdb-patches@sourceware.org Cc: simark@simark.ca References: <20260703134208.1914592-1-tankutbaris.aktemur@amd.com> Content-Language: en-US From: Lancelot SIX In-Reply-To: <20260703134208.1914592-1-tankutbaris.aktemur@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: YT4PR01CA0475.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:d6::12) To CH3PR12MB9079.namprd12.prod.outlook.com (2603:10b6:610:1a1::9) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PR12MB9079:EE_|LV2PR12MB6014:EE_ X-MS-Office365-Filtering-Correlation-Id: 5d845161-6c9f-4df1-404c-08dedb49c31a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|23010399003|1800799024|366016|3023799007|22082099003|18002099003|56012099006|11063799006; X-Microsoft-Antispam-Message-Info: wrZX7Cbqxtp3FKv1s+bRuC5qjbJvuzdP0C5/uaE2cwyyiBLpby+JfLaOJ3txf+lxtD1PcckR4+S4x5O4RTX8dSFWath0L3hrDRVcecdCPgBylMBikGqzuFsLCmkgmYegk9NayL/UpX+zIWVIlMC4AcLcfc4c7ad8LpOaeczVOYnWuevbD48HY83stQW0hgW356ZctCXtUI0HeEmZ6yDfLJ4c8kFJiFNV85C/xq2qYLdqYkBnQJQwev+NFxLSAVPmjfW9vXWncucVuZGOga0q1aH7DKW0+NOGD17ZJZLyXOBOic1jrKYG9i6EiEPQhWmo7vT3hgS2n1LYOGvHk8ZK4LECe5sWyy3e8mrNPqrV4CTIgZIxW7NHm6e6vtkUzr3c8fAFb/O4MIejR5/nARKyzYVIT3kBkl2oZg5Kzf14eTat6+tcnU1ftBoMOpStv/lbIup34c0qgLiYNCZ/TmXdm8nTQ4Tdh4mOWCZwszdfM+Q6zPWG4JaOoiY8hVr7pxCz59ZdBfKpbCODqyC2Y4S1z/P7pLoHxsM7gvDLC67VDxTlkkiLKWz4MSfvr/vKsKilmWluIRZDG89MpCifcAgj5fueiua1CTFuFiHZBotGmJgiDFiPvhJZqbd3yXFpqiG/rw/D0vgzImSKRhjvDxDUxHQomQpjHzg4mI6c8WPbdYc= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH3PR12MB9079.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(23010399003)(1800799024)(366016)(3023799007)(22082099003)(18002099003)(56012099006)(11063799006); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QzNiRU0rbkxONnhDTUtna241ZkhyZFloRjM3LzBialkxUXBYZ2g2RWdRYUVW?= =?utf-8?B?RzRUL3ozNTd1MlV2Z3AzVVFiUE1JSUdLZEdPTUtoN3JyTEplcXQ4YVZmdWJJ?= =?utf-8?B?eGVMRXJMRGhpbFRJN1pMWmtrZ1VnQjVoZUdJN29jUkZ2SzdxejdZb3UwendN?= =?utf-8?B?cUg2d2Q2WGRFRWtRMWpFcGgvQlpVS2tLbWFMUS9LS0REeG1USG82QTV2UENZ?= =?utf-8?B?QndhaVFsR2plelFKSjZxQk8rMHVJTjBPdVJEdmJDeUo3UHhtcjZpaHI0TjJx?= =?utf-8?B?Y3ZCcUE5dTVpMXFsOUo0cTNZTXhyT0pObGVBR25QSjVuRWpaRHBtS0diSzFu?= =?utf-8?B?eHRvVm5BUmVtMUVRNXZRV2s3ZzRQejM3ckxKbEJ4eFM2M2o2dlp2TUc2RnJw?= =?utf-8?B?NUpQeXlHVkc0T1JZMFZsWDM1R2FTUlZwRmRrZ1pwK1NFUDRLNDVVU3dCb3lZ?= =?utf-8?B?b0k1ckRITHYrYTdnQU5ETG1QTy9WSjZXUUtxdXZBYlFRS3lvRWdjRVV4bG8r?= =?utf-8?B?S0NQTXlDTU9YaDBtZXUyendsNWZlcHBSRG9aVWZ0a1F2WmU4SHRXQ0grQ0cv?= =?utf-8?B?MHRrMWlCQ1RqOHJ5ZU9UaEJ5WXRNNCtpKzNqcTkzbVRjVzZ1VFRYRHI0d0xE?= =?utf-8?B?aGVLcVdVdCtOQmxPZzBwb3lRZkx6eEd3UkNmNHRDVVlEdHprYzljaDYzSis0?= =?utf-8?B?ZzUzbXZpVXNLSkdsY1ZNNUtnK0dpRDdWTHI2Skwxd2FaMU9BTldPWXlIZ2xJ?= =?utf-8?B?QzR6ZFVkcG5LMzVwSkd1cDZWVU1pczVneFhZUEZsaTVONEZSUWJIdHljM0VE?= =?utf-8?B?WDZ1RThyM1NhR3lmMkkwZ1FxY2JLWEZKd1BpUHBDSm9JdDdYbHZicUZIQ2RE?= =?utf-8?B?a2ZBZWhJSWxEdzZIZ2NCZ1pQc3A3cjM0S0xNeWt1VUNzRU9jUWtFbTlYaW5V?= =?utf-8?B?T3JWNUp4a21FdXZKcXZGUUwyRjEzY1dzdUY0TkdiMXdmdzZTNHBCVklWMVJr?= =?utf-8?B?cmZwbFJTODBpc3BvYWRiblVPZjBhZnBUWTVSQmxsL25ydEZPeGNwQi9TaUE2?= =?utf-8?B?Sk1yUFNTM1NzSjNPUDh2MDYxSjl4OWYrbWpPM0o2eWpYTHRhdkNGVGJaNU5J?= =?utf-8?B?Nk11blJ0MmdzOGNlMVh6K0s0TXJDelQvdEQyOVh2R28wV1dCS1paVGZpL2lh?= =?utf-8?B?RDN2NVVrTUhqRzFpWjEySTlYU3U4TEJDQm53WVU2U2tNWUZlTWs2Q3hsVXkx?= =?utf-8?B?QlB5dEd4ZE54WSs0azJ4S3NIMHRSbmdmVzJ5L1V6M1dhL1BlU2pIeVFTUnBr?= =?utf-8?B?NzVRM1ZtOVFvV3VwZ0x5cmNqY3MxVjZHRVpVS2kzVCtwc0VwclM5alU5WXUv?= =?utf-8?B?dm5mNW5EM25vb0R6ekIvQmVKMzBUV3dXN2RLRW5tYnNIcVF3MlM4Y1hmWXVH?= =?utf-8?B?em4wTnV6QksrU1NlajBYVDZMVkU4dE1WSXRiOUxTS2VpUm16c0dMd1VkQWNY?= =?utf-8?B?MjN4UytSM2cyUWlUUjV6NnU1SEp1d3V4dEs5dkptclNmSVZ2bGZFb3pUTUlY?= =?utf-8?B?bldGT0dtdGdkUkpndXJma01SQlBYd1RZaUozQzBsSkhscXMzZ1hnczRvLzFq?= =?utf-8?B?VlhqbkRGWmlqaFN2MnFWNWYyd2VJMFc5a3FhYlNsSndVZUM3S2U5Wk5tWHha?= =?utf-8?B?M0cyUExxSG8wNi9mc2JYTS9kZVIrTzlJa1BOdWJROTFTTXBDWXFIWHhndmFK?= =?utf-8?B?M1FqRllJdGhrVFNjd0FMRmpoQWoxL1dtdGVyRXpQWVhtYTFyVitJamE5akhr?= =?utf-8?B?UVNIWVhDazBEUThtTHB0ZXV2MlBjbWE1NVdFWlRJRVd1b2hCMlpYVFE1YWJT?= =?utf-8?B?VFV3eUZPdlRDSGJxa1RJdFJlM0dLOHQyellZWHI1SjdZL25WMzZ2OFp2Z016?= =?utf-8?B?QzVBNUI1SXVZMUZDN045WmxITGdNczF4OE9RajFDakg2SmdRL1ZMV3ZpTEVN?= =?utf-8?B?Umkzb1dURHIzbXZWcHptaEpvdzVSalcvWGFJZlJjTXVyYmhOKzRVZS83YmND?= =?utf-8?B?ZDFHYlROK1ltY0x3OXBpQ0Q2SXR2cjRhTWpOWjBuYlVLZi9LUmduQ2ZxVmd4?= =?utf-8?B?aUJsTjV6REhnaUF5TC8rR1U1U2tMUkIray9DQklWY29ObjNMaUR3NU5DQnhB?= =?utf-8?B?K0YyTUlGSXB0UmZOSmR6TnBqM2piRGs0eld4N0hIYnZ5OXBxdisxVzJ3ZkNV?= =?utf-8?B?bmx0b3ZqOTV1WHBkZnNiSFBxT2ZZVFlHZWwwd08yeUMxS2FEZnMzZkFCbXpr?= =?utf-8?B?RlRnQjA2NGVYbFVBU0JJTmV3S2h2Y29xRkZPenFwcmwvWXVLTXpndz09?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5d845161-6c9f-4df1-404c-08dedb49c31a X-MS-Exchange-CrossTenant-AuthSource: CH3PR12MB9079.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jul 2026 10:31:38.6961 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: iLQwD18YSPpf4bC7EXxCHC0ZGQg2/vQA5MgFdtCnl0JQqRuHd87dAVUPUE5Lv79P+eXwf4JdkrEWMA18jYcaVA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV2PR12MB6014 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 03/07/2026 14:42, Tankut Baris Aktemur wrote: > The group id coordinates and the wave number in workgroup that are > being formatted to a string in wave_coordinates::to_string are > uint32_t. Use pulongest to print them. Hi, this looks good to me, thanks. Approved-by: Lancelot Six (amdgpu) Best, Lancelot. > --- > gdb/amd-dbgapi-target.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/gdb/amd-dbgapi-target.c b/gdb/amd-dbgapi-target.c > index caae9a98501..6f71f5ff5d0 100644 > --- a/gdb/amd-dbgapi-target.c > +++ b/gdb/amd-dbgapi-target.c > @@ -406,12 +406,13 @@ wave_coordinates::to_string () const > str += string_printf (":%s", pulongest (wave_id.handle)); > > str += (group_ids[0] != UINT32_MAX > - ? string_printf (" (%d,%d,%d)", group_ids[0], group_ids[1], > - group_ids[2]) > + ? string_printf (" (%s,%s,%s)", pulongest (group_ids[0]), > + pulongest (group_ids[1]), > + pulongest (group_ids[2])) > : " (?,?,?)"); > > str += (wave_in_group != UINT32_MAX > - ? string_printf ("/%d", wave_in_group) > + ? string_printf ("/%s", pulongest (wave_in_group)) > : "/?"); > > return str;