Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tankut Baris Aktemur <tankutbaris.aktemur@amd.com>
To: <gdb-patches@sourceware.org>
Cc: <lancelot.six@amd.com>, <simark@simark.ca>
Subject: [PATCH v2 1/2] gdb, amd-dbgapi-target: use pulongest more
Date: Fri, 3 Jul 2026 08:42:08 -0500	[thread overview]
Message-ID: <20260703134208.1914592-1-tankutbaris.aktemur@amd.com> (raw)
In-Reply-To: <20260703125058.1828518-1-tankutbaris.aktemur@amd.com>

The group id coordinates and the wave number in workgroup that are
being formatted to a string in wave_coordinates::to_string are
uint32_t.  Use pulongest to print them.
---
 gdb/amd-dbgapi-target.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/gdb/amd-dbgapi-target.c b/gdb/amd-dbgapi-target.c
index caae9a98501..6f71f5ff5d0 100644
--- a/gdb/amd-dbgapi-target.c
+++ b/gdb/amd-dbgapi-target.c
@@ -406,12 +406,13 @@ wave_coordinates::to_string () const
   str += string_printf (":%s", pulongest (wave_id.handle));
 
   str += (group_ids[0] != UINT32_MAX
-	  ? string_printf (" (%d,%d,%d)", group_ids[0], group_ids[1],
-			   group_ids[2])
+	  ? string_printf (" (%s,%s,%s)", pulongest (group_ids[0]),
+			   pulongest (group_ids[1]),
+			   pulongest (group_ids[2]))
 	  : " (?,?,?)");
 
   str += (wave_in_group != UINT32_MAX
-	  ? string_printf ("/%d", wave_in_group)
+	  ? string_printf ("/%s", pulongest (wave_in_group))
 	  : "/?");
 
   return str;
-- 
2.34.1


  parent reply	other threads:[~2026-07-03 13:43 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-03 12:50 [PATCH 1/2] gdb, amd-dbgapi-target: use '%u' instead of '%d' in wave_coordinates::to_string Tankut Baris Aktemur
2026-07-03 12:50 ` [PATCH 2/2] gdb, amd-dbgapi-target: split wave_coordinates::to_string Tankut Baris Aktemur
2026-07-03 13:16   ` Simon Marchi
2026-07-06 10:45     ` Lancelot SIX
2026-07-03 13:12 ` [PATCH 1/2] gdb, amd-dbgapi-target: use '%u' instead of '%d' in wave_coordinates::to_string Simon Marchi
2026-07-03 13:27   ` Aktemur, Baris
2026-07-03 13:42 ` Tankut Baris Aktemur [this message]
2026-07-06 10:31   ` [PATCH v2 1/2] gdb, amd-dbgapi-target: use pulongest more Lancelot SIX

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260703134208.1914592-1-tankutbaris.aktemur@amd.com \
    --to=tankutbaris.aktemur@amd.com \
    --cc=gdb-patches@sourceware.org \
    --cc=lancelot.six@amd.com \
    --cc=simark@simark.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox