RE: [PATCH 1/2] gdb, amd-dbgapi-target: use '%u' instead of '%d' in wave_coordinates::to_string

["Aktemur, Baris" <TankutBaris.Aktemur@amd.com>]

AMD General

On Friday, July 3, 2026 3:13 PM, Simon Marchi wrote:
> On 7/3/26 8:50 AM, Tankut Baris Aktemur wrote:
> > The group id coordinates and the wave number in workgroup that are
> > being formatted to a string in wave_coordinates::to_string are
> > unsigned values.  Use '%u' instead of '%d'.
>
> Do we get a compiler warning for this?  Or do they warn only if there is
> a size mismatch, not a sign mismatch?

As far as I know, no warning.

> > ---
> >  gdb/amd-dbgapi-target.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/gdb/amd-dbgapi-target.c b/gdb/amd-dbgapi-target.c
> > index caae9a98501..923b790664e 100644
> > --- a/gdb/amd-dbgapi-target.c
> > +++ b/gdb/amd-dbgapi-target.c
> > @@ -406,12 +406,12 @@ wave_coordinates::to_string () const
> >    str += string_printf (":%s", pulongest (wave_id.handle));
> >
> >    str += (group_ids[0] != UINT32_MAX
> > -       ? string_printf (" (%d,%d,%d)", group_ids[0], group_ids[1],
> > +       ? string_printf (" (%u,%u,%u)", group_ids[0], group_ids[1],
> >                          group_ids[2])
> >         : " (?,?,?)");
> >
> >    str += (wave_in_group != UINT32_MAX
> > -       ? string_printf ("/%d", wave_in_group)
> > +       ? string_printf ("/%u", wave_in_group)
> >         : "/?");
>
> All these are std::uint32_t, so we should probably use PRIu32 (or
> pulongest).

I'll send an update with pulongest.

-Baris