* Re: [PATCH] dwarf_decode_lines_1: Delete local basic_block, unused
[not found] <yjt2sil0atfw.fsf@ruffy.mtv.corp.google.com>
@ 2014-08-14 23:05 ` Joel Brobecker
2014-08-14 23:37 ` Doug Evans
0 siblings, 1 reply; 3+ messages in thread
From: Joel Brobecker @ 2014-08-14 23:05 UTC (permalink / raw)
To: Doug Evans; +Cc: gdb-patches
> Should I apply this patch?
Yeah, I would go ahead. It doesn't look like keeping it is going
to make potential enhancement any easier...
> 2014-08-13 Doug Evans <dje@google.com>
>
> * dwarf2read.c (dwarf_decode_lines_1): Delete local basic_block,
> unused.
--
Joel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dwarf_decode_lines_1: Delete local basic_block, unused
2014-08-14 23:05 ` [PATCH] dwarf_decode_lines_1: Delete local basic_block, unused Joel Brobecker
@ 2014-08-14 23:37 ` Doug Evans
2014-08-14 23:45 ` Joel Brobecker
0 siblings, 1 reply; 3+ messages in thread
From: Doug Evans @ 2014-08-14 23:37 UTC (permalink / raw)
To: Joel Brobecker; +Cc: gdb-patches
Joel Brobecker writes:
> > Should I apply this patch?
>
> Yeah, I would go ahead. It doesn't look like keeping it is going
> to make potential enhancement any easier...
>
> > 2014-08-13 Doug Evans <dje@google.com>
> >
> > * dwarf2read.c (dwarf_decode_lines_1): Delete local basic_block,
> > unused.
>
> --
> Joel
I'm guessing the same applies to local "column"?
2014-08-14 Doug Evans <dje@google.com>
* dwarf2read.c (dwarf_decode_lines_1): Delete local "column", unused.
diff --git a/gdb/dwarf2read.c b/gdb/dwarf2read.c
index abe47d1..9240267 100644
--- a/gdb/dwarf2read.c
+++ b/gdb/dwarf2read.c
@@ -17204,7 +17204,6 @@ dwarf_decode_lines_1 (struct line_header *lh, const char *comp_dir,
CORE_ADDR address = 0;
unsigned int file = 1;
unsigned int line = 1;
- unsigned int column = 0;
int is_stmt = lh->default_is_stmt;
int basic_block = 0;
int end_sequence = 0;
@@ -17412,7 +17411,7 @@ dwarf_decode_lines_1 (struct line_header *lh, const char *comp_dir,
}
break;
case DW_LNS_set_column:
- column = read_unsigned_leb128 (abfd, line_ptr, &bytes_read);
+ (void) read_unsigned_leb128 (abfd, line_ptr, &bytes_read);
line_ptr += bytes_read;
break;
case DW_LNS_negate_stmt:
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dwarf_decode_lines_1: Delete local basic_block, unused
2014-08-14 23:37 ` Doug Evans
@ 2014-08-14 23:45 ` Joel Brobecker
0 siblings, 0 replies; 3+ messages in thread
From: Joel Brobecker @ 2014-08-14 23:45 UTC (permalink / raw)
To: Doug Evans; +Cc: gdb-patches
> I'm guessing the same applies to local "column"?
>
> 2014-08-14 Doug Evans <dje@google.com>
>
> * dwarf2read.c (dwarf_decode_lines_1): Delete local "column", unused.
LGTM!
--
Joel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-08-14 23:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <yjt2sil0atfw.fsf@ruffy.mtv.corp.google.com>
2014-08-14 23:05 ` [PATCH] dwarf_decode_lines_1: Delete local basic_block, unused Joel Brobecker
2014-08-14 23:37 ` Doug Evans
2014-08-14 23:45 ` Joel Brobecker
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox