From: Doug Evans <dje@google.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] dwarf_decode_lines_1: Delete local basic_block, unused
Date: Thu, 14 Aug 2014 23:37:00 -0000 [thread overview]
Message-ID: <21485.18476.412768.345889@ruffy.mtv.corp.google.com> (raw)
In-Reply-To: <20140814230502.GJ4881@adacore.com>
Joel Brobecker writes:
> > Should I apply this patch?
>
> Yeah, I would go ahead. It doesn't look like keeping it is going
> to make potential enhancement any easier...
>
> > 2014-08-13 Doug Evans <dje@google.com>
> >
> > * dwarf2read.c (dwarf_decode_lines_1): Delete local basic_block,
> > unused.
>
> --
> Joel
I'm guessing the same applies to local "column"?
2014-08-14 Doug Evans <dje@google.com>
* dwarf2read.c (dwarf_decode_lines_1): Delete local "column", unused.
diff --git a/gdb/dwarf2read.c b/gdb/dwarf2read.c
index abe47d1..9240267 100644
--- a/gdb/dwarf2read.c
+++ b/gdb/dwarf2read.c
@@ -17204,7 +17204,6 @@ dwarf_decode_lines_1 (struct line_header *lh, const char *comp_dir,
CORE_ADDR address = 0;
unsigned int file = 1;
unsigned int line = 1;
- unsigned int column = 0;
int is_stmt = lh->default_is_stmt;
int basic_block = 0;
int end_sequence = 0;
@@ -17412,7 +17411,7 @@ dwarf_decode_lines_1 (struct line_header *lh, const char *comp_dir,
}
break;
case DW_LNS_set_column:
- column = read_unsigned_leb128 (abfd, line_ptr, &bytes_read);
+ (void) read_unsigned_leb128 (abfd, line_ptr, &bytes_read);
line_ptr += bytes_read;
break;
case DW_LNS_negate_stmt:
next prev parent reply other threads:[~2014-08-14 23:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <yjt2sil0atfw.fsf@ruffy.mtv.corp.google.com>
2014-08-14 23:05 ` Joel Brobecker
2014-08-14 23:37 ` Doug Evans [this message]
2014-08-14 23:45 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21485.18476.412768.345889@ruffy.mtv.corp.google.com \
--to=dje@google.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox