From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17426 invoked by alias); 14 Aug 2014 23:37:20 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 17416 invoked by uid 89); 14 Aug 2014 23:37:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-oi0-f73.google.com Received: from mail-oi0-f73.google.com (HELO mail-oi0-f73.google.com) (209.85.218.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 14 Aug 2014 23:37:19 +0000 Received: by mail-oi0-f73.google.com with SMTP id u20so403241oif.4 for ; Thu, 14 Aug 2014 16:37:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:mime-version:content-type :content-transfer-encoding:message-id:date:to:cc:subject:in-reply-to :references; bh=rejxNusSACbQC3/UK9IpCfJKUn4K5ggk7xRguP3zIIk=; b=GmwiRLTQ+CekpwyZv4FV0w5PqBjci+HvWSfCaqC7jvuznDDioL3dasskmgQFRRNDEo ecmHkIB31k8/5zOtUdQmN8irDu+KDpuZrP9bZo/wcmj1X02C82bAYHTy6ArgzDyiTYw6 bndNs/eHkvAsOtyRg68Fd+Na9zFXKRBpkUq01YVODlS+uzoAEft265dftAuKH9KcTSFG EQSoa3MXEerJpdHdlgerSbGbywlX3DyQbMOoMUNPa/+7plFis1KMqg0XQTmL9QrBZYMG WRJn+akc2p1SB30bzbBOPd1ff4lXlk8ayX61obDs90bz2VjOYel+fo9UvFDEHaj53RX3 YcIw== X-Gm-Message-State: ALoCoQnBKkgxIzsWvLV2ok3ChM8fMjhpXWeO+DCR6ikW4SoR/cw+WjJKWCELhrvSKiaVyZRm/dnM X-Received: by 10.42.90.209 with SMTP id l17mr1911345icm.34.1408059437518; Thu, 14 Aug 2014 16:37:17 -0700 (PDT) Received: from corp2gmr1-2.hot.corp.google.com (corp2gmr1-2.hot.corp.google.com [172.24.189.93]) by gmr-mx.google.com with ESMTPS id y50si477580yhk.4.2014.08.14.16.37.17 for (version=TLSv1.1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 14 Aug 2014 16:37:17 -0700 (PDT) Received: from ruffy.mtv.corp.google.com (ruffy.mtv.corp.google.com [172.17.128.44]) by corp2gmr1-2.hot.corp.google.com (Postfix) with ESMTP id E98795A42AF; Thu, 14 Aug 2014 16:37:16 -0700 (PDT) From: Doug Evans MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <21485.18476.412768.345889@ruffy.mtv.corp.google.com> Date: Thu, 14 Aug 2014 23:37:00 -0000 To: Joel Brobecker Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] dwarf_decode_lines_1: Delete local basic_block, unused In-Reply-To: <20140814230502.GJ4881@adacore.com> References: <20140814230502.GJ4881@adacore.com> X-IsSubscribed: yes X-SW-Source: 2014-08/txt/msg00258.txt.bz2 Joel Brobecker writes: > > Should I apply this patch? > > Yeah, I would go ahead. It doesn't look like keeping it is going > to make potential enhancement any easier... > > > 2014-08-13 Doug Evans > > > > * dwarf2read.c (dwarf_decode_lines_1): Delete local basic_block, > > unused. > > -- > Joel I'm guessing the same applies to local "column"? 2014-08-14 Doug Evans * dwarf2read.c (dwarf_decode_lines_1): Delete local "column", unused. diff --git a/gdb/dwarf2read.c b/gdb/dwarf2read.c index abe47d1..9240267 100644 --- a/gdb/dwarf2read.c +++ b/gdb/dwarf2read.c @@ -17204,7 +17204,6 @@ dwarf_decode_lines_1 (struct line_header *lh, const char *comp_dir, CORE_ADDR address = 0; unsigned int file = 1; unsigned int line = 1; - unsigned int column = 0; int is_stmt = lh->default_is_stmt; int basic_block = 0; int end_sequence = 0; @@ -17412,7 +17411,7 @@ dwarf_decode_lines_1 (struct line_header *lh, const char *comp_dir, } break; case DW_LNS_set_column: - column = read_unsigned_leb128 (abfd, line_ptr, &bytes_read); + (void) read_unsigned_leb128 (abfd, line_ptr, &bytes_read); line_ptr += bytes_read; break; case DW_LNS_negate_stmt: