From: Alan Hayward <Alan.Hayward@arm.com>
To: Yao Qi <qiyaoltc@gmail.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
nd <nd@arm.com>
Subject: Re: [PATCH 3/4] Use flexible target descriptors for aarch64
Date: Fri, 24 Nov 2017 11:34:00 -0000 [thread overview]
Message-ID: <20992757-30DB-41BE-AFBE-5EDB3CE8C5BE@arm.com> (raw)
In-Reply-To: <20171123175034.GJ318@1170ee0b50d5>
> On 23 Nov 2017, at 17:50, Yao Qi <qiyaoltc@gmail.com> wrote:
>
> On 17-11-23 16:19:44, Alan Hayward wrote:
>>
>> Files regenerated in patch below:
>
> Commit log is the part to be reviewed in the patch review. It is
> better to post the patch together with the commit log, although the
> commit log may not be changed.
>
>>
>>
>> diff --git a/gdb/arch/aarch64.c b/gdb/arch/aarch64.c
>> index 95d9906f10e660fda99d73a0d2a9d184fd3a7b52..59f9330235e639d44920cab79b595e5266a935ff 100644
>> --- a/gdb/arch/aarch64.c
>> +++ b/gdb/arch/aarch64.c
>> @@ -17,14 +17,27 @@
>>
>>
>> #include "aarch64.h"
>> +#include <stdlib.h>
>> +#include <string.h>
>>
>
> Is it necessary to include string.h? Otherwise, patch is good to me.
>
Removed sting.h (I was sure I had a strcmp in here)
All 4 Patches pushed.
Alan.
next prev parent reply other threads:[~2017-11-24 11:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-25 8:31 Alan Hayward
2017-10-30 12:27 ` Yao Qi
2017-10-30 13:00 ` Yao Qi
[not found] ` <A0F02AC1-8FF2-4022-B089-F68D2949CEB6@arm.com>
2017-11-06 10:06 ` Alan Hayward
2017-11-06 11:49 ` Yao Qi
2017-11-06 12:58 ` Alan Hayward
[not found] ` <B3614F09-2732-4B13-A45D-5EC111A8DC7E@arm.com>
2017-11-22 15:47 ` Yao Qi
2017-11-22 16:00 ` Yao Qi
[not found] ` <8E1DED12-D169-49CD-A9A3-388280EBDB60@arm.com>
2017-11-23 17:53 ` [PATCH 4/4] Add xml selftests Yao Qi
2017-11-23 16:19 ` [PATCH 3/4] Use flexible target descriptors for aarch64 Alan Hayward
2017-11-23 17:50 ` Yao Qi
2017-11-24 11:34 ` Alan Hayward [this message]
2017-11-24 12:49 ` Yao Qi
2017-11-24 13:26 ` [PATCH] fix aarch64-none-elf build error Alan Hayward
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20992757-30DB-41BE-AFBE-5EDB3CE8C5BE@arm.com \
--to=alan.hayward@arm.com \
--cc=gdb-patches@sourceware.org \
--cc=nd@arm.com \
--cc=qiyaoltc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox