Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Alan Hayward <Alan.Hayward@arm.com>
To: Yao Qi <qiyaoltc@gmail.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
	nd <nd@arm.com>
Subject: [PATCH] fix aarch64-none-elf build error
Date: Fri, 24 Nov 2017 13:26:00 -0000	[thread overview]
Message-ID: <018B8906-8E80-4E12-963C-B4A014ADC286@arm.com> (raw)
In-Reply-To: <CAH=s-POocC8DVGfOBoEZ7hRd8Vo-DQxjnivFH=7WU2dBLHSFpQ@mail.gmail.com>


> On 24 Nov 2017, at 12:49, Yao Qi <qiyaoltc@gmail.com> wrote:
> 
> On Fri, Nov 24, 2017 at 11:34 AM, Alan Hayward <Alan.Hayward@arm.com> wrote:
>> 
>> 
>> All 4 Patches pushed.
>> 
> 
> They break aarch64-elf build.
> 
> aarch64-tdep.o: In function `aarch64_read_description()':
> binutils-gdb/gdb/aarch64-tdep.c:2837: undefined reference to
> `aarch64_create_target_description()'
> binutils-gdb/gdb/aarch64-tdep.c:2837: undefined reference to
> `aarch64_create_target_description()'
> aarch64-tdep.o: In function `_initialize_aarch64_tdep()':
> binutils-gdb/gdb/aarch64-tdep.c:3073: undefined reference to
> `aarch64_create_target_description()'
> collect2: error: ld returned 1 exit status
> 
> https://ci.linaro.org/job/tcwg-binutils/4251/
> 
> -- 
> Yao (齐尧)


This patch fixes the build error I introduced for aarch64-none-elf.
Apologies, I hadn’t run that build.

2017-11-24  Alan Hayward  <alan.hayward@arm.com>

	* configure.tgt: Add arch/aarch64.o


Alan.


diff --git a/gdb/configure.tgt b/gdb/configure.tgt
index daec0a7bcd31944679b87fb4c3775dedc15dfd21..701ad6c48605fd72cb8afea40fa711c3b817133c 100644
--- a/gdb/configure.tgt
+++ b/gdb/configure.tgt
@@ -46,7 +46,7 @@ amd64_tobjs="amd64-tdep.o arch/amd64.o"

 case "${targ}" in
 aarch64*-*-*)
-	cpu_obs="aarch64-tdep.o arch/aarch64-insn.o";;
+	cpu_obs="aarch64-tdep.o arch/aarch64-insn.o arch/aarch64.o";;

 alpha*-*-*)
 	# Target: Alpha


      reply	other threads:[~2017-11-24 13:26 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-25  8:31 [PATCH 3/4] Use flexible target descriptors for aarch64 Alan Hayward
2017-10-30 12:27 ` Yao Qi
2017-10-30 13:00 ` Yao Qi
     [not found]   ` <A0F02AC1-8FF2-4022-B089-F68D2949CEB6@arm.com>
2017-11-06 10:06     ` Alan Hayward
2017-11-06 11:49       ` Yao Qi
2017-11-06 12:58         ` Alan Hayward
     [not found]           ` <B3614F09-2732-4B13-A45D-5EC111A8DC7E@arm.com>
2017-11-22 15:47             ` Yao Qi
2017-11-22 16:00               ` Yao Qi
     [not found]                 ` <8E1DED12-D169-49CD-A9A3-388280EBDB60@arm.com>
2017-11-23 17:53                   ` [PATCH 4/4] Add xml selftests Yao Qi
2017-11-23 16:19               ` [PATCH 3/4] Use flexible target descriptors for aarch64 Alan Hayward
2017-11-23 17:50                 ` Yao Qi
2017-11-24 11:34                   ` Alan Hayward
2017-11-24 12:49                     ` Yao Qi
2017-11-24 13:26                       ` Alan Hayward [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=018B8906-8E80-4E12-963C-B4A014ADC286@arm.com \
    --to=alan.hayward@arm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=nd@arm.com \
    --cc=qiyaoltc@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox