From: Yao Qi <qiyaoltc@gmail.com>
To: Alan Hayward <Alan.Hayward@arm.com>
Cc: "gdb-patches\@sourceware.org" <gdb-patches@sourceware.org>,
nd <nd@arm.com>
Subject: Re: [PATCH 3/4] Use flexible target descriptors for aarch64
Date: Wed, 22 Nov 2017 15:47:00 -0000 [thread overview]
Message-ID: <86zi7eqps4.fsf@gmail.com> (raw)
In-Reply-To: <B3614F09-2732-4B13-A45D-5EC111A8DC7E@arm.com> (Alan Hayward's message of "Mon, 20 Nov 2017 15:37:58 +0000")
Alan Hayward <Alan.Hayward@arm.com> writes:
> +#include <stdlib.h>
> +#include <string.h>
> #include "aarch64.h"
>
> -extern struct target_desc *tdesc_aarch64;
> +#ifdef GDBSERVER
> +#include "common/common-defs.h"
> +#include "common/gdb_vecs.h"
> +#include "common/vec.h"
> +#include "tdesc.h"
> +#else
> +#include "defs.h"
> +#include "target-descriptions.h"
> +#endif
> +
Do we need to include headers this way? We don't have that in
arch/i386.c and arch/amd64.c.
> diff --git a/gdb/features/aarch64-core.c b/gdb/features/aarch64-core.c
> new file mode 100644
> index 0000000000000000000000000000000000000000..a735515ae67211d29634e7c39b375a36edef2bb1
> --- /dev/null
> +++ b/gdb/features/aarch64-core.c
> @@ -0,0 +1,72 @@
> +/* THIS FILE IS GENERATED. -*- buffer-read-only: t -*- vi:set ro:
> + Original: aarch64-core.xml.tmp */
> +
Looks this file is not generated by the recent GDB. Can you re-generate them?
--
Yao (齐尧)
next prev parent reply other threads:[~2017-11-22 15:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-25 8:31 Alan Hayward
2017-10-30 12:27 ` Yao Qi
2017-10-30 13:00 ` Yao Qi
[not found] ` <A0F02AC1-8FF2-4022-B089-F68D2949CEB6@arm.com>
2017-11-06 10:06 ` Alan Hayward
2017-11-06 11:49 ` Yao Qi
2017-11-06 12:58 ` Alan Hayward
[not found] ` <B3614F09-2732-4B13-A45D-5EC111A8DC7E@arm.com>
2017-11-22 15:47 ` Yao Qi [this message]
2017-11-22 16:00 ` Yao Qi
[not found] ` <8E1DED12-D169-49CD-A9A3-388280EBDB60@arm.com>
2017-11-23 17:53 ` [PATCH 4/4] Add xml selftests Yao Qi
2017-11-23 16:19 ` [PATCH 3/4] Use flexible target descriptors for aarch64 Alan Hayward
2017-11-23 17:50 ` Yao Qi
2017-11-24 11:34 ` Alan Hayward
2017-11-24 12:49 ` Yao Qi
2017-11-24 13:26 ` [PATCH] fix aarch64-none-elf build error Alan Hayward
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86zi7eqps4.fsf@gmail.com \
--to=qiyaoltc@gmail.com \
--cc=Alan.Hayward@arm.com \
--cc=gdb-patches@sourceware.org \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox