From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 37679 invoked by alias); 24 Nov 2017 11:34:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 37661 invoked by uid 89); 24 Nov 2017 11:34:16 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.4 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_NUMSUBJECT,KB_WAM_FROM_NAME_SINGLEWORD,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: EUR01-DB5-obe.outbound.protection.outlook.com Received: from mail-db5eur01on0072.outbound.protection.outlook.com (HELO EUR01-DB5-obe.outbound.protection.outlook.com) (104.47.2.72) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 24 Nov 2017 11:34:10 +0000 Received: from AM3PR08MB0101.eurprd08.prod.outlook.com (10.160.211.19) by AM3PR08MB0102.eurprd08.prod.outlook.com (10.160.211.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.260.4; Fri, 24 Nov 2017 11:34:06 +0000 Received: from AM3PR08MB0101.eurprd08.prod.outlook.com ([fe80::48ab:82cd:a8b8:3a84]) by AM3PR08MB0101.eurprd08.prod.outlook.com ([fe80::48ab:82cd:a8b8:3a84%13]) with mapi id 15.20.0260.005; Fri, 24 Nov 2017 11:34:06 +0000 From: Alan Hayward To: Yao Qi CC: "gdb-patches@sourceware.org" , nd Subject: Re: [PATCH 3/4] Use flexible target descriptors for aarch64 Date: Fri, 24 Nov 2017 11:34:00 -0000 Message-ID: <20992757-30DB-41BE-AFBE-5EDB3CE8C5BE@arm.com> References: <86h8ugyenj.fsf@gmail.com> <8EE70574-8937-414B-9903-0E427D388B07@arm.com> <86a7zzwrs5.fsf@gmail.com> <86zi7eqps4.fsf@gmail.com> <20171123175034.GJ318@1170ee0b50d5> In-Reply-To: <20171123175034.GJ318@1170ee0b50d5> x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;AM3PR08MB0102;6:QmXlUqfrUdUXchOunM3pWA3xQRK1FdZPcv1Ov364JWeMOmDZT9NkZ63fCsWGEqCO/Pbh/qdad4DRn95y4/gis3seHixEgbXGHwujoGSE3u4Ngh/bmJnQixWxqJCEKlVIMploSqc5BMPihrkmP9GKQSxeJwjHPaxveowcqekhSwXFPEYDLMVZGjN5VuUzuj5hatP47pj7N1FyWjghMkqhc59cY2eXiC3cs6tYxcKAS9bbIoG8YuxteyyAww8dygXDyYZyxur5GQPFGoeiF2fkidqsnEFt+TRxrNdNZasoixy2cYoZh9NhTy4kyROMh3WXt/L6E1lDMf2vXM717J7aXfMHsvY69Q7qCkmaIDjc8BQ=;5:5vc6ja/qIE/xdsRt6qmKJDSOTn/R8ZexlRX6Ve5QOsBFc3ONcl69YmbZm/xULtaum8Sk/Sco6m9gVqHtJHdjxgE++ViyW3Lj+898A8sfP2h5SDP6EKjvUk2QvN0mxzyXc9OGIEhim9DnhGPoE2+fzJZKjNC0sLNLBDkkEjw/HYQ=;24:8LS2rF+uZQQPlG8MCacdg6+BQzBJRZveDvZ93vMXpWv3ZLXMqg66mXarNHuux99EMY9B+hrccukeOwdTqIPFtYx8j4lvcZREkLCaHX43gDY=;7:Rf2CATroYWJ3MKswbE9dRyHRSONjuIVq49kyzjyQvneqfeMOk4+5BHGdES/pwpLLc8+co1lJDaqTrOXh/fXOPt25i+reM3tOXUO//IvvSERndQDL7G0XxKxjwUFjL0zQemRlsEKy/9tYcsFnBIRQ+D5IXJJBRFXEqDCZ2zh9uOW76T7qLsH4JLP0uVd6LLvX3iPdXqv7RPDpdwZAna8XTlSqC9iT/lmNlfIz7m+CQv/e7r1KiHzViGJTthtY/nVg x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(48565401081)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(2017052603258);SRVR:AM3PR08MB0102; x-ms-traffictypediagnostic: AM3PR08MB0102: x-ms-office365-filtering-correlation-id: f9102ee3-cab1-4024-c0be-08d5332f45ac nodisclaimer: True x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040450)(2401047)(8121501046)(5005006)(3231022)(3002001)(10201501046)(93006095)(93001095)(6055026)(6041248)(20161123564025)(20161123558100)(20161123560025)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(6072148)(201708071742011);SRVR:AM3PR08MB0102;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:AM3PR08MB0102; x-forefront-prvs: 05015EB482 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(366004)(39860400002)(376002)(346002)(189002)(199003)(24454002)(377424004)(81166006)(81156014)(8676002)(68736007)(575784001)(25786009)(86362001)(66066001)(6436002)(5250100002)(4326008)(6506006)(6486002)(3660700001)(53936002)(6246003)(36756003)(229853002)(39060400002)(1411001)(6116002)(102836003)(3846002)(189998001)(3280700002)(2906002)(99286004)(2900100001)(6512007)(82746002)(101416001)(97736004)(72206003)(14454004)(76176999)(54356999)(50986999)(2950100002)(6916009)(93886005)(54906003)(8936002)(316002)(53546010)(5660300001)(33656002)(83716003)(305945005)(7736002)(105586002)(478600001)(106356001);DIR:OUT;SFP:1101;SCL:1;SRVR:AM3PR08MB0102;H:AM3PR08MB0101.eurprd08.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alan.Hayward@arm.com; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-ID: <14317961BC314C4D8C1D20ED7C017841@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-Network-Message-Id: f9102ee3-cab1-4024-c0be-08d5332f45ac X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Nov 2017 11:34:06.6972 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM3PR08MB0102 X-IsSubscribed: yes X-SW-Source: 2017-11/txt/msg00594.txt.bz2 > On 23 Nov 2017, at 17:50, Yao Qi wrote: >=20 > On 17-11-23 16:19:44, Alan Hayward wrote: >>=20 >> Files regenerated in patch below: >=20 > Commit log is the part to be reviewed in the patch review. It is > better to post the patch together with the commit log, although the > commit log may not be changed. >=20 >>=20 >>=20 >> diff --git a/gdb/arch/aarch64.c b/gdb/arch/aarch64.c >> index 95d9906f10e660fda99d73a0d2a9d184fd3a7b52..59f9330235e639d44920cab7= 9b595e5266a935ff 100644 >> --- a/gdb/arch/aarch64.c >> +++ b/gdb/arch/aarch64.c >> @@ -17,14 +17,27 @@ >>=20 >>=20 >> #include "aarch64.h" >> +#include >> +#include >>=20 >=20 > Is it necessary to include string.h? Otherwise, patch is good to me. >=20 Removed sting.h (I was sure I had a strcmp in here) All 4 Patches pushed. Alan.