From: Kevin Buettner <kevinb@redhat.com>
To: gdb-patches@sourceware.org
Cc: simon.marchi@polymtl.ca
Subject: Re: [PATCH 00/17] Move C++ support code out of .y files
Date: Fri, 4 Sep 2026 17:50:54 -0700 [thread overview]
Message-ID: <20260904175054.0f1ace55@f44-mesa-1> (raw)
In-Reply-To: <20260904170338.1643894-1-simon.marchi@polymtl.ca>
Hi Simon,
On Fri, 4 Sep 2026 12:56:32 -0400
simon.marchi@polymtl.ca wrote:
> From: Simon Marchi <simon.marchi@polymtl.ca>
>
> This series stated because I needed to read and potentially edit some
> code inside a .y and got annoyed that the typical C++ tooling didn't
> work. The end goal is to move the support code out of .y files and into
> proper C++ source files next to them.
>
> This series uses the yacc flags `-p` (symbol prefix) and `-t` (enable
> debug code). I tested this series with bison and the byacc package from
> Arch Linux. I believe that it should work on the various BSDs, but I
> have not tested (they all have their own byacc flavors I think). The
> yacc man pages from AIX and Solaris also claim to support them, but I
> have not tested. In any case, if the native yacc from a less commonly
> used platform struggles with this, I think it would be fine to ask
> people to use bison (assuming bison work on that platform). And
> remember, this is only needed for people who build from git. Generated
> parsers and lexers are shipped in tarballs.
>
> This series uses flex-specific flags, but I think we already required
> flex anyway (as opposed to other implementations of lex).
I ran this through my AI-based patch review workflow. It found a few
nits which I've replied to for patches #4, #12, #16, and #17. I think
that the nit for #12 ought to be fixed, but removal of the externs
in #16 and #17 is, IMO, less important due to the fact that someone
may wish to refer to <prefix>_yydebug when adding some debugging
statements. I think it'd be a nice cleanup to fix the YY_NULL to
YY_NULLPTR substitution problem in #4 too.
I've looked over the patches with my own eyes and they LGTM. So,
for the entire series, with at least the nit in #12 fixed:
Approved-By: Kevin Buettner <kevinb@redhat.com>
Kevin
prev parent reply other threads:[~2026-09-05 0:51 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-04 16:56 simon.marchi
2026-09-04 16:56 ` [PATCH 01/17] gdb/ada-exp-parser: remove name_info struct simon.marchi
2026-09-04 16:56 ` [PATCH 02/17] gdb: replace parse_type macros with functions simon.marchi
2026-09-04 16:56 ` [PATCH 03/17] gdb: suffix flex/bison output files with -gen.c simon.marchi
2026-09-04 16:56 ` [PATCH 04/17] gdb: move parser output post-processing to a script simon.marchi
2026-09-05 0:38 ` Kevin Buettner
2026-09-05 3:59 ` Simon Marchi
2026-09-04 16:56 ` [PATCH 05/17] gdb: let the parser and lexer generators prefix their symbols simon.marchi
2026-09-04 16:56 ` [PATCH 06/17] gdb: separate cp-name-parser's symbol prefix with an underscore simon.marchi
2026-09-04 16:56 ` [PATCH 07/17] gdb: make $(YACC) and $(FLEX) generate headers simon.marchi
2026-09-04 16:56 ` [PATCH 08/17] gdb: add check for stale build generated files simon.marchi
2026-09-04 16:56 ` [PATCH 09/17] gdb: move cp-name-parser.y's support code to cp-name-parser.c simon.marchi
2026-09-04 16:56 ` [PATCH 10/17] gdb: rename LANG-exp.y to LANG-exp-parser.y simon.marchi
2026-09-04 16:56 ` [PATCH 11/17] gdb: move c-exp-parser.y's support code to c-exp-parser.c simon.marchi
2026-09-04 16:56 ` [PATCH 12/17] gdb: move ada-exp-parser.y's support code to ada-exp-parser.c simon.marchi
2026-09-05 0:16 ` Kevin Buettner
2026-09-04 16:56 ` [PATCH 13/17] gdb: move d-exp-parser.y's support code to d-exp-parser.c simon.marchi
2026-09-04 16:56 ` [PATCH 14/17] gdb: move f-exp-parser.y's support code to f-exp-parser.c simon.marchi
2026-09-04 16:56 ` [PATCH 15/17] gdb: move go-exp-parser.y's support code to go-exp-parser.c simon.marchi
2026-09-04 16:56 ` [PATCH 16/17] gdb: move m2-exp-parser.y's support code to m2-exp-parser.c simon.marchi
2026-09-05 0:30 ` Kevin Buettner
2026-09-05 4:04 ` Simon Marchi
2026-09-04 16:56 ` [PATCH 17/17] gdb: move p-exp-parser.y's support code to p-exp-parser.c simon.marchi
2026-09-05 0:29 ` Kevin Buettner
2026-09-05 0:50 ` Kevin Buettner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260904175054.0f1ace55@f44-mesa-1 \
--to=kevinb@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox