Re: [PATCH 17/17] gdb: move p-exp-parser.y's support code to p-exp-parser.c

[Kevin Buettner <kevinb@redhat.com>]

On Fri,  4 Sep 2026 12:56:49 -0400
simon.marchi@polymtl.ca wrote:

> From: Simon Marchi <simon.marchi@polymtl.ca>
> 
> Similar to the previous commits, but for the Pascal expression parser.
> 
> Like the Fortran parser, the Pascal parser is entered through the
> pascal_language::parser method rather than a free function, so add a free
> function pascal_parse as the entry point (like the other parsers) and turn
> pascal_language::parser into a thin wrapper around it, defined in p-lang.c.
> 
> Put the parser support code inside the p_exp_parser namespace.
> 
> The Pascal support code uses malloc, realloc and free directly.  These used
> to be rewritten to their x-variants by post-process-parser-output.sh when
> the code was part of the generated parser.  Replace them with their
> x-variants in the moved code.
> 
> Change-Id: Ia9c7c36cde15f408ec89ecb14957f303410b70b2
> ---
>  gdb/Makefile.in    |   2 +
>  gdb/p-exp-parser.c | 954 +++++++++++++++++++++++++++++++++++++++++++++
>  gdb/p-exp-parser.h |  84 ++++
>  gdb/p-exp-parser.y | 924 +------------------------------------------
>  gdb/p-lang.c       |   9 +
>  5 files changed, 1051 insertions(+), 922 deletions(-)
>  create mode 100644 gdb/p-exp-parser.c
>  create mode 100644 gdb/p-exp-parser.h
> 
> diff --git a/gdb/Makefile.in b/gdb/Makefile.in
> index 1c4ba5a12d57..9f1e4a5198d0 100644
> --- a/gdb/Makefile.in
> +++ b/gdb/Makefile.in
> @@ -1163,6 +1163,7 @@ COMMON_SFILES = \
>  	opencl-lang.c \
>  	osabi.c \
>  	osdata.c \
> +	p-exp-parser.c \
>  	p-lang.c \
>  	p-typeprint.c \
>  	p-valprint.c \
> @@ -1606,6 +1607,7 @@ HFILES_NO_SRCDIR = \
>  	osdata.h \
>  	pager.h \
>  	parser-defs.h \
> +	p-exp-parser.h \
>  	p-lang.h \
>  	ppc64-tdep.h \
>  	ppc-fbsd-tdep.h \
> diff --git a/gdb/p-exp-parser.c b/gdb/p-exp-parser.c
> new file mode 100644
> index 000000000000..108c839d3f51
> --- /dev/null
> +++ b/gdb/p-exp-parser.c
> @@ -0,0 +1,954 @@
> +/* YACC parser support code for Pascal expressions, for GDB.
> +
> +   Copyright (C) 2000-2026 Free Software Foundation, Inc.
> +
> +   This file is part of GDB.
> +
> +   This program is free software; you can redistribute it and/or modify
> +   it under the terms of the GNU General Public License as published by
> +   the Free Software Foundation; either version 3 of the License, or
> +   (at your option) any later version.
> +
> +   This program is distributed in the hope that it will be useful,
> +   but WITHOUT ANY WARRANTY; without even the implied warranty of
> +   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +   GNU General Public License for more details.
> +
> +   You should have received a copy of the GNU General Public License
> +   along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
> +
> +#include "p-exp-parser.h"
> +#include "p-exp-parser-gen.h"
> +#include "block.h"
> +#include "expression.h"
> +#include "language.h"
> +#include "value.h"
> +
> +/* The entry point of the bison/yacc-generated parser, defined in
> +   p-exp-parser-gen.c.  Bison produces a declaration for pascal_yyparse in
> +   p-exp-parser-gen.h, but byacc does not, hence this declaration.  */
> +
> +int pascal_yyparse ();
> +
> +/* Likewise, byacc does not produce a declaration for pascal_yydebug.  */
> +
> +extern int pascal_yydebug;

This is a nit found by AI code review.  pascal_yydebug is defined here
as extern, but never used.

Kevin