From: Kevin Buettner <kevinb@redhat.com>
To: gdb-patches@sourceware.org
Cc: simon.marchi@polymtl.ca
Subject: Re: [PATCH 12/17] gdb: move ada-exp-parser.y's support code to ada-exp-parser.c
Date: Fri, 4 Sep 2026 17:16:59 -0700 [thread overview]
Message-ID: <20260904171659.3fdbe0b6@f44-mesa-1> (raw)
In-Reply-To: <20260904170338.1643894-13-simon.marchi@polymtl.ca>
On Fri, 4 Sep 2026 12:56:44 -0400
simon.marchi@polymtl.ca wrote:
> From: Simon Marchi <simon.marchi@polymtl.ca>
>
> Similar to the previous commit, but for the Ada expression parser.
>
> This one is slightly different because the Ada parser also uses a
> flex-generated lexer (the only one in the GDB tree to do so). So a few
> functions are moved from ada-exp.l to ada-exp-parser.{c,h}. But the idea
> remains the same.
>
> The lexer_init function is still defined in ada-exp.l, because it needs to
> see some special macros defined in ada-lex-gen.c.
>
> Put the parser support code inside the ada_exp_parser namespace.
>
> Change-Id: I38bee40f9b6c91c947ba8ab25fe9caa6fb9f9f15
> ---
> gdb/Makefile.in | 2 +
> gdb/ada-exp-parser.c | 1351 ++++++++++++++++++++++++++++++++++++++++++
> gdb/ada-exp-parser.h | 427 +++++++++++++
> gdb/ada-exp-parser.y | 1152 +----------------------------------
> gdb/ada-lang.c | 1 +
> gdb/ada-lang.h | 2 -
> gdb/ada-lex.l | 429 +-------------
> 7 files changed, 1790 insertions(+), 1574 deletions(-)
> create mode 100644 gdb/ada-exp-parser.c
> create mode 100644 gdb/ada-exp-parser.h
My AI-based patch review workflow identified the following nit:
gdb/ada-exp.h:456: comment still points to
ada-exp-parser.y:find_completion_bounds; the function moved to
ada-exp-parser.c:1204 in patch 12. Fix: update comment.
It correctly identified this patch as the one where that update
should be done.
Kevin
next prev parent reply other threads:[~2026-09-05 0:17 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-04 16:56 [PATCH 00/17] Move C++ support code out of .y files simon.marchi
2026-09-04 16:56 ` [PATCH 01/17] gdb/ada-exp-parser: remove name_info struct simon.marchi
2026-09-04 16:56 ` [PATCH 02/17] gdb: replace parse_type macros with functions simon.marchi
2026-09-04 16:56 ` [PATCH 03/17] gdb: suffix flex/bison output files with -gen.c simon.marchi
2026-09-04 16:56 ` [PATCH 04/17] gdb: move parser output post-processing to a script simon.marchi
2026-09-05 0:38 ` Kevin Buettner
2026-09-05 3:59 ` Simon Marchi
2026-09-04 16:56 ` [PATCH 05/17] gdb: let the parser and lexer generators prefix their symbols simon.marchi
2026-09-04 16:56 ` [PATCH 06/17] gdb: separate cp-name-parser's symbol prefix with an underscore simon.marchi
2026-09-04 16:56 ` [PATCH 07/17] gdb: make $(YACC) and $(FLEX) generate headers simon.marchi
2026-09-04 16:56 ` [PATCH 08/17] gdb: add check for stale build generated files simon.marchi
2026-09-04 16:56 ` [PATCH 09/17] gdb: move cp-name-parser.y's support code to cp-name-parser.c simon.marchi
2026-09-04 16:56 ` [PATCH 10/17] gdb: rename LANG-exp.y to LANG-exp-parser.y simon.marchi
2026-09-04 16:56 ` [PATCH 11/17] gdb: move c-exp-parser.y's support code to c-exp-parser.c simon.marchi
2026-09-04 16:56 ` [PATCH 12/17] gdb: move ada-exp-parser.y's support code to ada-exp-parser.c simon.marchi
2026-09-05 0:16 ` Kevin Buettner [this message]
2026-09-04 16:56 ` [PATCH 13/17] gdb: move d-exp-parser.y's support code to d-exp-parser.c simon.marchi
2026-09-04 16:56 ` [PATCH 14/17] gdb: move f-exp-parser.y's support code to f-exp-parser.c simon.marchi
2026-09-04 16:56 ` [PATCH 15/17] gdb: move go-exp-parser.y's support code to go-exp-parser.c simon.marchi
2026-09-04 16:56 ` [PATCH 16/17] gdb: move m2-exp-parser.y's support code to m2-exp-parser.c simon.marchi
2026-09-05 0:30 ` Kevin Buettner
2026-09-05 4:04 ` Simon Marchi
2026-09-04 16:56 ` [PATCH 17/17] gdb: move p-exp-parser.y's support code to p-exp-parser.c simon.marchi
2026-09-05 0:29 ` Kevin Buettner
2026-09-05 0:50 ` [PATCH 00/17] Move C++ support code out of .y files Kevin Buettner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260904171659.3fdbe0b6@f44-mesa-1 \
--to=kevinb@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox