From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id BF1aKZ1fm2oFvioAWB0awg (envelope-from ) for ; Fri, 04 Sep 2026 20:17:33 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=iEMkS8nQ; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 922071E033; Fri, 04 Sep 2026 20:17:33 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_SBL_CSS autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id EE61E1E033 for ; Fri, 04 Sep 2026 20:17:31 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 6040C4BB58C2 for ; Sat, 5 Sep 2026 00:17:30 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6040C4BB58C2 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=iEMkS8nQ Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id 1340A4BB58A5 for ; Sat, 5 Sep 2026 00:17:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1340A4BB58A5 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1340A4BB58A5 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1788567426; cv=none; b=eZHvwQFZabnwvPqlqtsJndPWsFnOMRHEhKm0PoHPOwytqzSxLnpJY4rrLbDjEQ15WRY/v17HJ2bopo5gmuc1/K2xq6yUWPPzOnNMvT58rsJwbC13MJ2AMHhR+bOHfGOJPE+LDZFjHM+WZc9tGYUU/JN4kpuNoZ0iu1Zrhi8VSwU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1788567426; c=relaxed/simple; bh=NlvE/tVKPQA4Vd4lI4BjoLmy0J++/uITgB9mhs6fPsw=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=hu14gB5f7TFcesDW9ER0WtIDdSXfKB8YEVp2356pVkiIxBZHByK4gmXZmwZ4zLoQ5WBGYBeDq2+laHp9WuuwUOKocigMEl7bAmNzvf3+Rn+W9Jzb5QVfpHX8lB3b2acoAC6/kIDGAKlRHv5xZWbhPk/5mCe0SC8j68rZpG2Gf50= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=iEMkS8nQ DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1340A4BB58A5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1788567425; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gBXMN2y+UjrxC80mCo0v1xziTFUyEtqolTWbyqYqzRs=; b=iEMkS8nQMBcbPbB5cxeMJo03F5LxfCWekldCHMBRgGtcTRVO5Xh2B84/i7/qdS8JXbQZk6 k0H35eZrI9cpeirR3p5FG0vzaZZfIrP50Td4+KjO6CUh5JVVFtWm16xGqlj3K2HP91AvBi JGq8XcWksQb99tKC2yaeRYoE4mdoYwQ= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-283-V0P1cwRGPXugAmlHipPXoA-1; Fri, 04 Sep 2026 20:17:04 -0400 X-MC-Unique: V0P1cwRGPXugAmlHipPXoA-1 X-Mimecast-MFC-AGG-ID: V0P1cwRGPXugAmlHipPXoA_1788567423 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 631361944EBF; Sat, 5 Sep 2026 00:17:03 +0000 (UTC) Received: from f44-mesa-1 (unknown [10.22.64.36]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 801FE1800642; Sat, 5 Sep 2026 00:17:02 +0000 (UTC) Date: Fri, 4 Sep 2026 17:16:59 -0700 From: Kevin Buettner To: gdb-patches@sourceware.org Cc: simon.marchi@polymtl.ca Subject: Re: [PATCH 12/17] gdb: move ada-exp-parser.y's support code to ada-exp-parser.c Message-ID: <20260904171659.3fdbe0b6@f44-mesa-1> In-Reply-To: <20260904170338.1643894-13-simon.marchi@polymtl.ca> References: <20260904170338.1643894-1-simon.marchi@polymtl.ca> <20260904170338.1643894-13-simon.marchi@polymtl.ca> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Ry1Mw_vhWF5GsCA9q-WpYL5lnsxmnIiBcjYgIFbsLWE_1788567423 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On Fri, 4 Sep 2026 12:56:44 -0400 simon.marchi@polymtl.ca wrote: > From: Simon Marchi > > Similar to the previous commit, but for the Ada expression parser. > > This one is slightly different because the Ada parser also uses a > flex-generated lexer (the only one in the GDB tree to do so). So a few > functions are moved from ada-exp.l to ada-exp-parser.{c,h}. But the idea > remains the same. > > The lexer_init function is still defined in ada-exp.l, because it needs to > see some special macros defined in ada-lex-gen.c. > > Put the parser support code inside the ada_exp_parser namespace. > > Change-Id: I38bee40f9b6c91c947ba8ab25fe9caa6fb9f9f15 > --- > gdb/Makefile.in | 2 + > gdb/ada-exp-parser.c | 1351 ++++++++++++++++++++++++++++++++++++++++++ > gdb/ada-exp-parser.h | 427 +++++++++++++ > gdb/ada-exp-parser.y | 1152 +---------------------------------- > gdb/ada-lang.c | 1 + > gdb/ada-lang.h | 2 - > gdb/ada-lex.l | 429 +------------- > 7 files changed, 1790 insertions(+), 1574 deletions(-) > create mode 100644 gdb/ada-exp-parser.c > create mode 100644 gdb/ada-exp-parser.h My AI-based patch review workflow identified the following nit: gdb/ada-exp.h:456: comment still points to ada-exp-parser.y:find_completion_bounds; the function moved to ada-exp-parser.c:1204 in patch 12. Fix: update comment. It correctly identified this patch as the one where that update should be done. Kevin