From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id KcmFAZBnm2ou5yoAWB0awg (envelope-from ) for ; Fri, 04 Sep 2026 20:51:28 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=iLOSoNGa; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 0232D1E166; Fri, 04 Sep 2026 20:51:27 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_SBL_CSS,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=no autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 13C921E033 for ; Fri, 04 Sep 2026 20:51:27 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 862424BB58E6 for ; Sat, 5 Sep 2026 00:51:26 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 862424BB58E6 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=iLOSoNGa Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 0063D4BA2E0F for ; Sat, 5 Sep 2026 00:51:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0063D4BA2E0F Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0063D4BA2E0F Authentication-Results: sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1788569463; cv=none; b=CfcZhlK8JopNukmv7GZVdHwIkVnD2a/FoPcNxpAwmSRNdqqNmNcp4SCw7b4t2qW1p8eqCzF9uWWEgDzRBJriVp09Ms2IsfP5NGJp9neQMpzHf2v9rmugUWKrNqIgIe47QilVB+uop8pHgFLeP5K4ELaUjSVNSbc5cNOE3xhxM2A= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1788569463; c=relaxed/simple; bh=jIQ5mQHCd2xQTaPCWe0y+s7qfnB/qm1rAOOwCz5CUD4=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=owOGf4btGtSn5xVln9o8m/AkXTRYRq8eEEi0uKi/b+Ec/ZssZtaYucFT8SQE/3JovwN7ZKplB641KJ2iY61iNfIDgaE+gF7kC+r3O1Wmw/63iENcE/JDzhz0uTXRcgyHZ5Z350lAtTv+bdY+C8IPSSvTJ/m18iHiiX7OH/uYu8s= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=iLOSoNGa DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0063D4BA2E0F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1788569462; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9JzxJpZqNEI8vf1sL3X20kjpiotMrZO/EILMZ+QClkM=; b=iLOSoNGaPE0TRpdNrsMmeqN1nTPfgM5SV26hJZ2EbLDXyMTqOiZssXbTXyskaLtkyvDcCi L88zvF3nWZ1JuToWtxVrPdzop386D39A9BN/yQaOc03b9dgWnA/a9I/dotsB8JimiiqE6S tDBLGHmGpl0hxAZf+QO+jAHaNpfB5PY= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-6-cvHwtCqON-CqukAr4iPHIQ-1; Fri, 04 Sep 2026 20:50:59 -0400 X-MC-Unique: cvHwtCqON-CqukAr4iPHIQ-1 X-Mimecast-MFC-AGG-ID: cvHwtCqON-CqukAr4iPHIQ_1788569458 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 62A1E195DE55; Sat, 5 Sep 2026 00:50:58 +0000 (UTC) Received: from f44-mesa-1 (unknown [10.22.64.36]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 906AB30002F4; Sat, 5 Sep 2026 00:50:57 +0000 (UTC) Date: Fri, 4 Sep 2026 17:50:54 -0700 From: Kevin Buettner To: gdb-patches@sourceware.org Cc: simon.marchi@polymtl.ca Subject: Re: [PATCH 00/17] Move C++ support code out of .y files Message-ID: <20260904175054.0f1ace55@f44-mesa-1> In-Reply-To: <20260904170338.1643894-1-simon.marchi@polymtl.ca> References: <20260904170338.1643894-1-simon.marchi@polymtl.ca> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 7kBy_BKqIV953wX_WaeyY3KrYIFbBSQiRX1eG4ChfCg_1788569458 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Hi Simon, On Fri, 4 Sep 2026 12:56:32 -0400 simon.marchi@polymtl.ca wrote: > From: Simon Marchi > > This series stated because I needed to read and potentially edit some > code inside a .y and got annoyed that the typical C++ tooling didn't > work. The end goal is to move the support code out of .y files and into > proper C++ source files next to them. > > This series uses the yacc flags `-p` (symbol prefix) and `-t` (enable > debug code). I tested this series with bison and the byacc package from > Arch Linux. I believe that it should work on the various BSDs, but I > have not tested (they all have their own byacc flavors I think). The > yacc man pages from AIX and Solaris also claim to support them, but I > have not tested. In any case, if the native yacc from a less commonly > used platform struggles with this, I think it would be fine to ask > people to use bison (assuming bison work on that platform). And > remember, this is only needed for people who build from git. Generated > parsers and lexers are shipped in tarballs. > > This series uses flex-specific flags, but I think we already required > flex anyway (as opposed to other implementations of lex). I ran this through my AI-based patch review workflow. It found a few nits which I've replied to for patches #4, #12, #16, and #17. I think that the nit for #12 ought to be fixed, but removal of the externs in #16 and #17 is, IMO, less important due to the fact that someone may wish to refer to _yydebug when adding some debugging statements. I think it'd be a nice cleanup to fix the YY_NULL to YY_NULLPTR substitution problem in #4 too. I've looked over the patches with my own eyes and they LGTM. So, for the entire series, with at least the nit in #12 fixed: Approved-By: Kevin Buettner Kevin