* [PATCH] gdb, amd-dbgapi-target: fix extra space in wave_coordinates
@ 2026-07-08 9:18 Tankut Baris Aktemur
2026-07-08 17:44 ` Lancelot SIX
0 siblings, 1 reply; 2+ messages in thread
From: Tankut Baris Aktemur @ 2026-07-08 9:18 UTC (permalink / raw)
To: gdb-patches; +Cc: lancelot.six
In commit 57f5450 ("gdb, amd-dbgapi-target: split
wave_coordinates::to_string"), I mistakenly left extra space in the
output of wave_coordinates' string methods. Fix this.
---
gdb/amd-dbgapi-target.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/gdb/amd-dbgapi-target.c b/gdb/amd-dbgapi-target.c
index f273d5076bd..b4ca1506906 100644
--- a/gdb/amd-dbgapi-target.c
+++ b/gdb/amd-dbgapi-target.c
@@ -402,7 +402,7 @@ wave_coordinates::hierarchy_str () const
{
std::string str
= (agent_id != AMD_DBGAPI_AGENT_NONE
- ? string_printf (" %s", pulongest (agent_id.handle))
+ ? string_printf ("%s", pulongest (agent_id.handle))
: "?");
str += (queue_id != AMD_DBGAPI_QUEUE_NONE
@@ -423,7 +423,7 @@ wave_coordinates::workgroup_coord_str () const
{
std::string str
= (group_ids[0] != UINT32_MAX
- ? string_printf (" (%s,%s,%s)", pulongest (group_ids[0]),
+ ? string_printf ("(%s,%s,%s)", pulongest (group_ids[0]),
pulongest (group_ids[1]), pulongest (group_ids[2]))
: "(?,?,?)");
--
2.34.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] gdb, amd-dbgapi-target: fix extra space in wave_coordinates
2026-07-08 9:18 [PATCH] gdb, amd-dbgapi-target: fix extra space in wave_coordinates Tankut Baris Aktemur
@ 2026-07-08 17:44 ` Lancelot SIX
0 siblings, 0 replies; 2+ messages in thread
From: Lancelot SIX @ 2026-07-08 17:44 UTC (permalink / raw)
To: Tankut Baris Aktemur, gdb-patches
On Wed, Jul 08, 2026 at 04:18:53AM -0500, Tankut Baris Aktemur wrote:
> In commit 57f5450 ("gdb, amd-dbgapi-target: split
> wave_coordinates::to_string"), I mistakenly left extra space in the
> output of wave_coordinates' string methods. Fix this.
>
Hi,
Thanks for the fix.
Approved-by: Lancelot Six <lancelot.six@amd.com> (amdgpu)
Best,
Lancelot
> ---
> gdb/amd-dbgapi-target.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/gdb/amd-dbgapi-target.c b/gdb/amd-dbgapi-target.c
> index f273d5076bd..b4ca1506906 100644
> --- a/gdb/amd-dbgapi-target.c
> +++ b/gdb/amd-dbgapi-target.c
> @@ -402,7 +402,7 @@ wave_coordinates::hierarchy_str () const
> {
> std::string str
> = (agent_id != AMD_DBGAPI_AGENT_NONE
> - ? string_printf (" %s", pulongest (agent_id.handle))
> + ? string_printf ("%s", pulongest (agent_id.handle))
> : "?");
>
> str += (queue_id != AMD_DBGAPI_QUEUE_NONE
> @@ -423,7 +423,7 @@ wave_coordinates::workgroup_coord_str () const
> {
> std::string str
> = (group_ids[0] != UINT32_MAX
> - ? string_printf (" (%s,%s,%s)", pulongest (group_ids[0]),
> + ? string_printf ("(%s,%s,%s)", pulongest (group_ids[0]),
> pulongest (group_ids[1]), pulongest (group_ids[2]))
> : "(?,?,?)");
>
> --
> 2.34.1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-07-08 17:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-07-08 9:18 [PATCH] gdb, amd-dbgapi-target: fix extra space in wave_coordinates Tankut Baris Aktemur
2026-07-08 17:44 ` Lancelot SIX
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox