From: Lancelot SIX <lancelot.six@amd.com>
To: Tankut Baris Aktemur <tankutbaris.aktemur@amd.com>,
<gdb-patches@sourceware.org>
Subject: Re: [PATCH] gdb, amd-dbgapi-target: fix extra space in wave_coordinates
Date: Wed, 8 Jul 2026 18:44:13 +0100 [thread overview]
Message-ID: <yj6izvr447cik74trk4e6spbxmyvuejwqnhpp3grct4p5wseje@i5u5nyhaejqt> (raw)
In-Reply-To: <20260708091853.296116-1-tankutbaris.aktemur@amd.com>
On Wed, Jul 08, 2026 at 04:18:53AM -0500, Tankut Baris Aktemur wrote:
> In commit 57f5450 ("gdb, amd-dbgapi-target: split
> wave_coordinates::to_string"), I mistakenly left extra space in the
> output of wave_coordinates' string methods. Fix this.
>
Hi,
Thanks for the fix.
Approved-by: Lancelot Six <lancelot.six@amd.com> (amdgpu)
Best,
Lancelot
> ---
> gdb/amd-dbgapi-target.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/gdb/amd-dbgapi-target.c b/gdb/amd-dbgapi-target.c
> index f273d5076bd..b4ca1506906 100644
> --- a/gdb/amd-dbgapi-target.c
> +++ b/gdb/amd-dbgapi-target.c
> @@ -402,7 +402,7 @@ wave_coordinates::hierarchy_str () const
> {
> std::string str
> = (agent_id != AMD_DBGAPI_AGENT_NONE
> - ? string_printf (" %s", pulongest (agent_id.handle))
> + ? string_printf ("%s", pulongest (agent_id.handle))
> : "?");
>
> str += (queue_id != AMD_DBGAPI_QUEUE_NONE
> @@ -423,7 +423,7 @@ wave_coordinates::workgroup_coord_str () const
> {
> std::string str
> = (group_ids[0] != UINT32_MAX
> - ? string_printf (" (%s,%s,%s)", pulongest (group_ids[0]),
> + ? string_printf ("(%s,%s,%s)", pulongest (group_ids[0]),
> pulongest (group_ids[1]), pulongest (group_ids[2]))
> : "(?,?,?)");
>
> --
> 2.34.1
prev parent reply other threads:[~2026-07-08 17:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-08 9:18 Tankut Baris Aktemur
2026-07-08 17:44 ` Lancelot SIX [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yj6izvr447cik74trk4e6spbxmyvuejwqnhpp3grct4p5wseje@i5u5nyhaejqt \
--to=lancelot.six@amd.com \
--cc=gdb-patches@sourceware.org \
--cc=tankutbaris.aktemur@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox