From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id CfUWHqGMTmqjnCwAWB0awg (envelope-from ) for ; Wed, 08 Jul 2026 13:45:05 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=lWJDxQ2s; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 765A31E098; Wed, 08 Jul 2026 13:45:05 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 616831E024 for ; Wed, 08 Jul 2026 13:45:04 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 2A8344BA2E19 for ; Wed, 8 Jul 2026 17:45:02 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2A8344BA2E19 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=lWJDxQ2s Received: from SN4PR0501CU005.outbound.protection.outlook.com (mail-southcentralusazlp170110003.outbound.protection.outlook.com [IPv6:2a01:111:f403:c10d::3]) by sourceware.org (Postfix) with ESMTPS id A5A3D4BA543C for ; Wed, 8 Jul 2026 17:44:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A5A3D4BA543C Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=amd.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A5A3D4BA543C Authentication-Results: sourceware.org; arc=pass smtp.remote-ip=2a01:111:f403:c10d::3 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1783532676; cv=pass; b=XKzlY/SMMzGfwhwY3SJDVKvx28LeHB087pztbpvhYYJ9Yo6rTMLX9Roz3wHlGzqMUKrVBDHy/tcqug7jTghqYPcSXov9WD4ofQgWRpuY02NX36BK9vfo/bEh/R0gh1/tmUyWHgMnmnWaSxFFS+3nUEsy2k8n1bVy3nVdcQzxAnQ= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1783532676; c=relaxed/simple; bh=tYsqaSUOvYbPzGGq6Kff58iTik2l2bm6Q3MCklSqj2M=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=TfwvE45KLpW4oRRXGrG7VWP8WcvW/i5Bqch0cxeEkD5ea7DG1nTM2YnU/QcfsjS4oKHyPNgo9OsSLs2CSQrzJ7U+sz7RqUIZe4l/K4BL+Uh0z4VYEQxHPITSzn6yIdgTcFxHNt317AxD1plWR+Uz34T061YyKEYB3QK6HHeYKVU= ARC-Authentication-Results: i=2; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=lWJDxQ2s DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A5A3D4BA543C ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=lNrBRvdNWGnw3mwPKOAPa2GtJdtd7qx7Ajilj9xRwabyZnPm35m9SVo1/IJrmKm3Vjn5gqZhgWKzUxHYnOIsE87D6Te5NA40jnX3tj7LFc+Ftd1nudT+I9H7PIVE3uQDbZ4BMTmZ5IfsT7w5lqlM8i0CCUXtpVhkjN1gmEMzogKu6Wrl+mnoGw0ePXCVnbmC7rgaM2zrhRQ77Tx/9MFzrvbBk8hzwdxXQjPnPmxmfqxOIQlqqNzHuMHqP05BdTDGTmDqC88EHuVKqO1iQC4M/GCx9DXQTQI86alSoAixQKMEdf4u//5iZsAedFaKF83oGHu+hj27RsGnw2kYJksZag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=y4i5LkIEufyqfItynwd2h2u3ujqt93hycWWvqIjA6m4=; b=GUs9q9+QoZhEj36eYa/YvQcZgefj2wea1kxgI7ZLZtkGgVQRHcuv658Kq3A3NzT55HB2WJ849C6c5hnXqnDOHQr/xRvfKs7hh7Jkzsrbpud185T5gjEbUapPT8YyEYLW0J4yN1FanMmJTvSz8DRVMi9p/1IE0/LjLKQ1yXKxfpUGPTIpsbFRUtUjsEQl1sILBpEdHSFHJGhHUjWdMwhJIhULxCqpKXL3OY75EZY8fkDvsc2InIMTmOcQ8CzTkz1L5EdZqbB2/Vg8oHzOvy0gyORLoznAGq9VNnhvjlhNoCFiCZCtd4rgGWvv+ekEFoJ6ZRjE1sjcR59+6d2BOvyeuQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=sourceware.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=y4i5LkIEufyqfItynwd2h2u3ujqt93hycWWvqIjA6m4=; b=lWJDxQ2s8A3vpJvEGGBO3ZOF9J7kIyRmg4HVnzNwrYPF7FiyBqQInf31veOopq4nKg0VyHX5ydnZNnn/YjLEBI9/Ypr1wIbbisHSROQTw4IspqxjQYH/DlnMbdFCrfXeIa9ecVwUznXOdR6W5hKGIV9urUAVxDuokh8L10hDgkY= Received: from DS7PR03CA0338.namprd03.prod.outlook.com (2603:10b6:8:55::31) by LV2PR12MB5821.namprd12.prod.outlook.com (2603:10b6:408:17a::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.10; Wed, 8 Jul 2026 17:44:22 +0000 Received: from DM2PEPF00003FC2.namprd04.prod.outlook.com (2603:10b6:8:55:cafe::87) by DS7PR03CA0338.outlook.office365.com (2603:10b6:8:55::31) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.202.10 via Frontend Transport; Wed, 8 Jul 2026 17:44:22 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by DM2PEPF00003FC2.mail.protection.outlook.com (10.167.23.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.6 via Frontend Transport; Wed, 8 Jul 2026 17:44:22 +0000 Received: from khazad-dum (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.41; Wed, 8 Jul 2026 12:44:21 -0500 Date: Wed, 8 Jul 2026 18:44:13 +0100 From: Lancelot SIX To: Tankut Baris Aktemur , Subject: Re: [PATCH] gdb, amd-dbgapi-target: fix extra space in wave_coordinates Message-ID: References: <20260708091853.296116-1-tankutbaris.aktemur@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20260708091853.296116-1-tankutbaris.aktemur@amd.com> X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: satlexmb07.amd.com (10.181.42.216) To satlexmb07.amd.com (10.181.42.216) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM2PEPF00003FC2:EE_|LV2PR12MB5821:EE_ X-MS-Office365-Filtering-Correlation-Id: afbc31ef-3d0f-4633-b238-08dedd188b77 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|23010399003|1800799024|82310400026|36860700016|376014|18002099003|22082099003|3023799007|11063799006|56012099006; X-Microsoft-Antispam-Message-Info: BfpaopIlLad+AjD3methVex4wLDeIDxc1Q7InnqMwxnVILUi7rXqIZ/Vk3vGd8bVNBVQhvUp579+3rnvvAHOGjjE0MK84pMFP7wHUATqjCiwUpk5vH/pfVUZ/tNFX8Y39gmmqCxbAcHtrb1U6nUs4ssGo3q/bvwAmadJraWgJapJ1hp3qnR//KCUFznY3RQQWxIBiuNJCM4UH9fj48bCAJ97yuirIqTgznlscYJpXN1s3cNDbDHD1lpVHn4pVvWCtoVXNMVLe2/S6IzVZDt9OzcnWN5iPA4wB2fFR9UaJ/WZACgWMeZ4kv1iHbhVjQDi+eU/LaQ3wRFWLY4up+zw7n8XPDeJGsk1jrt4HB7g9DjYes6agxniR1KdNzsSa3o/geX0VXRta1HgHlhatsRhXJnxKJK125+vIeO2t1N9ZBl5ymb3JMVMo2NnA9C+eUGVjlQkf59CDd2CMGx+mhysKcrEfIhvQnQvyMT6+7gOrPnVnwurlf7a6vUQ3MHeRLe1Rzvi/MktcuVNsUqeSwvzyKae3CVVKnoG8klUSoRREShoBL3iI+UgHO0w07rd1v4BQYzW5vCjwbwxsth6XahVg7yR7fAQ907fkaxSSz+Sp2BRk/6/0ufeWackRKO622WTKK93w1wK2VpdiwxzyP/OBb2IxX55YRv/hv9ZrpKHJqghzM9WYxx+VEG1QE+oKVdtbp50YL0d3Ebcdbxs3m9S4w== X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:satlexmb07.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(23010399003)(1800799024)(82310400026)(36860700016)(376014)(18002099003)(22082099003)(3023799007)(11063799006)(56012099006); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: vBD5nR763Hva3UpLgf8DSZHPRkDN3F7lnmWKd2QDwmbnpJ/fJpIMDfa4wk4NlQ+dTmPaFVBTJGv4Z5czXXHzfpRSDjAuhXEfG7QdFXQC5FJ7VeSwlbK4OwGnN+m2rKP3Mr1Yc2som5sxUh15elal8ZJKm1HbRpQXPT4lNBwzt5Gz0ExtW3u3bcKG/UOIhjHoLasUqTAnCBWZG3xapOoz26+nASOsVoNlI+jw8aiBQxviDsIT4fCJS94G2/clTIXv3T4qu1bXftTz5b00JPFvxq+Q5zc0TLHbSwAiGsiYoc6cK4a++1nrN4Wrha1IolWORF+39hZOlGqK7QexSg2hWcdOxzyWCH3dBV+uAF5El7WwHQtdSdrWT/mq3RVmHtp4zZtI/L9LQmFfzpuh5wrSE5ChLMsfCmtFRbgCGTO8wX66p65diuWtBr897h26Mavz X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jul 2026 17:44:22.1593 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: afbc31ef-3d0f-4633-b238-08dedd188b77 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM2PEPF00003FC2.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV2PR12MB5821 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On Wed, Jul 08, 2026 at 04:18:53AM -0500, Tankut Baris Aktemur wrote: > In commit 57f5450 ("gdb, amd-dbgapi-target: split > wave_coordinates::to_string"), I mistakenly left extra space in the > output of wave_coordinates' string methods. Fix this. > Hi, Thanks for the fix. Approved-by: Lancelot Six (amdgpu) Best, Lancelot > --- > gdb/amd-dbgapi-target.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/gdb/amd-dbgapi-target.c b/gdb/amd-dbgapi-target.c > index f273d5076bd..b4ca1506906 100644 > --- a/gdb/amd-dbgapi-target.c > +++ b/gdb/amd-dbgapi-target.c > @@ -402,7 +402,7 @@ wave_coordinates::hierarchy_str () const > { > std::string str > = (agent_id != AMD_DBGAPI_AGENT_NONE > - ? string_printf (" %s", pulongest (agent_id.handle)) > + ? string_printf ("%s", pulongest (agent_id.handle)) > : "?"); > > str += (queue_id != AMD_DBGAPI_QUEUE_NONE > @@ -423,7 +423,7 @@ wave_coordinates::workgroup_coord_str () const > { > std::string str > = (group_ids[0] != UINT32_MAX > - ? string_printf (" (%s,%s,%s)", pulongest (group_ids[0]), > + ? string_printf ("(%s,%s,%s)", pulongest (group_ids[0]), > pulongest (group_ids[1]), pulongest (group_ids[2])) > : "(?,?,?)"); > > -- > 2.34.1