[PATCH] Remove minimal_symbol_reader::record

[PATCH] Remove minimal_symbol_reader::record

[Tom Tromey]

After the various symbol reader removals, it seems that
minimal_symbol_reader::record is no longer needed.
---
 gdb/minsyms.c | 32 --------------------------------
 gdb/minsyms.h | 10 ----------
 2 files changed, 42 deletions(-)

diff --git a/gdb/minsyms.c b/gdb/minsyms.c
index dff2cb4a045..71cd1bb4c2b 100644
--- a/gdb/minsyms.c
+++ b/gdb/minsyms.c
@@ -1080,38 +1080,6 @@ minimal_symbol_reader::minimal_symbol_reader (struct objfile *obj)
 {
 }
 
-/* See minsyms.h.  */
-
-void
-minimal_symbol_reader::record (const char *name, unrelocated_addr address,
-			       enum minimal_symbol_type ms_type)
-{
-  int section;
-
-  switch (ms_type)
-    {
-    case mst_text:
-    case mst_text_gnu_ifunc:
-    case mst_file_text:
-    case mst_solib_trampoline:
-      section = SECT_OFF_TEXT (m_objfile);
-      break;
-    case mst_data:
-    case mst_data_gnu_ifunc:
-    case mst_file_data:
-      section = SECT_OFF_DATA (m_objfile);
-      break;
-    case mst_bss:
-    case mst_file_bss:
-      section = SECT_OFF_BSS (m_objfile);
-      break;
-    default:
-      section = -1;
-    }
-
-  record_with_info (name, address, ms_type, section);
-}
-
 /* Convert an enumerator of type minimal_symbol_type to its string
    representation.  */
 
diff --git a/gdb/minsyms.h b/gdb/minsyms.h
index 4eb795ce095..8f38cc7137f 100644
--- a/gdb/minsyms.h
+++ b/gdb/minsyms.h
@@ -123,16 +123,6 @@ class minimal_symbol_reader
 				      enum minimal_symbol_type ms_type,
 				      int section);
 
-  /* Like record_full, but:
-     - computes the length of NAME
-     - passes COPY_NAME = true,
-     - and passes a default SECTION, depending on the type
-
-     This variant does not return the new symbol.  */
-
-  void record (const char *name, unrelocated_addr address,
-	       enum minimal_symbol_type ms_type);
-
   /* Like record_full, but:
      - computes the length of NAME
      - passes COPY_NAME = true.
-- 
2.49.0

Re: [PATCH] Remove minimal_symbol_reader::record

[Simon Marchi]

On 2026-03-08 08:28, Tom Tromey wrote:
> After the various symbol reader removals, it seems that
> minimal_symbol_reader::record is no longer needed.

If true, seems obvious to me :)

Approved-By: Simon Marchi <simon.marchi@efficios.com>

Simon