From: Tom Tromey <tom@tromey.com>
To: gdb-patches@sourceware.org
Cc: Tom Tromey <tom@tromey.com>
Subject: [PATCH] Remove minimal_symbol_reader::record
Date: Sun, 8 Mar 2026 06:28:33 -0600 [thread overview]
Message-ID: <20260308122833.640495-1-tom@tromey.com> (raw)
After the various symbol reader removals, it seems that
minimal_symbol_reader::record is no longer needed.
---
gdb/minsyms.c | 32 --------------------------------
gdb/minsyms.h | 10 ----------
2 files changed, 42 deletions(-)
diff --git a/gdb/minsyms.c b/gdb/minsyms.c
index dff2cb4a045..71cd1bb4c2b 100644
--- a/gdb/minsyms.c
+++ b/gdb/minsyms.c
@@ -1080,38 +1080,6 @@ minimal_symbol_reader::minimal_symbol_reader (struct objfile *obj)
{
}
-/* See minsyms.h. */
-
-void
-minimal_symbol_reader::record (const char *name, unrelocated_addr address,
- enum minimal_symbol_type ms_type)
-{
- int section;
-
- switch (ms_type)
- {
- case mst_text:
- case mst_text_gnu_ifunc:
- case mst_file_text:
- case mst_solib_trampoline:
- section = SECT_OFF_TEXT (m_objfile);
- break;
- case mst_data:
- case mst_data_gnu_ifunc:
- case mst_file_data:
- section = SECT_OFF_DATA (m_objfile);
- break;
- case mst_bss:
- case mst_file_bss:
- section = SECT_OFF_BSS (m_objfile);
- break;
- default:
- section = -1;
- }
-
- record_with_info (name, address, ms_type, section);
-}
-
/* Convert an enumerator of type minimal_symbol_type to its string
representation. */
diff --git a/gdb/minsyms.h b/gdb/minsyms.h
index 4eb795ce095..8f38cc7137f 100644
--- a/gdb/minsyms.h
+++ b/gdb/minsyms.h
@@ -123,16 +123,6 @@ class minimal_symbol_reader
enum minimal_symbol_type ms_type,
int section);
- /* Like record_full, but:
- - computes the length of NAME
- - passes COPY_NAME = true,
- - and passes a default SECTION, depending on the type
-
- This variant does not return the new symbol. */
-
- void record (const char *name, unrelocated_addr address,
- enum minimal_symbol_type ms_type);
-
/* Like record_full, but:
- computes the length of NAME
- passes COPY_NAME = true.
--
2.49.0
next reply other threads:[~2026-03-08 12:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-08 12:28 Tom Tromey [this message]
2026-03-09 2:38 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260308122833.640495-1-tom@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox