From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id QvtdI5trrWlDRRwAWB0awg (envelope-from ) for ; Sun, 08 Mar 2026 08:29:15 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=vEQMki1+; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 7903D1E0DD; Sun, 08 Mar 2026 08:29:15 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=no autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 1467F1E08D for ; Sun, 08 Mar 2026 08:29:14 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 151FC4BA23CB for ; Sun, 8 Mar 2026 12:29:13 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 151FC4BA23CB Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=vEQMki1+ Received: from omta38.uswest2.a.cloudfilter.net (omta38.uswest2.a.cloudfilter.net [35.89.44.37]) by sourceware.org (Postfix) with ESMTPS id 7AB8C4BA2E1C for ; Sun, 8 Mar 2026 12:28:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7AB8C4BA2E1C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7AB8C4BA2E1C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.37 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1772972924; cv=none; b=GrC1/DdwKJFKAg5uPEabvW7n1MCGqi8KLhAuDSXliXVrS+LyAUrBYwShjFpIna+tNulcz+8tLK42k5DTgGft3Q+LZQty/UXvqCUpKSd2R1bjoqp4jpc6xOzjVxafEEPvz3r1hiB5salgPCZWthOFbJO7tG0py9IA+n0p8ReUscs= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1772972924; c=relaxed/simple; bh=exVSbQtoQ/1E1eq9DDFooBRPM9t2pTZksA4NvcOS/3w=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=njjv2wKa7uGfY+3jeldXKDOfieWlWKCLysuM04tlgiNmsGoDAusm3M245vgPW2qBPrR6xpzIetblBINI2JWn7BYIRtkI6HRvccTYQ5xUokQib+msOYK+yAE3obJFp+CbS3fJPxSR/hyw3geWxQ2rp7SlLDR0JYHL6b30KkwpW1M= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7AB8C4BA2E1C Received: from eig-obgw-6004b.ext.cloudfilter.net ([10.0.30.210]) by cmsmtp with ESMTPS id z4N9vpwk9J9SZzDFTv9hJf; Sun, 08 Mar 2026 12:28:43 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id zDFSvvZaJK8vzzDFSvuHtP; Sun, 08 Mar 2026 12:28:42 +0000 X-Authority-Analysis: v=2.4 cv=cJDgskeN c=1 sm=1 tr=0 ts=69ad6b7b a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=Yq5XynenixoA:10 a=ItBw4LHWJt0A:10 a=4WM9M35uqOTxLz-hiaAA:9 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Transfer-Encoding:MIME-Version:Message-ID:Date:Subject: Cc:To:From:Sender:Reply-To:Content-Type:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=5bVLjCqTAX0FLJc5EeFUA1jP9Q6oHOcil5F1yQo/p7I=; b=vEQMki1+0AkJ0VGmpA9JRGqS/h PRtyvf4LVbnSM3OV0HLKzzCFiA83Qi6iPVoOCtGvb/dEpsWjQnbOilI8uaswD/M5Wk1L5maQB7ZTB HrRYA245AH3ggd/D2Fso2J1Sa; Received: from 75-166-225-82.hlrn.qwest.net ([75.166.225.82]:41250 helo=localhost.localdomain) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vzDFR-00000000rYH-3c3e; Sun, 08 Mar 2026 06:28:41 -0600 From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [PATCH] Remove minimal_symbol_reader::record Date: Sun, 8 Mar 2026 06:28:33 -0600 Message-ID: <20260308122833.640495-1-tom@tromey.com> X-Mailer: git-send-email 2.49.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.225.82 X-Source-L: No X-Exim-ID: 1vzDFR-00000000rYH-3c3e X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-225-82.hlrn.qwest.net (localhost.localdomain) [75.166.225.82]:41250 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfFZj5uF/60iLJuIeR3CxRLndg63LbgkTnBBDdXKByvVI8Tp3lVTUL9W/jkdmShe3+Vy3oza23JN8wAMGOYJ3OCncmZitKb6rXc+tl/arsQN5jpFiAPdh UImD1q6TvJmDb8c194vdDcxRzJsxWpUzPxc6y7LN2iwXWZKN0d8FzfZRymIr/2k6e9EElHCu619Y5dc0XqkNmjqjGevqS81FgaI= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org After the various symbol reader removals, it seems that minimal_symbol_reader::record is no longer needed. --- gdb/minsyms.c | 32 -------------------------------- gdb/minsyms.h | 10 ---------- 2 files changed, 42 deletions(-) diff --git a/gdb/minsyms.c b/gdb/minsyms.c index dff2cb4a045..71cd1bb4c2b 100644 --- a/gdb/minsyms.c +++ b/gdb/minsyms.c @@ -1080,38 +1080,6 @@ minimal_symbol_reader::minimal_symbol_reader (struct objfile *obj) { } -/* See minsyms.h. */ - -void -minimal_symbol_reader::record (const char *name, unrelocated_addr address, - enum minimal_symbol_type ms_type) -{ - int section; - - switch (ms_type) - { - case mst_text: - case mst_text_gnu_ifunc: - case mst_file_text: - case mst_solib_trampoline: - section = SECT_OFF_TEXT (m_objfile); - break; - case mst_data: - case mst_data_gnu_ifunc: - case mst_file_data: - section = SECT_OFF_DATA (m_objfile); - break; - case mst_bss: - case mst_file_bss: - section = SECT_OFF_BSS (m_objfile); - break; - default: - section = -1; - } - - record_with_info (name, address, ms_type, section); -} - /* Convert an enumerator of type minimal_symbol_type to its string representation. */ diff --git a/gdb/minsyms.h b/gdb/minsyms.h index 4eb795ce095..8f38cc7137f 100644 --- a/gdb/minsyms.h +++ b/gdb/minsyms.h @@ -123,16 +123,6 @@ class minimal_symbol_reader enum minimal_symbol_type ms_type, int section); - /* Like record_full, but: - - computes the length of NAME - - passes COPY_NAME = true, - - and passes a default SECTION, depending on the type - - This variant does not return the new symbol. */ - - void record (const char *name, unrelocated_addr address, - enum minimal_symbol_type ms_type); - /* Like record_full, but: - computes the length of NAME - passes COPY_NAME = true. -- 2.49.0