Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* [PATCH RFC 0/2] Remove -readnow
@ 2026-02-11 18:49 Tom Tromey
  2026-02-11 18:49 ` [PATCH RFC 1/2] Remove "readnow" support Tom Tromey
  2026-02-11 18:49 ` [PATCH RFC 2/2] Remove quick_symbol_functions::expand_all_symtabs Tom Tromey
  0 siblings, 2 replies; 10+ messages in thread
From: Tom Tromey @ 2026-02-11 18:49 UTC (permalink / raw)
  To: gdb-patches; +Cc: Tom Tromey

This short series removes the -readnow feature and then some
supporting code.

The justification is all in the first patch.

Regression tested on x86-64 Fedora 40.

Signed-off-by: Tom Tromey <tom@tromey.com>
---
Tom Tromey (2):
      Remove "readnow" support
      Remove quick_symbol_functions::expand_all_symtabs

 gdb/NEWS                                           |   4 +
 gdb/doc/gdb.texinfo                                |  23 +----
 gdb/dwarf2/cooked-index.h                          |   6 --
 gdb/dwarf2/read.c                                  | 101 +--------------------
 gdb/dwarf2/read.h                                  |   4 +-
 gdb/expanded-symbol.h                              |   4 -
 gdb/machoread.c                                    |   2 +-
 gdb/main.c                                         |  24 +----
 gdb/objfile-flags.h                                |  11 +--
 gdb/objfiles.h                                     |   3 -
 gdb/psymtab.c                                      |  10 --
 gdb/psymtab.h                                      |   2 -
 gdb/quick-symbol.h                                 |   3 -
 gdb/symfile-debug.c                                |  11 ---
 gdb/symfile.c                                      |  83 ++++-------------
 gdb/symfile.h                                      |   6 +-
 gdb/symmisc.c                                      |  14 +--
 gdb/testsuite/boards/README                        |   3 +-
 gdb/testsuite/boards/readnow.exp                   |  27 ------
 gdb/testsuite/gdb.ada/call_pn.exp                  |   9 +-
 gdb/testsuite/gdb.ada/data-sections.exp            |   8 +-
 .../gdb.arch/arm-pthread_cond_timedwait-bt.exp     |   4 -
 gdb/testsuite/gdb.base/bfd-errors.exp              |  10 +-
 .../gdb.base/break-on-linker-gcd-function.exp      |   9 --
 gdb/testsuite/gdb.base/c-linkage-name.exp          |  23 ++---
 gdb/testsuite/gdb.base/cached-source-file.exp      |   3 +-
 gdb/testsuite/gdb.base/code_elim.exp               |  15 ---
 gdb/testsuite/gdb.base/include-main.exp            |   6 +-
 gdb/testsuite/gdb.base/index-cache.exp             |   4 +-
 gdb/testsuite/gdb.base/list-ambiguous-readnow.exp  |  22 -----
 gdb/testsuite/gdb.base/main-c.exp                  |   2 -
 .../gdb.base/maint-expand-symbols-header-file.exp  |   4 -
 gdb/testsuite/gdb.base/maint.exp                   |  20 ++--
 gdb/testsuite/gdb.base/readnever.exp               |  25 -----
 gdb/testsuite/gdb.base/relocate.exp                |  27 +++---
 gdb/testsuite/gdb.base/signed-builtin-types.exp    |   5 -
 gdb/testsuite/gdb.base/style.exp                   |  11 +--
 gdb/testsuite/gdb.cp/main-cp.exp                   |   2 -
 gdb/testsuite/gdb.cp/nsalias.exp                   |  12 +--
 gdb/testsuite/gdb.cp/psymtab-parameter.exp         |   6 +-
 gdb/testsuite/gdb.cp/readnow-language.cc           |  22 -----
 gdb/testsuite/gdb.cp/readnow-language.exp          |  27 ------
 .../gdb.debuginfod/build-id-no-debug-warning.exp   |   2 +-
 gdb/testsuite/gdb.debuginfod/crc_mismatch.exp      |   2 +-
 .../gdb.dwarf2/backward-spec-inter-cu.exp          |   1 -
 .../debug-aranges-duplicate-offset-warning.exp     |  19 ++--
 .../gdb.dwarf2/debug-names-missing-cu.exp          |   4 -
 gdb/testsuite/gdb.dwarf2/debug-names-tu.exp.tcl    |   4 -
 .../gdb.dwarf2/dw-form-strx-out-of-bounds.exp      |   4 -
 .../gdb.dwarf2/dw2-bad-parameter-type.exp          |   2 +-
 gdb/testsuite/gdb.dwarf2/dw2-error.exp             |   1 -
 gdb/testsuite/gdb.dwarf2/dw2-icycle.exp            |  11 +--
 gdb/testsuite/gdb.dwarf2/dw2-missing-cu-tag.exp    |  22 +----
 gdb/testsuite/gdb.dwarf2/dw2-modula2-self-type.exp |   2 +-
 gdb/testsuite/gdb.dwarf2/dw2-stack-boundary.exp    |   5 -
 .../gdb.dwarf2/dw2-symtab-includes-lookup.exp      |   6 +-
 gdb/testsuite/gdb.dwarf2/dw2-symtab-includes.exp   |   4 -
 gdb/testsuite/gdb.dwarf2/dw2-using-debug-str.exp   |  15 +--
 gdb/testsuite/gdb.dwarf2/dw2-var-zero-addr.exp     |   9 --
 gdb/testsuite/gdb.dwarf2/dw2-zero-range.exp        |  22 ++---
 gdb/testsuite/gdb.dwarf2/dw4-sig-type-unused.exp   |   7 +-
 gdb/testsuite/gdb.dwarf2/dwznolink.exp             |   6 +-
 gdb/testsuite/gdb.dwarf2/enum-type-c++.exp         |   2 -
 gdb/testsuite/gdb.dwarf2/enum-type.exp             |   1 -
 gdb/testsuite/gdb.dwarf2/forward-spec-inter-cu.exp |   1 -
 gdb/testsuite/gdb.dwarf2/forward-spec.exp          |   2 -
 gdb/testsuite/gdb.dwarf2/gdb-index-nodebug.exp     |   3 +-
 gdb/testsuite/gdb.dwarf2/gdb-index-tilde.exp       |   3 -
 .../gdb.dwarf2/gdb-index-types-dwarf5.exp          |   4 -
 gdb/testsuite/gdb.dwarf2/gdb-index.exp             |   3 -
 gdb/testsuite/gdb.dwarf2/macro-complaints.exp      |   1 -
 gdb/testsuite/gdb.dwarf2/multidictionary.exp       |  10 +-
 gdb/testsuite/gdb.dwarf2/no-expand-mixed-case.exp  |   2 -
 gdb/testsuite/gdb.dwarf2/nostaticblock.exp         |   7 +-
 gdb/testsuite/gdb.dwarf2/per-bfd-sharing.exp       |  11 +--
 gdb/testsuite/gdb.dwarf2/self-spec.exp             |   2 -
 gdb/testsuite/gdb.fortran/info-main.exp            |  14 +--
 gdb/testsuite/gdb.gdb/index-file.exp               |   3 -
 gdb/testsuite/gdb.gdb/python-helper.exp            |   2 +-
 gdb/testsuite/gdb.mi/mi-info-sources.exp           |   6 +-
 gdb/testsuite/gdb.multi/remove-inferiors.exp       |   3 +-
 gdb/testsuite/gdb.opt/break-on-_exit.exp           |   6 --
 gdb/testsuite/gdb.python/py-symbol.exp             |  11 +--
 gdb/testsuite/gdb.server/target-exec-file.exp      |   7 --
 gdb/testsuite/gdb.threads/detach-step-over.exp     |   3 +-
 gdb/testsuite/lib/gdb.exp                          |  21 +----
 gdb/testsuite/lib/mi-support.exp                   |   8 --
 gdb/testsuite/make-check-all.sh                    |   1 -
 88 files changed, 140 insertions(+), 762 deletions(-)
---
base-commit: 0fb67a2cf68660cbda609ba57f1c179dc6373da3
change-id: 20260211-nuke-readnow-f826a37ee233

Best regards,
-- 
Tom Tromey <tom@tromey.com>


^ permalink raw reply	[flat|nested] 10+ messages in thread
* Re: [PATCH RFC 0/2] Remove -readnow
@ 2026-02-11 23:06 Jan Vrany
  2026-02-12  2:31 ` Tom Tromey
  0 siblings, 1 reply; 10+ messages in thread
From: Jan Vrany @ 2026-02-11 23:06 UTC (permalink / raw)
  To: Tom Tromey, GDB Patches

On Wed, 2026-02-11 at 18:49 +0000, Tom Tromey wrote:

> [https://inbox.sourceware.org/gdb-patches/20260211-nuke-readnow-v1-0-7eed7148eec6@tromey.com/](https://inbox.sourceware.org/gdb-patches/20260211-nuke-readnow-v1-0-7eed7148eec6@tromey.com/)
> 
> This short series removes the -readnow feature and then some
> supporting code.
> 
> The justification is all in the first patch.
> 
> Regression tested on x86-64 Fedora 40.
> 

After applying both patches in this series, I get following
when running (for example) "make check TESTS=gdb.base/bfd-errors.exp"


---------
		=== gdb tests ===

Schedule of variations:
    unix

Running target unix
Using /usr/share/dejagnu/baseboards/unix.exp as board description file for target.
Using /usr/share/dejagnu/config/unix.exp as generic interface file for target.
Using /home/jv/Projects/gdb/gdb/testsuite/config/unix.exp as tool-and-target-specific interface file.
Running /home/jv/Projects/gdb/gdb/testsuite/gdb.base/bfd-errors.exp ...
ERROR: tcl error sourcing /home/jv/Projects/gdb/gdb/testsuite/gdb.base/bfd-errors.exp.
ERROR: tcl error code NONE
ERROR: absolute path used
    while executing
"error "absolute path used""
    (procedure "clean_restart" line 28)
    invoked from within
"clean_restart $binfile_lib"
    (file "/home/jv/Projects/gdb/gdb/testsuite/gdb.base/bfd-errors.exp" line 150)
    invoked from within
"source /home/jv/Projects/gdb/gdb/testsuite/gdb.base/bfd-errors.exp"
    ("uplevel" body line 1)
    invoked from within
"uplevel #0 source /home/jv/Projects/gdb/gdb/testsuite/gdb.base/bfd-errors.exp"
    invoked from within
"catch "uplevel #0 source $test_file_name" msg"
PATH: gdb.base/bfd-errors.exp: testcase '/home/jv/Projects/gdb/gdb/testsuite/gdb.base/bfd-errors.exp' aborted due to Tcl error

		=== gdb Summary ===

# of unresolved testcases	1
# of paths in test names	1
---------

I see this is happening for 

  gdb.base/bfd-errors.exp 
  gdb.dwarf2/dw2-icycle.exp 
  gdb.dwarf2/dwznolink.exp
  gdb.dwarf2/multidictionary.exp
  gdb.dwarf2/nostaticblock.exp


In gdb.dwarf2/nostaticblock.exp I also see:

-------
ERROR: -------------------------------------------
ERROR: in testcase /home/jv/Projects/gdb/users_jv_patches/gdb/testsuite/gdb.dwarf2/nostaticblock.exp
ERROR:  can't read "executable": no such variable
ERROR:  tcl error code TCL LOOKUP VARNAME executable
ERROR:  tcl error info:
can't read "executable": no such variable
    while executing
"clean_restart $executable"
    (file "/home/jv/Projects/gdb/users_jv_patches/gdb/testsuite/gdb.dwarf2/nostaticblock.exp" line 41)
    invoked from within
"source /home/jv/Projects/gdb/users_jv_patches/gdb/testsuite/gdb.dwarf2/nostaticblock.exp"
    ("uplevel" body line 1)
    invoked from within
"uplevel #0 source /home/jv/Projects/gdb/users_jv_patches/gdb/testsuite/gdb.dwarf2/nostaticblock.exp"
    invoked from within
"catch "uplevel #0 source $test_file_name" msg"
-------

Running on Debian 13 x86_64. 

Jan


^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2026-02-14 21:27 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-02-11 18:49 [PATCH RFC 0/2] Remove -readnow Tom Tromey
2026-02-11 18:49 ` [PATCH RFC 1/2] Remove "readnow" support Tom Tromey
2026-02-12  7:50   ` Eli Zaretskii
2026-02-12 13:29     ` Andrew Burgess
2026-02-12 16:44       ` Kevin Buettner
2026-02-12 19:39       ` Simon Marchi
2026-02-14 21:26         ` Tom Tromey
2026-02-11 18:49 ` [PATCH RFC 2/2] Remove quick_symbol_functions::expand_all_symtabs Tom Tromey
2026-02-11 23:06 [PATCH RFC 0/2] Remove -readnow Jan Vrany
2026-02-12  2:31 ` Tom Tromey

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox