Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Burgess <aburgess@redhat.com>
To: Eli Zaretskii <eliz@gnu.org>, Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH RFC 1/2] Remove "readnow" support
Date: Thu, 12 Feb 2026 13:29:52 +0000	[thread overview]
Message-ID: <87h5rmay3z.fsf@redhat.com> (raw)
In-Reply-To: <86qzqqtn80.fsf@gnu.org>

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Tom Tromey <tom@tromey.com>
>> Date: Wed, 11 Feb 2026 11:49:09 -0700
>> Cc: Tom Tromey <tom@tromey.com>
>> 
>> I think the "readnow" feature should be removed.
>> 
>> "readnow" exists basically to work around potential bugs in any
>> "partial" reader.  This used to work ok because gdb would scan all the
>> expanded symtabs in addition to using the "quick" functions.  This
>> changed with the "search via psyms" series.
>> 
>> So now, "readnow" is basically its own separate implementation.  As
>> such, I don't think it carries its weight.  It is very slow and uses a
>> lot of memory, and can have its own bugs requiring extra work on our
>> part.
>
> Is there any other way for the user to force GDB to read all of the
> symbols from all of the object files?  If not, perhaps this
> functionality still has its value?  Maybe we should make it a "maint"
> command instead?

I second this.  We do run into bugs with the indexes from time to time,
and it's good to have some way to tell GDB to go read the full debug
information so we can narrow the bug down.  Plus it offers a work around
in these cases.

Is 'maint expand-symtabs' the equivalent?  When someone uses -readnow
should we maybe guide them towards the new way of doing things, even all
we do is point towards a particular entry in the manual maybe?

Thanks,
Andrew


  reply	other threads:[~2026-02-12 13:30 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-11 18:49 [PATCH RFC 0/2] Remove -readnow Tom Tromey
2026-02-11 18:49 ` [PATCH RFC 1/2] Remove "readnow" support Tom Tromey
2026-02-12  7:50   ` Eli Zaretskii
2026-02-12 13:29     ` Andrew Burgess [this message]
2026-02-12 16:44       ` Kevin Buettner
2026-02-12 19:39       ` Simon Marchi
2026-02-14 21:26         ` Tom Tromey
2026-02-11 18:49 ` [PATCH RFC 2/2] Remove quick_symbol_functions::expand_all_symtabs Tom Tromey
2026-02-12 21:32 [PATCH RFC 1/2] Remove "readnow" support Jan Vrany

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h5rmay3z.fsf@redhat.com \
    --to=aburgess@redhat.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox