[PATCH] Add null check for character type name

[PATCH] Add null check for character type name

[Tom Tromey]

The internal AdaCore test suite found that
wchar_printer::get_default_encoding checks the name of a type without
first seeing if the name is null:

  else if (streq (chtype->name (), "wchar_t"))

Mysteriously, though, this only seems to happen for certain targets
and perhaps only under certain conditions (I couldn't reproduce it
msyelf).

I felt that the fix is fairly obvious and that this isn't really worth
writing a test for.  However I can write one using the DWARF assembler
if someone feels it is worthwhile.
---
 gdb/char-print.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gdb/char-print.c b/gdb/char-print.c
index 2d9a43618c9..7efc09af6ef 100644
--- a/gdb/char-print.c
+++ b/gdb/char-print.c
@@ -127,7 +127,7 @@ wchar_printer::get_default_encoding (type *chtype)
   const char *encoding;
   if (chtype->length () == 1)
     encoding = target_charset (chtype->arch ());
-  else if (streq (chtype->name (), "wchar_t"))
+  else if (chtype->name () != nullptr && streq (chtype->name (), "wchar_t"))
     encoding = target_wide_charset (chtype->arch ());
   else if (chtype->length () == 2)
     {

base-commit: 26be9bdb06bbbadf4a9379f19ef56e01b73a3216
-- 
2.52.0

Re: [PATCH] Add null check for character type name

[Keith Seitz]

Hi,

On 2/3/26 12:27 PM, Tom Tromey wrote:
> The internal AdaCore test suite found that
> wchar_printer::get_default_encoding checks the name of a type without
> first seeing if the name is null:
> 
>    else if (streq (chtype->name (), "wchar_t"))
> 
> Mysteriously, though, this only seems to happen for certain targets
> and perhaps only under certain conditions (I couldn't reproduce it
> msyelf).
> 
> I felt that the fix is fairly obvious and that this isn't really worth
> writing a test for.  However I can write one using the DWARF assembler
> if someone feels it is worthwhile.

I don't mind not having a test. IMO, we shouldn't be so super-strict
about needing tests for literally everything -- especially trivial
defensive programming patches like this.

Keith