From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 8rxuKKFhgmnudSYAWB0awg (envelope-from ) for ; Tue, 03 Feb 2026 15:59:13 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=J+cItckJ; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 9831F1E08D; Tue, 03 Feb 2026 15:59:13 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED,RDNS_NONE autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (unknown [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C30C21E08D for ; Tue, 03 Feb 2026 15:59:12 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 3FF184BA2E10 for ; Tue, 3 Feb 2026 20:59:12 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3FF184BA2E10 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=J+cItckJ Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id D86C54BA2E08 for ; Tue, 3 Feb 2026 20:58:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D86C54BA2E08 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D86C54BA2E08 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1770152328; cv=none; b=jyXPq+QHa99f4dshm2pfKw5Q4iyhNQvMZ/Y899T2IiFUd74ihrJq+adaXO9xl+L/4WJ3hnauAH6IJ5iRdnQW1oaaQZI56SXF929RsqA+NcvHa388ntMKZILbi39QcDcCKCo1PNEdUhuiqmRZtylAJse7zClTO1it6a8LOEUrTg4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1770152328; c=relaxed/simple; bh=sboORKqV4Ic2LGc1ikJ2a5mtdggzsC/Y7T6UyAQe+OA=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=W+3PBLeqo0/liEmJjnDD1NWHw9v4RDVQs+ceHpICAPoB9A8DapSrqMggE/ceUJDxqvH1uHzo0BlCJ8RcotrMsz06Ju3wmV22QpBU4hR1Za3hOBG2hu2dUUYZyQDZpkVB2CF7nctX70Uk9FUn1vMASTRu56SsAum7QG8va3X6IFw= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D86C54BA2E08 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1770152327; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=siYwKFfYEn2hC8iQb3+L5wlWLuZCnAiJn3LBkPZvtoQ=; b=J+cItckJEPJeLevzWOJId+EzW2bpqGhujZ5T02e57n8cm6/hNZdhznjdiJTfryD6QzYsJ8 ucQy+/FN/sxNFRufPy6n/rt6z74Z52gcmhhm74MN3B/FmkyA1hW7cANbDUfWUt7VO0JzFk Hq4p+YrOYpdfoDhCBoWyWkpPxevBzxQ= Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-597-vPgvgDubNtiAGFLBxklktQ-1; Tue, 03 Feb 2026 15:58:45 -0500 X-MC-Unique: vPgvgDubNtiAGFLBxklktQ-1 X-Mimecast-MFC-AGG-ID: vPgvgDubNtiAGFLBxklktQ_1770152325 Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-35301003062so14559540a91.2 for ; Tue, 03 Feb 2026 12:58:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770152325; x=1770757125; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=siYwKFfYEn2hC8iQb3+L5wlWLuZCnAiJn3LBkPZvtoQ=; b=ASX5yY8dvIZOY1JuJosz693dGkCZuJxkb7znkeawoYlkARfjaSf5YGcrlaiGPHWGZQ 52lOWLDXqTCPB9HtaR5f4aKAZm9IoPJCGzo30h1vvaiQFcDG3U8zXRQDLXgGUA22P1NX q5/puTnNUJkF7cL3yRINXouzh4YfLd4GHaqUYDBReRoA1OFL+2K973tObxd2FNsnitXz g1hOqu+/T4i4mdHI8rfD6FD5jNEGloQXktHCeZwkgsufDLMcP1OflEOos6Ab2jaTPNhp RoTFES8ztis1BLjgQ3G6S8BCWXwKBmq3lNwQJ3vS3+mNyD7Xuls0/uF9wXNsZksElOXf PUZw== X-Forwarded-Encrypted: i=1; AJvYcCXQPY40qWna2cDdolP1U72fRSoWbbUBZs19ZuCpaLPSA+n82f0YrawE4RT7Lv6jd/ueHlx9/yrHMIwDWA==@sourceware.org X-Gm-Message-State: AOJu0YxmmxTdFKlfOB9/nbA9gH+6MxTk44c5H+9to0RUImL/Q8ivaFwt a7HuJiNnRo2zcRTIncoLKWz9MyRsYQuGHkvufg+fqVhavE3p4rNdoutEmLrit5es+ewqCKAh0J5 z9ie5oeefNGTylbkvprnYcWx0xqy5xE1Z/ZfNQ2k0MnxPP6pP/3rBorfQpDmGN00= X-Gm-Gg: AZuq6aIFGKx9Tmmr8f7cALRd8zrk2hypaWH0finqWrm7RzYp8rbXJLwPxUzjJQ8zS0F XitvOQRXNgCXoiZujMm1xF0hON2prdZ7VqyI+9VpTEmGS9RSDdBJtENwX2Y/3FIwXmeA5/r+hXo VPKw9neMXWyClWf8J9bFQvO+Gwlh9yv4ccbXXnJoESvsl6aW2o4k1GMT3o4utLvRsr2jNbat4FQ VAWk7He3G4eOtzBiJiE5W/WYe46LDx4GbYZiy1Ykm6g6IOeaC9l+00zZf0KLjAX5btSbBqi4vlL /oU3pIwLnBMugklxnUYWRvrWI/oEIIdG/j6GMdm44OVOKQPp+hXElHsoZx/2iaWltMm/+Z2Ik4V cOgUjOEQBfbVW2CSs X-Received: by 2002:a17:90b:48d2:b0:33b:8ac4:1ac4 with SMTP id 98e67ed59e1d1-3548721867fmr460320a91.35.1770152324831; Tue, 03 Feb 2026 12:58:44 -0800 (PST) X-Received: by 2002:a17:90b:48d2:b0:33b:8ac4:1ac4 with SMTP id 98e67ed59e1d1-3548721867fmr460315a91.35.1770152324471; Tue, 03 Feb 2026 12:58:44 -0800 (PST) Received: from [150.1.200.157] ([172.56.105.212]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c6c84c72e48sm183749a12.21.2026.02.03.12.58.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Feb 2026 12:58:44 -0800 (PST) Message-ID: Date: Tue, 3 Feb 2026 12:58:42 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Add null check for character type name To: Tom Tromey , gdb-patches@sourceware.org References: <20260203202727.229977-1-tromey@adacore.com> From: Keith Seitz In-Reply-To: <20260203202727.229977-1-tromey@adacore.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: uePXlhnvPgGK1r3xlytKnOLZHe6r3i4_JwXDOAOeuzQ_1770152325 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Hi, On 2/3/26 12:27 PM, Tom Tromey wrote: > The internal AdaCore test suite found that > wchar_printer::get_default_encoding checks the name of a type without > first seeing if the name is null: > > else if (streq (chtype->name (), "wchar_t")) > > Mysteriously, though, this only seems to happen for certain targets > and perhaps only under certain conditions (I couldn't reproduce it > msyelf). > > I felt that the fix is fairly obvious and that this isn't really worth > writing a test for. However I can write one using the DWARF assembler > if someone feels it is worthwhile. I don't mind not having a test. IMO, we shouldn't be so super-strict about needing tests for literally everything -- especially trivial defensive programming patches like this. Keith