From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id +SP8LUtagmmPbiYAWB0awg (envelope-from ) for ; Tue, 03 Feb 2026 15:27:55 -0500 Authentication-Results: simark.ca; dkim=pass (2048-bit key; secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=VLk2wMiG; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id B806A1E0BA; Tue, 03 Feb 2026 15:27:55 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.6 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED,RDNS_NONE autolearn=no autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (unknown [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id E8DE81E08D for ; Tue, 03 Feb 2026 15:27:54 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 73E674BA2E14 for ; Tue, 3 Feb 2026 20:27:54 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 73E674BA2E14 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=VLk2wMiG Received: from mail-ot1-x336.google.com (mail-ot1-x336.google.com [IPv6:2607:f8b0:4864:20::336]) by sourceware.org (Postfix) with ESMTPS id 375BF4BA543C for ; Tue, 3 Feb 2026 20:27:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 375BF4BA543C Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 375BF4BA543C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::336 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1770150450; cv=none; b=wZtKTzHTv8nPXdfRfOG5uGyhMZ93F24/hvO2ideDHm4xrLT8M4QdiHHo9EMJPRO+9MBgOxo0N9DKTVbrm/6MwpOasThcI57XjQw5Than8HzpM0GU1Vnft3XxwrwJcH+tgrIia0AWiJyRdmyJevJMqefOMK4NzMSU1DY2eb7FsRQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1770150450; c=relaxed/simple; bh=cNxhD+vJK59aaNcaHslzZiPxULNt9tMfvprtDHy5K3Y=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=j8M85+4tHuf6/zyv/lLP/5ayROm1/gATxxp3ryn0QON5PZlrq8oCEPN5Qb76F8JOxpnUrdmwGaMbyVRn3SwnGpWifKMz3He006m8IZR8fX/JbISZUxQPCsTbHU1960JM7haZLP5Rbowm1PApQwGwaEXdxZFOiXDQlFUAq7PVZto= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 375BF4BA543C Received: by mail-ot1-x336.google.com with SMTP id 46e09a7af769-7d44b2df00aso10497a34.3 for ; Tue, 03 Feb 2026 12:27:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1770150449; x=1770755249; darn=sourceware.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=GD7lh3601rWn72cve3o0U1qpp0T9LenhjDFk8NPFW/g=; b=VLk2wMiGb2XBxDYNOciqTg4/8G+7LXIlhrSiLeizfU3EtdXi7+8t2lEVZEy0BKK0YX ojDdaHkTrQY9P7jvr1IuTk5LxcTtae1koWtxxyXL9c66pAiXtJfMZ5Po5KOuC7PNFMXL 5lOnNYX2jZZLB6ObVXluwu5w4zxuP/xiMxzOCGHI8wi6Q8/sV8xNdC6Cz+Mo8fivHGy4 gF4BttUxrPOudAkflstySNcfZHOUflkhUPZ6Y4jDpDDmkGLEPg0jtoigx0qyubvUv8NO rqJI6KNLrjd+wn1M/zswnI8w4CvrZvbyEDQbQ7/rWwJBtKILP+LRHH0OQrj4KLpCksWd A8kA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770150449; x=1770755249; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=GD7lh3601rWn72cve3o0U1qpp0T9LenhjDFk8NPFW/g=; b=Lg22SyjvQni/P+b0l4XXuy0EAjbtYz8P38758VXNCsqQfNgqNXzmXNkUjP7c9XvXY/ upTwR1pSdVuxW8nqs+UtL5Regc1sTFJoX3YY3i1jmAy6vI0MsBTI/HnoaIxTbT4+ZoFH NPD7seB6mETnThX6sR0vxDo4cwpLY/VKKvxN03Uep6tTmfw/SQF5vxOocoiwRr9ixzHY DBCPFr5hrcYK2koluRsPiXMW4lhuaQUOYPmPfHym40Gpr4RGpe0A3kOXR/1WyJM3qbqW rAd3n4PKulE1Lywg2HHumVMqocNVUsrT5c4oZDwHEzyADwu5bLZy0FK8QCTkZ9Aj+fsv qj/w== X-Gm-Message-State: AOJu0YzdOElCWlCq05nA41HEH34fDUhfKi1UcvMXlpYcxxKdsIVzGQBT aZXhEYADYFPmYNs58Qdxf9Q50ASAA32ojYN4S+GUXr+riwPbrHasxXVaabkstlhrFCQb8rJJ5le sKJ4= X-Gm-Gg: AZuq6aIxvk8P5e4weHfVyMcXtYo6zzWtGnKNYHvmGgIwJI3/DjLWgqB1paRu8R0MgNQ mQ1B2zXfSkSxVGQh71qDutY+8tgfmy5HvwjNi9QK2411HmnF5CYxMVNJM2OJeZDaTfm1rgp51yE zrF9MPOgiwr+3sEg+ySfZOS03PAxep3MGtRAyI8i8etM304fInIkThdQls31o4Pw83aszaUi3Ul VQoN3sR8vPVUrZouu/DswksjW6Fl5bn0v4a49u+On1/g7RKIlOi6k8Xs0pi1AKBCvspk+s0itW5 dXRYGApvFIiFmXFA9WZ6zOB3CtnGkuDYWLK4OjZ8NfRXBTMAyzh97UzWtrhdvE6h9VcRxfO84Ig M9GRRk7Rk6fRefC2MZyGA2SCbmu4+qGvkR6OAVfQ2HqkZAqkxPfkAjcpr02OwBh4dt+Q7njfRex 1LjHczZaQIMdvTseYwCW8YKyenqnJeG8o= X-Received: by 2002:a05:6830:6aae:b0:7c7:6063:8e0f with SMTP id 46e09a7af769-7d4489f0fe5mr435425a34.15.1770150449598; Tue, 03 Feb 2026 12:27:29 -0800 (PST) Received: from bapiya (97-118-49-200.hlrn.qwest.net. [97.118.49.200]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7d4490f35b7sm375106a34.1.2026.02.03.12.27.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Feb 2026 12:27:29 -0800 (PST) From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [PATCH] Add null check for character type name Date: Tue, 3 Feb 2026 13:27:27 -0700 Message-ID: <20260203202727.229977-1-tromey@adacore.com> X-Mailer: git-send-email 2.52.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org The internal AdaCore test suite found that wchar_printer::get_default_encoding checks the name of a type without first seeing if the name is null: else if (streq (chtype->name (), "wchar_t")) Mysteriously, though, this only seems to happen for certain targets and perhaps only under certain conditions (I couldn't reproduce it msyelf). I felt that the fix is fairly obvious and that this isn't really worth writing a test for. However I can write one using the DWARF assembler if someone feels it is worthwhile. --- gdb/char-print.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb/char-print.c b/gdb/char-print.c index 2d9a43618c9..7efc09af6ef 100644 --- a/gdb/char-print.c +++ b/gdb/char-print.c @@ -127,7 +127,7 @@ wchar_printer::get_default_encoding (type *chtype) const char *encoding; if (chtype->length () == 1) encoding = target_charset (chtype->arch ()); - else if (streq (chtype->name (), "wchar_t")) + else if (chtype->name () != nullptr && streq (chtype->name (), "wchar_t")) encoding = target_wide_charset (chtype->arch ()); else if (chtype->length () == 2) { base-commit: 26be9bdb06bbbadf4a9379f19ef56e01b73a3216 -- 2.52.0