Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* [PATCH] doc/gdb.texinfo: Add EIO and ENOSYS errno values
@ 2025-10-08 16:34 Yodel Eldar
  2025-10-08 17:25 ` Eli Zaretskii
  0 siblings, 1 reply; 5+ messages in thread
From: Yodel Eldar @ 2025-10-08 16:34 UTC (permalink / raw)
  To: gdb-patches; +Cc: simon.marchi, Yodel Eldar

This patch adds the EIO and ENOSYS errno values supported by GDB's
File-I/O to section E.14.9: Errno Values of the GDB manual [1] that were
presumably inadvertently omitted; both can be seen in the enum
fileio_error:gdbsupport/fileio.h and corresponding function
host_to_fileio_error:gdbsupport/fileio.cc as FILEIO_{EIO,ENOSYS}.

FILEIO_SUCCESS remains excluded from the manual, because its stated
purpose (commit b872057a6) is to internally represent the absence of an
error value from the remote, and it's not actually an error number.

[1] https://sourceware.org/gdb/current/onlinedocs/gdb.html/Errno-Values.html
---

Notes:
    Simon, please let me know if my exclusion of FILEIO_SUCCESS is a mistake;
    I assumed the doc page was geared towards stub authors, and that they
    typically would check the retcode of a file-op function call before
    converting the nonzero errno to GDB's internal protocol representation
    of the error value as listed in the manual, but perhaps that's too
    myopic; if so, I can resubmit with a "SUCCESS = 0" line added. As the
    originator of the enum and member, I defer to your judgment.
    
    As a side note, I sent this email with my preferred email address that
    is different from my previously used email address,
    yodel.eldar(at)gmail.com. As attestation, I signed this email
    with patatt and the same GPG key as before.
    
    Thanks,
    Yodel

 gdb/doc/gdb.texinfo | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
index a13d5c0388e..5b06d3dbcf8 100644
--- a/gdb/doc/gdb.texinfo
+++ b/gdb/doc/gdb.texinfo
@@ -48348,6 +48348,7 @@ All values are given in decimal representation.
   EPERM           1
   ENOENT          2
   EINTR           4
+  EIO             5
   EBADF           9
   EACCES         13
   EFAULT         14
@@ -48363,6 +48364,7 @@ All values are given in decimal representation.
   ENOSPC         28
   ESPIPE         29
   EROFS          30
+  ENOSYS         88
   ENAMETOOLONG   91
   EUNKNOWN       9999
 @end smallexample
-- 
2.51.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] doc/gdb.texinfo: Add EIO and ENOSYS errno values
  2025-10-08 16:34 [PATCH] doc/gdb.texinfo: Add EIO and ENOSYS errno values Yodel Eldar
@ 2025-10-08 17:25 ` Eli Zaretskii
  2025-10-08 22:09   ` Simon Marchi
  0 siblings, 1 reply; 5+ messages in thread
From: Eli Zaretskii @ 2025-10-08 17:25 UTC (permalink / raw)
  To: Yodel Eldar; +Cc: gdb-patches, simon.marchi

> From: Yodel Eldar <yodel.eldar@yodel.dev>
> Cc: simon.marchi@polymtl.ca,
> 	Yodel Eldar <yodel.eldar@yodel.dev>
> Date: Wed,  8 Oct 2025 11:34:55 -0500
> 
> This patch adds the EIO and ENOSYS errno values supported by GDB's
> File-I/O to section E.14.9: Errno Values of the GDB manual [1] that were
> presumably inadvertently omitted; both can be seen in the enum
> fileio_error:gdbsupport/fileio.h and corresponding function
> host_to_fileio_error:gdbsupport/fileio.cc as FILEIO_{EIO,ENOSYS}.
> 
> FILEIO_SUCCESS remains excluded from the manual, because its stated
> purpose (commit b872057a6) is to internally represent the absence of an
> error value from the remote, and it's not actually an error number.
> 
> [1] https://sourceware.org/gdb/current/onlinedocs/gdb.html/Errno-Values.html
> ---
> 
> Notes:
>     Simon, please let me know if my exclusion of FILEIO_SUCCESS is a mistake;
>     I assumed the doc page was geared towards stub authors, and that they
>     typically would check the retcode of a file-op function call before
>     converting the nonzero errno to GDB's internal protocol representation
>     of the error value as listed in the manual, but perhaps that's too
>     myopic; if so, I can resubmit with a "SUCCESS = 0" line added. As the
>     originator of the enum and member, I defer to your judgment.
>     
>     As a side note, I sent this email with my preferred email address that
>     is different from my previously used email address,
>     yodel.eldar(at)gmail.com. As attestation, I signed this email
>     with patatt and the same GPG key as before.
>     
>     Thanks,
>     Yodel
> 
>  gdb/doc/gdb.texinfo | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
> index a13d5c0388e..5b06d3dbcf8 100644
> --- a/gdb/doc/gdb.texinfo
> +++ b/gdb/doc/gdb.texinfo
> @@ -48348,6 +48348,7 @@ All values are given in decimal representation.
>    EPERM           1
>    ENOENT          2
>    EINTR           4
> +  EIO             5
>    EBADF           9
>    EACCES         13
>    EFAULT         14
> @@ -48363,6 +48364,7 @@ All values are given in decimal representation.
>    ENOSPC         28
>    ESPIPE         29
>    EROFS          30
> +  ENOSYS         88
>    ENAMETOOLONG   91
>    EUNKNOWN       9999
>  @end smallexample

Thanks, the patch for the manual is fine by me (assuming the
documentation of these errno values is okay, on which I have no
opinion).

Reviewed-By: Eli Zaretskii <eliz@gnu.org>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] doc/gdb.texinfo: Add EIO and ENOSYS errno values
  2025-10-08 17:25 ` Eli Zaretskii
@ 2025-10-08 22:09   ` Simon Marchi
  2025-10-09 15:21     ` Yodel Eldar
  0 siblings, 1 reply; 5+ messages in thread
From: Simon Marchi @ 2025-10-08 22:09 UTC (permalink / raw)
  To: Eli Zaretskii, Yodel Eldar; +Cc: gdb-patches

On 10/8/25 1:25 PM, Eli Zaretskii wrote:
>> From: Yodel Eldar <yodel.eldar@yodel.dev>
>> Cc: simon.marchi@polymtl.ca,
>> 	Yodel Eldar <yodel.eldar@yodel.dev>
>> Date: Wed,  8 Oct 2025 11:34:55 -0500
>>
>> This patch adds the EIO and ENOSYS errno values supported by GDB's
>> File-I/O to section E.14.9: Errno Values of the GDB manual [1] that were
>> presumably inadvertently omitted; both can be seen in the enum
>> fileio_error:gdbsupport/fileio.h and corresponding function
>> host_to_fileio_error:gdbsupport/fileio.cc as FILEIO_{EIO,ENOSYS}.
>>
>> FILEIO_SUCCESS remains excluded from the manual, because its stated
>> purpose (commit b872057a6) is to internally represent the absence of an
>> error value from the remote, and it's not actually an error number.
>>
>> [1] https://sourceware.org/gdb/current/onlinedocs/gdb.html/Errno-Values.html
>> ---
>>
>> Notes:
>>     Simon, please let me know if my exclusion of FILEIO_SUCCESS is a mistake;
>>     I assumed the doc page was geared towards stub authors, and that they
>>     typically would check the retcode of a file-op function call before
>>     converting the nonzero errno to GDB's internal protocol representation
>>     of the error value as listed in the manual, but perhaps that's too
>>     myopic; if so, I can resubmit with a "SUCCESS = 0" line added. As the
>>     originator of the enum and member, I defer to your judgment.
>>     
>>     As a side note, I sent this email with my preferred email address that
>>     is different from my previously used email address,
>>     yodel.eldar(at)gmail.com. As attestation, I signed this email
>>     with patatt and the same GPG key as before.
>>     
>>     Thanks,
>>     Yodel
>>
>>  gdb/doc/gdb.texinfo | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
>> index a13d5c0388e..5b06d3dbcf8 100644
>> --- a/gdb/doc/gdb.texinfo
>> +++ b/gdb/doc/gdb.texinfo
>> @@ -48348,6 +48348,7 @@ All values are given in decimal representation.
>>    EPERM           1
>>    ENOENT          2
>>    EINTR           4
>> +  EIO             5
>>    EBADF           9
>>    EACCES         13
>>    EFAULT         14
>> @@ -48363,6 +48364,7 @@ All values are given in decimal representation.
>>    ENOSPC         28
>>    ESPIPE         29
>>    EROFS          30
>> +  ENOSYS         88
>>    ENAMETOOLONG   91
>>    EUNKNOWN       9999
>>  @end smallexample
> 
> Thanks, the patch for the manual is fine by me (assuming the
> documentation of these errno values is okay, on which I have no
> opinion).
> 
> Reviewed-By: Eli Zaretskii <eliz@gnu.org>

I'm not an expert in that area, but I think it's obvious enough that
these lists should be synced.

Approved-By: Simon Marchi <simon.marchi@efficios.com>

Simon

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] doc/gdb.texinfo: Add EIO and ENOSYS errno values
  2025-10-08 22:09   ` Simon Marchi
@ 2025-10-09 15:21     ` Yodel Eldar
  2025-10-09 15:28       ` Simon Marchi
  0 siblings, 1 reply; 5+ messages in thread
From: Yodel Eldar @ 2025-10-09 15:21 UTC (permalink / raw)
  To: Simon Marchi, Eli Zaretskii; +Cc: gdb-patches



On 10/8/25 5:09 PM, Simon Marchi wrote:
> On 10/8/25 1:25 PM, Eli Zaretskii wrote:
>>> From: Yodel Eldar <yodel.eldar@yodel.dev>
>>> Cc: simon.marchi@polymtl.ca,
>>> 	Yodel Eldar <yodel.eldar@yodel.dev>
>>> Date: Wed,  8 Oct 2025 11:34:55 -0500
>>>
>>> This patch adds the EIO and ENOSYS errno values supported by GDB's
>>> File-I/O to section E.14.9: Errno Values of the GDB manual [1] that were
>>> presumably inadvertently omitted; both can be seen in the enum
>>> fileio_error:gdbsupport/fileio.h and corresponding function
>>> host_to_fileio_error:gdbsupport/fileio.cc as FILEIO_{EIO,ENOSYS}.
>>>
>>> FILEIO_SUCCESS remains excluded from the manual, because its stated
>>> purpose (commit b872057a6) is to internally represent the absence of an
>>> error value from the remote, and it's not actually an error number.
>>>
>>> [1] https://sourceware.org/gdb/current/onlinedocs/gdb.html/Errno-Values.html
>>> ---
>>>
>>> Notes:
>>>      Simon, please let me know if my exclusion of FILEIO_SUCCESS is a mistake;
>>>      I assumed the doc page was geared towards stub authors, and that they
>>>      typically would check the retcode of a file-op function call before
>>>      converting the nonzero errno to GDB's internal protocol representation
>>>      of the error value as listed in the manual, but perhaps that's too
>>>      myopic; if so, I can resubmit with a "SUCCESS = 0" line added. As the
>>>      originator of the enum and member, I defer to your judgment.
>>>      
>>>      As a side note, I sent this email with my preferred email address that
>>>      is different from my previously used email address,
>>>      yodel.eldar(at)gmail.com. As attestation, I signed this email
>>>      with patatt and the same GPG key as before.
>>>      
>>>      Thanks,
>>>      Yodel
>>>
>>>   gdb/doc/gdb.texinfo | 2 ++
>>>   1 file changed, 2 insertions(+)
>>>
>>> diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
>>> index a13d5c0388e..5b06d3dbcf8 100644
>>> --- a/gdb/doc/gdb.texinfo
>>> +++ b/gdb/doc/gdb.texinfo
>>> @@ -48348,6 +48348,7 @@ All values are given in decimal representation.
>>>     EPERM           1
>>>     ENOENT          2
>>>     EINTR           4
>>> +  EIO             5
>>>     EBADF           9
>>>     EACCES         13
>>>     EFAULT         14
>>> @@ -48363,6 +48364,7 @@ All values are given in decimal representation.
>>>     ENOSPC         28
>>>     ESPIPE         29
>>>     EROFS          30
>>> +  ENOSYS         88
>>>     ENAMETOOLONG   91
>>>     EUNKNOWN       9999
>>>   @end smallexample
>>
>> Thanks, the patch for the manual is fine by me (assuming the
>> documentation of these errno values is okay, on which I have no
>> opinion).
>>
>> Reviewed-By: Eli Zaretskii <eliz@gnu.org>
> 
> I'm not an expert in that area, but I think it's obvious enough that
> these lists should be synced.
> 
> Approved-By: Simon Marchi <simon.marchi@efficios.com>
> 
> Simon

Thank you both for the review and approval!

Simon, would you mind pushing the patch on my behalf? I don't have write 
access to the repo.

Yodel

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] doc/gdb.texinfo: Add EIO and ENOSYS errno values
  2025-10-09 15:21     ` Yodel Eldar
@ 2025-10-09 15:28       ` Simon Marchi
  0 siblings, 0 replies; 5+ messages in thread
From: Simon Marchi @ 2025-10-09 15:28 UTC (permalink / raw)
  To: Yodel Eldar, Eli Zaretskii; +Cc: gdb-patches

On 10/9/25 11:21 AM, Yodel Eldar wrote:
> Thank you both for the review and approval!
> 
> Simon, would you mind pushing the patch on my behalf? I don't have write access to the repo.
> 
> Yodel

Done, thanks!

Simon

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2025-10-09 15:29 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-10-08 16:34 [PATCH] doc/gdb.texinfo: Add EIO and ENOSYS errno values Yodel Eldar
2025-10-08 17:25 ` Eli Zaretskii
2025-10-08 22:09   ` Simon Marchi
2025-10-09 15:21     ` Yodel Eldar
2025-10-09 15:28       ` Simon Marchi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox