From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id CSL0LA3T52gnwCUAWB0awg (envelope-from ) for ; Thu, 09 Oct 2025 11:21:49 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=mail.yodel.dev header.i=@mail.yodel.dev header.a=rsa-sha256 header.s=pdk1 header.b=MmjGjB26; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id B45A11E0B6; Thu, 09 Oct 2025 11:21:49 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.3 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 3FAFD1E047 for ; Thu, 09 Oct 2025 11:21:49 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E26D93858416 for ; Thu, 9 Oct 2025 15:21:48 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E26D93858416 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=mail.yodel.dev header.i=@mail.yodel.dev header.a=rsa-sha256 header.s=pdk1 header.b=MmjGjB26 Received: from m228-5.mailgun.net (m228-5.mailgun.net [159.135.228.5]) by sourceware.org (Postfix) with UTF8SMTPS id AFC033858431 for ; Thu, 9 Oct 2025 15:21:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AFC033858431 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=yodel.dev Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mail.yodel.dev ARC-Filter: OpenARC Filter v1.0.0 sourceware.org AFC033858431 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=159.135.228.5 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1760023272; cv=none; b=TwrEUCWGBRQreJSagBZsCORUAYTHBn/Uxtzj9KANGQU6a6fiTO1R8E8n9Vy2XnhcpujM3GdHIB0EznoS9WvdS8JTSEEAOlOhX3KQ/HolezmSkEiNk5pUiVkq2GSA7fdfhypjwB0w6zRA3V68K2aHjNtJ8PxOT8Mp+TDDfuEQ4PA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1760023272; c=relaxed/simple; bh=WtAZono0CgzJc/TbtG8fmze4E5Tx4V0ujUvOdEqNFl0=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=l0URi/OMx8UqNOxPszGmQ2cLEY6sFEgEtFA7qaa4MAPYFFvb7retpOxY3o4unR6eOzngkkTw/m7BuzR/N5Gs3QcmOqIwV3ko1SUD9Zv9Rc6MGvEiOhH2Ve2Q4nMnknoJCsOZYk/yXKdViS76WyKFnnK4mdwhPmcYBsayFpTR39k= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org AFC033858431 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mail.yodel.dev; q=dns/txt; s=pdk1; t=1760023270; x=1760030470; h=Content-Transfer-Encoding: Content-Type: In-Reply-To: From: From: References: Cc: To: To: Subject: Subject: MIME-Version: Date: Message-ID: Sender: Sender; bh=p6l0tPrms5HBDVzFQSJtx04A7N6kb67JRV+zx+Pnqh8=; b=MmjGjB267G/OV/tNbEoqHqN7f8j4CHrbuXYitVWRbu291acayv4icmQN6SqcCP1ZCIwedWpRiGQSGrCCvtNo5i+cVtf9lZegIeQdzKjO62r4ua2y6OGmkV8exu61IosoAg744mz6TFMR2Du39SVJyfOQESQ8Fw/XBvFDSRRRdHDpA8Jcu31SrzOYuNaCWK4vlwI8Oonx85SSXCnlb9UEuHxzNBPI1W75uBb7ezEBlLO9EDCOrUMfdLjz/Wnh2Q46G8jTxQZn0Ffe/vn65CSLUoeWp3FaVq+PnGjZuwAPIamVDgR5k28nKWGcuyU5iCbsWW/ror9+ALlyaH2ucfFJnw== X-Mailgun-Sid: WyIxOWVlZiIsImdkYi1wYXRjaGVzQHNvdXJjZXdhcmUub3JnIiwiMzNlOTIwIl0= Received: from mail.yodel.dev (mail.yodel.dev [35.209.39.246]) by 43515f988aa178d6750c4a973567cdf68fb235ccec59e48b81ae9e0708c2b128 with SMTP id 68e7d2e652b3c843226a83a8; Thu, 09 Oct 2025 15:21:10 GMT X-Mailgun-Sending-Ip: 159.135.228.5 Sender: yodel.eldar=yodel.dev@mail.yodel.dev Message-ID: <175f9748-1d77-4a98-a2a4-ecf98e40a2c5@yodel.dev> Date: Thu, 9 Oct 2025 10:21:09 -0500 MIME-Version: 1.0 Subject: Re: [PATCH] doc/gdb.texinfo: Add EIO and ENOSYS errno values To: Simon Marchi , Eli Zaretskii Cc: gdb-patches@sourceware.org References: <20251008163455.31446-1-yodel.eldar@yodel.dev> <861pndb90s.fsf@gnu.org> Content-Language: en-US From: Yodel Eldar Autocrypt: addr=yodel.eldar@yodel.dev; keydata= xjMEZxqXdhYJKwYBBAHaRw8BAQdAkletQdG3CLyANZyuf2t7Z9PK4b6HiT+DdSPUB2mHzmPN I1lvZGVsIEVsZGFyIDx5b2RlbC5lbGRhckB5b2RlbC5kZXY+wpkEExYKAEECGwMFCQOcG00F CwkIBwIGFQoJCAsCBBYCAwECHgECF4AWIQTTzRjNQG27imap+N+V7k+3NmVNrAUCaNWASwIZ AQAKCRCV7k+3NmVNrNnSAPoDjQXa6v7ZzdQSaLdRfAQy/5SsUucv+zp3WAP4pXdgJQEAzMMC Ctx4l6b13Fs2hZdRXEnF/4BZ9t1K68nwzZOV3QnOOARnGpd2EgorBgEEAZdVAQUBAQdAKPIy 3W/DKFsm1e+31zoqmOY0pqz8vjIM846wM6lEY2QDAQgHwn4EGBYIACYCGwwWIQTTzRjNQG27 imap+N+V7k+3NmVNrAUCaNWG7QUJA5wi9wAKCRCV7k+3NmVNrPusAQCQDQwETy7VT6UhHPho TkrQnsNqQfFU3tXqCTiViToktQD7B/U2/to97hQIJCWbK6yd3T+KPZJPMcHMg2XRyedUvgA= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 10/8/25 5:09 PM, Simon Marchi wrote: > On 10/8/25 1:25 PM, Eli Zaretskii wrote: >>> From: Yodel Eldar >>> Cc: simon.marchi@polymtl.ca, >>> Yodel Eldar >>> Date: Wed, 8 Oct 2025 11:34:55 -0500 >>> >>> This patch adds the EIO and ENOSYS errno values supported by GDB's >>> File-I/O to section E.14.9: Errno Values of the GDB manual [1] that were >>> presumably inadvertently omitted; both can be seen in the enum >>> fileio_error:gdbsupport/fileio.h and corresponding function >>> host_to_fileio_error:gdbsupport/fileio.cc as FILEIO_{EIO,ENOSYS}. >>> >>> FILEIO_SUCCESS remains excluded from the manual, because its stated >>> purpose (commit b872057a6) is to internally represent the absence of an >>> error value from the remote, and it's not actually an error number. >>> >>> [1] https://sourceware.org/gdb/current/onlinedocs/gdb.html/Errno-Values.html >>> --- >>> >>> Notes: >>> Simon, please let me know if my exclusion of FILEIO_SUCCESS is a mistake; >>> I assumed the doc page was geared towards stub authors, and that they >>> typically would check the retcode of a file-op function call before >>> converting the nonzero errno to GDB's internal protocol representation >>> of the error value as listed in the manual, but perhaps that's too >>> myopic; if so, I can resubmit with a "SUCCESS = 0" line added. As the >>> originator of the enum and member, I defer to your judgment. >>> >>> As a side note, I sent this email with my preferred email address that >>> is different from my previously used email address, >>> yodel.eldar(at)gmail.com. As attestation, I signed this email >>> with patatt and the same GPG key as before. >>> >>> Thanks, >>> Yodel >>> >>> gdb/doc/gdb.texinfo | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo >>> index a13d5c0388e..5b06d3dbcf8 100644 >>> --- a/gdb/doc/gdb.texinfo >>> +++ b/gdb/doc/gdb.texinfo >>> @@ -48348,6 +48348,7 @@ All values are given in decimal representation. >>> EPERM 1 >>> ENOENT 2 >>> EINTR 4 >>> + EIO 5 >>> EBADF 9 >>> EACCES 13 >>> EFAULT 14 >>> @@ -48363,6 +48364,7 @@ All values are given in decimal representation. >>> ENOSPC 28 >>> ESPIPE 29 >>> EROFS 30 >>> + ENOSYS 88 >>> ENAMETOOLONG 91 >>> EUNKNOWN 9999 >>> @end smallexample >> >> Thanks, the patch for the manual is fine by me (assuming the >> documentation of these errno values is okay, on which I have no >> opinion). >> >> Reviewed-By: Eli Zaretskii > > I'm not an expert in that area, but I think it's obvious enough that > these lists should be synced. > > Approved-By: Simon Marchi > > Simon Thank you both for the review and approval! Simon, would you mind pushing the patch on my behalf? I don't have write access to the repo. Yodel