From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id K//iB0vh5mg3niQAWB0awg (envelope-from ) for ; Wed, 08 Oct 2025 18:10:19 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=oct2025 header.b=Cz5j8eU7; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 125571E04C; Wed, 08 Oct 2025 18:10:19 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 4C0131E04C for ; Wed, 08 Oct 2025 18:10:18 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A48AB3858D2A for ; Wed, 8 Oct 2025 22:10:17 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A48AB3858D2A Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=oct2025 header.b=Cz5j8eU7 Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 552513858D1E for ; Wed, 8 Oct 2025 22:09:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 552513858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=polymtl.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=polymtl.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 552513858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=132.207.4.11 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1759961382; cv=none; b=luZUbE3Y/Qu68ZnNB+Igmi+QkSAXnfGHTpjr4YuhAlTlOIGeHk1W0KGl8nBu9Jf+qk+ydy6bqPAzGQGWrSqeQMYmE1C3oZkX0sgC0sMPbcMdMMykpsn1qQBfzoFngpckenX+fO1zCIDe/nG62dZp0nZ6IIG0W+sukfMn2nsAvKc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1759961382; c=relaxed/simple; bh=fhgd2NxhmU1UxknWxIbtPW6137buPx+lnD0vDSt7X7U=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=AIqOL/uFSOya93NGapVxvCA1kyL/jqYO8mSyoAcHLdLfrTBAHocUodrk4P9CWew5Xy1493eYE9Hf236qmGEc2GzzJNe2Qh3QcWRhiGxL6UBk8OxK5aeZ5Z3/Pn8mfaWxKT9W0JOCgtqvFMC0tsuKc22f+L1qMoJmu+m/hB9DaWM= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 552513858D1E Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 598M9412119845 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 8 Oct 2025 18:09:09 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 598M9412119845 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=oct2025; t=1759961349; bh=ZRMaQhPIH03vvZHj9uNSjH94PQA5HvUZqWVtFK0dHq8=; h=Date:Subject:To:Cc:From:In-Reply-To:From; b=Cz5j8eU7ZoOkB2Tc/53YhMoxKSmkBO3asktGUxScsn6J0iM1skf+z/DsEzMMZAe6k 5DpPDmQLBKvKoG2ovp3/zgpqwSSVnzUMnF9Fu4Lm796PXo/WVbKwRKt/9W4IH38OcT 8VX5hE4q7Eb82uWqbKX8TsqjoD6dEhWjN7wrfd42Vkg0VaDylOhL8MXlQ7wEoO56fq 3ADcc7PEbYF5C214Me++JbH1clamQOXSpuugQKZuU/jioZYEL9hr4VHaVKG0mciOdC Ndl/QbJ47Up4REuIIvTxo35HuFmWXkppLrHMdULNDIVo/Nk2Irx4y0YAwMjYcLv1P9 2xGo0aaJ64Ojg== Received: by simark.ca (Postfix) id 4B41E1E04C; Wed, 08 Oct 2025 18:09:04 -0400 (EDT) Message-ID: Date: Wed, 8 Oct 2025 18:09:03 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] doc/gdb.texinfo: Add EIO and ENOSYS errno values To: Eli Zaretskii , Yodel Eldar Cc: gdb-patches@sourceware.org References: <20251008163455.31446-1-yodel.eldar@yodel.dev> <861pndb90s.fsf@gnu.org> Content-Language: fr From: Simon Marchi In-Reply-To: <861pndb90s.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Wed, 8 Oct 2025 22:09:04 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 10/8/25 1:25 PM, Eli Zaretskii wrote: >> From: Yodel Eldar >> Cc: simon.marchi@polymtl.ca, >> Yodel Eldar >> Date: Wed, 8 Oct 2025 11:34:55 -0500 >> >> This patch adds the EIO and ENOSYS errno values supported by GDB's >> File-I/O to section E.14.9: Errno Values of the GDB manual [1] that were >> presumably inadvertently omitted; both can be seen in the enum >> fileio_error:gdbsupport/fileio.h and corresponding function >> host_to_fileio_error:gdbsupport/fileio.cc as FILEIO_{EIO,ENOSYS}. >> >> FILEIO_SUCCESS remains excluded from the manual, because its stated >> purpose (commit b872057a6) is to internally represent the absence of an >> error value from the remote, and it's not actually an error number. >> >> [1] https://sourceware.org/gdb/current/onlinedocs/gdb.html/Errno-Values.html >> --- >> >> Notes: >> Simon, please let me know if my exclusion of FILEIO_SUCCESS is a mistake; >> I assumed the doc page was geared towards stub authors, and that they >> typically would check the retcode of a file-op function call before >> converting the nonzero errno to GDB's internal protocol representation >> of the error value as listed in the manual, but perhaps that's too >> myopic; if so, I can resubmit with a "SUCCESS = 0" line added. As the >> originator of the enum and member, I defer to your judgment. >> >> As a side note, I sent this email with my preferred email address that >> is different from my previously used email address, >> yodel.eldar(at)gmail.com. As attestation, I signed this email >> with patatt and the same GPG key as before. >> >> Thanks, >> Yodel >> >> gdb/doc/gdb.texinfo | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo >> index a13d5c0388e..5b06d3dbcf8 100644 >> --- a/gdb/doc/gdb.texinfo >> +++ b/gdb/doc/gdb.texinfo >> @@ -48348,6 +48348,7 @@ All values are given in decimal representation. >> EPERM 1 >> ENOENT 2 >> EINTR 4 >> + EIO 5 >> EBADF 9 >> EACCES 13 >> EFAULT 14 >> @@ -48363,6 +48364,7 @@ All values are given in decimal representation. >> ENOSPC 28 >> ESPIPE 29 >> EROFS 30 >> + ENOSYS 88 >> ENAMETOOLONG 91 >> EUNKNOWN 9999 >> @end smallexample > > Thanks, the patch for the manual is fine by me (assuming the > documentation of these errno values is okay, on which I have no > opinion). > > Reviewed-By: Eli Zaretskii I'm not an expert in that area, but I think it's obvious enough that these lists should be synced. Approved-By: Simon Marchi Simon