From: Kevin Buettner <kevinb@redhat.com>
To: Guinevere Larsen <guinevere@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb: Introduce user-friendly namespace identifier for "info shared"
Date: Fri, 14 Mar 2025 20:11:12 -0700 [thread overview]
Message-ID: <20250314201112.29c30ab8@f41-zbm-amd> (raw)
In-Reply-To: <20250314195108.2c4891a9@f41-zbm-amd>
On Fri, 14 Mar 2025 19:51:08 -0700
Kevin Buettner <kevinb@redhat.com> wrote:
> On Thu, 13 Mar 2025 14:00:05 -0300
> Guinevere Larsen <guinevere@redhat.com> wrote:
>
> > Finally, a new solib_ops function pointer was added, find_solib_ns, to
> > allow code outside of solib-svr4 to find and use the namespace
> > identifiers. As a sanity check, the command `info sharedlibraries` has
> > been changed to display the namespace identifier. Plus, a couple of tests
> > had to be tweaked to handle the possible new column.
>
> I applied the patch, built GDB, and ran the tests. But I didn't
> see the new NS column in any of the "info shared"/"info sharedlibrary"
> output. Should I have seen this column? (I.e, did I do something
> wrong?) Assuming that I didn't mess up, I think it'd be good to add
> some tests which show the new column.
So... I screwed up when attempting to resolve the "git am" problem.
I guess I need to figure out how to correctly use "git am --continue".
I now see the NS column in the "info shared" output. But, now, I *always*
see it in the "info shared" output, even when there's only one linker
namespace. Is that desirable?
My opinion is that we should suppress the NS column when there's
only one linker namespace.
Kevin
next prev parent reply other threads:[~2025-03-15 3:11 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-13 17:00 Guinevere Larsen
2025-03-13 19:19 ` Eli Zaretskii
2025-03-13 19:27 ` Guinevere Larsen
2025-03-15 2:51 ` Kevin Buettner
2025-03-15 3:11 ` Kevin Buettner [this message]
2025-03-17 11:55 ` Guinevere Larsen
2025-03-17 15:36 ` Simon Marchi
2025-03-18 1:07 ` Kevin Buettner
2025-03-17 15:36 ` Simon Marchi
2025-03-17 17:07 ` Guinevere Larsen
2025-03-17 17:54 ` Simon Marchi
2025-03-19 12:30 ` [PATCH v2] " Guinevere Larsen
2025-03-21 17:55 ` Guinevere Larsen
2025-03-27 17:13 ` [PATCH v3] " Guinevere Larsen
2025-03-31 19:34 ` Guinevere Larsen
2025-04-05 20:17 ` Kevin Buettner
2025-04-07 13:07 ` Guinevere Larsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250314201112.29c30ab8@f41-zbm-amd \
--to=kevinb@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=guinevere@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox