From: Eli Zaretskii <eliz@gnu.org>
To: Guinevere Larsen <guinevere@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb: Introduce user-friendly namespace identifier for "info shared"
Date: Thu, 13 Mar 2025 21:19:31 +0200 [thread overview]
Message-ID: <86msdo20xo.fsf@gnu.org> (raw)
In-Reply-To: <20250313170004.3362207-2-guinevere@redhat.com> (message from Guinevere Larsen on Thu, 13 Mar 2025 14:00:05 -0300)
> From: Guinevere Larsen <guinevere@redhat.com>
> Cc: Guinevere Larsen <guinevere@redhat.com>
> Date: Thu, 13 Mar 2025 14:00:05 -0300
>
> gdb/NEWS | 4 +
> gdb/doc/gdb.texinfo | 4 +
> gdb/solib-svr4.c | 118 +++++++++++++++++--
> gdb/solib.c | 23 +++-
> gdb/solist.h | 11 ++
> gdb/testsuite/gdb.base/attach-pie-noexec.exp | 4 +-
> gdb/testsuite/gdb.base/dlmopen.exp | 6 +-
> gdb/testsuite/gdb.mi/mi-dlmopen.exp | 6 +-
> 8 files changed, 160 insertions(+), 16 deletions(-)
Thanks.
> diff --git a/gdb/NEWS b/gdb/NEWS
> index f5dbf5c3350..67794f4497c 100644
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -26,6 +26,10 @@
>
> * Linux checkpoint code has been updated to work with multiple inferiors.
>
> +* In systems that support linkage namespaces, the output of the command
^^^^^^^^^^
"On systems"
> +In systems that support linkage namespaces, the column @code{NS} is
> +added to the output.
Same here, and in addition this sentence uses passive voice, so I'd
rephrase
On systems that support linkage namespaces, the output includes an
additional column @code{NS}.
The documentation parts are okay with these nits fixed.
Reviewed-By: Eli Zaretskii <eliz@gnu.org>
next prev parent reply other threads:[~2025-03-13 19:20 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-13 17:00 Guinevere Larsen
2025-03-13 19:19 ` Eli Zaretskii [this message]
2025-03-13 19:27 ` Guinevere Larsen
2025-03-15 2:51 ` Kevin Buettner
2025-03-15 3:11 ` Kevin Buettner
2025-03-17 11:55 ` Guinevere Larsen
2025-03-17 15:36 ` Simon Marchi
2025-03-18 1:07 ` Kevin Buettner
2025-03-17 15:36 ` Simon Marchi
2025-03-17 17:07 ` Guinevere Larsen
2025-03-17 17:54 ` Simon Marchi
2025-03-19 12:30 ` [PATCH v2] " Guinevere Larsen
2025-03-21 17:55 ` Guinevere Larsen
2025-03-27 17:13 ` [PATCH v3] " Guinevere Larsen
2025-03-31 19:34 ` Guinevere Larsen
2025-04-05 20:17 ` Kevin Buettner
2025-04-07 13:07 ` Guinevere Larsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86msdo20xo.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=guinevere@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox