Re: [PATCH] gdb: Introduce user-friendly namespace identifier for "info shared"

[Guinevere Larsen <guinevere@redhat.com>]

On 3/13/25 4:19 PM, Eli Zaretskii wrote:
>> From: Guinevere Larsen <guinevere@redhat.com>
>> Cc: Guinevere Larsen <guinevere@redhat.com>
>> Date: Thu, 13 Mar 2025 14:00:05 -0300
>>
>>   gdb/NEWS                                     |   4 +
>>   gdb/doc/gdb.texinfo                          |   4 +
>>   gdb/solib-svr4.c                             | 118 +++++++++++++++++--
>>   gdb/solib.c                                  |  23 +++-
>>   gdb/solist.h                                 |  11 ++
>>   gdb/testsuite/gdb.base/attach-pie-noexec.exp |   4 +-
>>   gdb/testsuite/gdb.base/dlmopen.exp           |   6 +-
>>   gdb/testsuite/gdb.mi/mi-dlmopen.exp          |   6 +-
>>   8 files changed, 160 insertions(+), 16 deletions(-)
> Thanks.
>
>> diff --git a/gdb/NEWS b/gdb/NEWS
>> index f5dbf5c3350..67794f4497c 100644
>> --- a/gdb/NEWS
>> +++ b/gdb/NEWS
>> @@ -26,6 +26,10 @@
>>   
>>   * Linux checkpoint code has been updated to work with multiple inferiors.
>>   
>> +* In systems that support linkage namespaces, the output of the command
>       ^^^^^^^^^^
> "On systems"
>
>> +In systems that support linkage namespaces, the column @code{NS} is
>> +added to the output.
> Same here, and in addition this sentence uses passive voice, so I'd
> rephrase
>
>   On systems that support linkage namespaces, the output includes an
>   additional column @code{NS}.
>
> The documentation parts are okay with these nits fixed.
>
> Reviewed-By: Eli Zaretskii <eliz@gnu.org>
>
Thanks for the review, I have applied the fixes locally!

-- 
Cheers,
Guinevere Larsen
She/Her/Hers