From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id l1tSAdAx02cWgA4AWB0awg (envelope-from ) for ; Thu, 13 Mar 2025 15:28:16 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=a3eo9k25; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id E3AFA1E08E; Thu, 13 Mar 2025 15:28:15 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 627521E08E for ; Thu, 13 Mar 2025 15:28:15 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id DDFC43857C58 for ; Thu, 13 Mar 2025 19:28:14 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DDFC43857C58 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=a3eo9k25 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id 6830E3858D39 for ; Thu, 13 Mar 2025 19:27:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6830E3858D39 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6830E3858D39 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1741894061; cv=none; b=Gm7sf06AQtdCqQ40yXlRbRMmoYI9QgWiAMWdE7ChQjHKE6BYafblG5swcs+lHhGb6/PuV75zWqGp6in7DCXRft/vuTJN3qexO7Z+M+60rTXlcZAfDmeqLv7lJd3aoBolMTrNrUqATEoM8FczW7ziPXNo9g+U045vk6uvsG9w+TM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1741894061; c=relaxed/simple; bh=MpGPMuZP5bFTvnwOgrc3K60VLBFkw7ABjeo+tNG1bPM=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=uBda7ahLJLg7niDOBgE3VdrGnU0YwsZwjcmwyxAwjqkeq+F2/gKTii/Sqi6fXKQ9b+WiYexhzpsUZQA4xjtwxnxNC0QVL457/C19l5ibXHP/pvqX/cp+n5gSPpAISEZbI7qe5c57s52L2vnOztu2AQps53OInOte7Je8ogOhHLQ= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6830E3858D39 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1741894061; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=51Qd5hddlCU2qWYfg9hjBu2AuuBNQBgrvRhVOmTuWho=; b=a3eo9k25ZMnMC3KI/BbHX7W2bGjO1niAYe0ABs4ngc0hvwTwMEO29iNy55yLzYKQ0FYpAA pqYWef4z3LC2/oxbItTt1ZAxxWyxxCuxbdmdo0TJVKOT0C5vBhz9caUBZZNHY8o6XeAg07 q48LFZrDXzKuW44E3loncaU24u74yCk= Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-519-h6h0iPCwNI2MbQ5uG-sfDQ-1; Thu, 13 Mar 2025 15:27:39 -0400 X-MC-Unique: h6h0iPCwNI2MbQ5uG-sfDQ-1 X-Mimecast-MFC-AGG-ID: h6h0iPCwNI2MbQ5uG-sfDQ_1741894059 Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-4767816a48cso37327751cf.3 for ; Thu, 13 Mar 2025 12:27:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741894059; x=1742498859; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=51Qd5hddlCU2qWYfg9hjBu2AuuBNQBgrvRhVOmTuWho=; b=PSXoU/2lVoLU97r+kQ+AFIfxb4xZsa0UEaBU1K1JJxk3Cbclm1ejhDAU8362AWrjm6 fQyaRTsY3pCvC5i7PYLXWwaWKvqOF1YxRwcS77x8GsJhwwVg+zpKS8e7m3H2uRGq0o2Q tGt6gOY/QvZBsE8Ob9PUXFfRDp9V9621B24EC95k4Qm/MpVweSve+e3AFYEzIAwwSQWu ugkD9e1zuWt2zAiZ1LRSpadaAQ9tatv59TMFdR2W53o2ifEBz6B8OCY6heaSMDk+Pjie I0KHvjruifxhsh0wp4FW7HnKqt4FjjJyByCxNpiRMeHWAddcARIkMd2dBl1bfvAty0eQ RTDw== X-Gm-Message-State: AOJu0YwYpyO5FYGZuUlwEP3hUZefcb83YE5ZPKzTJ3cjGvyrzrmMJOCO eC15wdPoF4tlEUhCE/gwPWSXHLZNEFjn9YpIpDOLoLqq5ANBmbxKMRVxWfOa5A2rLgcZBJ7m2fD UrWNdZfrIiK15mC8U71rZAbc0CESMvCX/UQFVkSvB6jcYCap1SMGXoeJekto= X-Gm-Gg: ASbGnctmNJH8TtdMUnGwEyWh1yETxGoUgBphkLY7UEgXnrsf1qUp853g6M3Y49SK6kF +ZurXcMJ+h4bs2TUwN9sy3nmaM/gx3C24KpohIQUojnNdAc2Yuj2HbYbNjgwytlCGByLm9CBLar +UvwwJAVxoxt9SYAyxktZxGY849OAnWnWRqGtpEsyj5RH87zJvpQ/z+8VrJOQibjjuzBobC4BSm AhAx9jqzrZnbnSsh6wcIJ88gUDCar0ZdxoTxUyNyNeiKUiN5siMGcV/z9FrtmFsKg9AeP/FfK8e EOKkmCBT6zO6vuqFJLpjE01uYGY= X-Received: by 2002:a05:622a:1316:b0:476:964a:e335 with SMTP id d75a77b69052e-476c63b9220mr8607041cf.24.1741894059390; Thu, 13 Mar 2025 12:27:39 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEcAQsuXbNXTKZ1BfxvMKjqq1SqAXeKOAjMhn4fqZznT46sjw1naXuAAiTRVl2jHfXLf7KBXg== X-Received: by 2002:a05:622a:1316:b0:476:964a:e335 with SMTP id d75a77b69052e-476c63b9220mr8606801cf.24.1741894059106; Thu, 13 Mar 2025 12:27:39 -0700 (PDT) Received: from ?IPV6:2804:14d:8084:9a69::1001? ([2804:14d:8084:9a69::1001]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-476bb637774sm12657841cf.23.2025.03.13.12.27.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 13 Mar 2025 12:27:38 -0700 (PDT) Message-ID: <08dd2299-c9b0-48eb-862b-4b3e285e615e@redhat.com> Date: Thu, 13 Mar 2025 16:27:36 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdb: Introduce user-friendly namespace identifier for "info shared" To: Eli Zaretskii Cc: gdb-patches@sourceware.org References: <20250313170004.3362207-2-guinevere@redhat.com> <86msdo20xo.fsf@gnu.org> From: Guinevere Larsen In-Reply-To: <86msdo20xo.fsf@gnu.org> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: wFfKPb2usr5q5gqxMtjYQeX_AoA_b1XdUBfnV71GpWo_1741894059 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 3/13/25 4:19 PM, Eli Zaretskii wrote: >> From: Guinevere Larsen >> Cc: Guinevere Larsen >> Date: Thu, 13 Mar 2025 14:00:05 -0300 >> >> gdb/NEWS | 4 + >> gdb/doc/gdb.texinfo | 4 + >> gdb/solib-svr4.c | 118 +++++++++++++++++-- >> gdb/solib.c | 23 +++- >> gdb/solist.h | 11 ++ >> gdb/testsuite/gdb.base/attach-pie-noexec.exp | 4 +- >> gdb/testsuite/gdb.base/dlmopen.exp | 6 +- >> gdb/testsuite/gdb.mi/mi-dlmopen.exp | 6 +- >> 8 files changed, 160 insertions(+), 16 deletions(-) > Thanks. > >> diff --git a/gdb/NEWS b/gdb/NEWS >> index f5dbf5c3350..67794f4497c 100644 >> --- a/gdb/NEWS >> +++ b/gdb/NEWS >> @@ -26,6 +26,10 @@ >> >> * Linux checkpoint code has been updated to work with multiple inferiors. >> >> +* In systems that support linkage namespaces, the output of the command > ^^^^^^^^^^ > "On systems" > >> +In systems that support linkage namespaces, the column @code{NS} is >> +added to the output. > Same here, and in addition this sentence uses passive voice, so I'd > rephrase > > On systems that support linkage namespaces, the output includes an > additional column @code{NS}. > > The documentation parts are okay with these nits fixed. > > Reviewed-By: Eli Zaretskii > Thanks for the review, I have applied the fixes locally! -- Cheers, Guinevere Larsen She/Her/Hers