From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id MpOwLfXv1Gdt0Q8AWB0awg (envelope-from ) for ; Fri, 14 Mar 2025 23:11:49 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=PU1Ji2al; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id A216F1E105; Fri, 14 Mar 2025 23:11:49 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 4FDAB1E05C for ; Fri, 14 Mar 2025 23:11:49 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E7F083857400 for ; Sat, 15 Mar 2025 03:11:48 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E7F083857400 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=PU1Ji2al Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id A83F63857BA9 for ; Sat, 15 Mar 2025 03:11:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A83F63857BA9 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A83F63857BA9 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1742008278; cv=none; b=N2hQA7SzjQ6nC5Iv9iSP4M67Y3XPa+lsfp39U64Da5YaRLWdGI76SCP1AwgRKf4GMKT+5Ip7WVbR1vMmVmz/1UvUJlUZMYkCg4BBN9K1vuOa5dUEe/PCq6Fgw+o1/2T1VxaSlwtH9z7mt/yMBl464w1M6jiuqsG79guWAC8YUCw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1742008278; c=relaxed/simple; bh=f5ToFtUlDK+pz70yYOH0wVsLJ1G8TJjkqlfdj7uHuEg=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=mQhDQdCc8gUtT1d0e1cAaV87jMI6NanCzmvEMmLwxWHloMGHbTFCBXPXHjz/+WZ8wndWeisQpqayHaFB3LdbN6nISbtnu+imi+0adS4jM0i4B4T/W0gXVcVUd7xcivYsSnLxBqXktlMCKIiBTT69Kr+rQYjgZtNU67pMnTLIgao= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A83F63857BA9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1742008278; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=E+zabHdRWZphI0uXT9PwhOl6W2bZDJCw2mVI5Lwg+Rg=; b=PU1Ji2alwlO/MB8oh8s3KVyNOAeQbi6nfzZ6pcOvFFn9SBO4N+VR9gAI3zsDfbORDyBr7e twL/DlqglA/Ckt0AAxWlUgMJbrMiNazzsWI3qEe+Uq0dw6NB+RmYMqc4ywFXkmHHZtqjPj UfDzk5i84rv1NQgYj/UA0Kzsg69hDSs= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-651-QLotoNe3NcSQmZuyvTSmbQ-1; Fri, 14 Mar 2025 23:11:17 -0400 X-MC-Unique: QLotoNe3NcSQmZuyvTSmbQ-1 X-Mimecast-MFC-AGG-ID: QLotoNe3NcSQmZuyvTSmbQ_1742008276 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 2DD791800349 for ; Sat, 15 Mar 2025 03:11:16 +0000 (UTC) Received: from f41-zbm-amd (unknown [10.22.88.7]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 588CD18001D4; Sat, 15 Mar 2025 03:11:14 +0000 (UTC) Date: Fri, 14 Mar 2025 20:11:12 -0700 From: Kevin Buettner To: Guinevere Larsen Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb: Introduce user-friendly namespace identifier for "info shared" Message-ID: <20250314201112.29c30ab8@f41-zbm-amd> In-Reply-To: <20250314195108.2c4891a9@f41-zbm-amd> References: <20250313170004.3362207-2-guinevere@redhat.com> <20250314195108.2c4891a9@f41-zbm-amd> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: wJTVYzj1m1JADzuB5eoHiotD7s3uSjx2W66-uihj3ic_1742008276 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On Fri, 14 Mar 2025 19:51:08 -0700 Kevin Buettner wrote: > On Thu, 13 Mar 2025 14:00:05 -0300 > Guinevere Larsen wrote: > > > Finally, a new solib_ops function pointer was added, find_solib_ns, to > > allow code outside of solib-svr4 to find and use the namespace > > identifiers. As a sanity check, the command `info sharedlibraries` has > > been changed to display the namespace identifier. Plus, a couple of tests > > had to be tweaked to handle the possible new column. > > I applied the patch, built GDB, and ran the tests. But I didn't > see the new NS column in any of the "info shared"/"info sharedlibrary" > output. Should I have seen this column? (I.e, did I do something > wrong?) Assuming that I didn't mess up, I think it'd be good to add > some tests which show the new column. So... I screwed up when attempting to resolve the "git am" problem. I guess I need to figure out how to correctly use "git am --continue". I now see the NS column in the "info shared" output. But, now, I *always* see it in the "info shared" output, even when there's only one linker namespace. Is that desirable? My opinion is that we should suppress the NS column when there's only one linker namespace. Kevin