From: Kevin Buettner <kevinb@redhat.com>
To: Milica Matic <milica.matic@htecgroup.com>
Cc: gdb-patches@sourceware.org,
Djordje Todorovic <Djordje.Todorovic@htecgroup.com>,
Milos Kalicanin <milos.kalicanin@htecgroup.com>,
"simark@simark.ca" <simark@simark.ca>,
"cfu@wavecomp.com" <cfu@wavecomp.com>,
"aburgess@redhat.com" <aburgess@redhat.com>,
"macro@orcam.me.uk" <macro@orcam.me.uk>
Subject: Re: [PATCH^11] gdb: mips: Add MIPSR6 support
Date: Tue, 11 Feb 2025 13:10:58 -0700 [thread overview]
Message-ID: <20250211131058.4962d6f6@f41-zbm-amd> (raw)
In-Reply-To: <20250210172801.43302-1-milica.matic@htecgroup.com>
Hi Milica,
On Mon, 10 Feb 2025 17:28:12 +0000
Milica Matic <milica.matic@htecgroup.com> wrote:
> Introduce new instruction encodings from Release 6 of the MIPS
> architecture [1]. Support breakpoints and single stepping with
> compact branches, forbidden slots, new branch instruction and
> new atomic load-store instruction encodings.
>
> Changes from v10: Apply suggestions provided by Kevin Buettner.
> Additionaly, format mips-tdep.c code as described on links:
> https://sourceware.org/gdb/wiki/Internals%20GDB-C-Coding-Standards
> https://www.gnu.org/prep/standards/standards.html#Comments
>
> [1] "MIPS64 Architecture for Programmers Volume II-A: The MIPS64
> Instruction Set Reference Manual", Document Number: MD00087,
> Revision 6.06, December 15, 2016, Section 3 "The MIPS64
> Instruction Set", pp. 42-530
> https://s3-eu-west-1.amazonaws.com/downloads-mips/documents/MD00087-2B-MIPS64BIS-AFP-6.06.pdf
> 2025-02-10
> Andrew Bennett <andrew.bennett@imgtec.com>
> Matthew Fortune <matthew.fortune@mips.com>
> Faraz Shahbazker <fshahbazker@wavecomp.com>
The code formatting looks good to me now.
Additionally, I don't see anything obviously wrong with the MIPSR6
support that's been added. That said, I'm not especially
knowledgeable about MIPS these days, so I ask that you wait a few days
for other maintainers to weigh in before pushing this patch.
Approved-by: Kevin Buettner <kevinb@redhat.com>
next prev parent reply other threads:[~2025-02-11 20:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-10 17:28 Milica Matic
2025-02-11 20:10 ` Kevin Buettner [this message]
2025-02-11 20:45 ` Maciej W. Rozycki
2025-02-19 13:05 ` Milica Matic
2025-02-19 13:14 ` Milica Matic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250211131058.4962d6f6@f41-zbm-amd \
--to=kevinb@redhat.com \
--cc=Djordje.Todorovic@htecgroup.com \
--cc=aburgess@redhat.com \
--cc=cfu@wavecomp.com \
--cc=gdb-patches@sourceware.org \
--cc=macro@orcam.me.uk \
--cc=milica.matic@htecgroup.com \
--cc=milos.kalicanin@htecgroup.com \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox