Re: [PATCH^11] gdb: mips: Add MIPSR6 support

Kevin Buettner
2025-02-11T20:12:20Z

Hi Milica,

On Mon, 10 Feb 2025 17:28:12 +0000
Milica Matic <milica.matic@htecgroup.com> wrote:

> Introduce new instruction encodings from Release 6 of the MIPS
> architecture [1]. Support breakpoints and single stepping with
> compact branches, forbidden slots, new branch instruction and
> new atomic load-store instruction encodings.
>
> Changes from v10: Apply suggestions provided by Kevin Buettner.
> Additionaly, format mips-tdep.c code as described on links:
> https://sourceware.org/gdb/wiki/Internals%20GDB-C-Coding-Standards
> https://www.gnu.org/prep/standards/standards.html#Comments
>
> [1] "MIPS64 Architecture for Programmers Volume II-A: The MIPS64
> Instruction Set Reference Manual", Document Number: MD00087,
> Revision 6.06, December 15, 2016, Section 3 "The MIPS64
> Instruction Set", pp. 42-530
> https://s3-eu-west-1.amazonaws.com/downloads-mips/documents/MD00087-2B-MIPS64BIS-AFP-6.06.pdf
> 2025-02-10
> Andrew Bennett <andrew.bennett@imgtec.com>
> Matthew Fortune <matthew.fortune@mips.com>
> Faraz Shahbazker <fshahbazker@wavecomp.com>

The code formatting looks good to me now.

Additionally, I don't see anything obviously wrong with the MIPSR6
support that's been added. That said, I'm not especially
knowledgeable about MIPS these days, so I ask that you wait a few days
for other maintainers to weigh in before pushing this patch.

Approved-by: Kevin Buettner <kevinb@redhat.com>