From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id yxPpJCSvq2eCfCsAWB0awg (envelope-from ) for ; Tue, 11 Feb 2025 15:12:20 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=S40j2NUA; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 8B09B1E105; Tue, 11 Feb 2025 15:12:20 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=unavailable autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id EEDE71E08E for ; Tue, 11 Feb 2025 15:12:19 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 8A0603858C5F for ; Tue, 11 Feb 2025 20:12:18 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8A0603858C5F Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=S40j2NUA Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id C61073858D33 for ; Tue, 11 Feb 2025 20:11:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C61073858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C61073858D33 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1739304670; cv=none; b=HtYBltxqONFnJw+2fWFjFdvHFwMWx25B0ay3YTiIogg26sugngYMqaEsRsHOt9bBOhnAH5S7i3WMKT5EIRWM3gcdBdXwzILCPwSeJ8zhFrzGI0cK+Sqwn4duiR8bLQRF7zrRTUQbfxyLk+gA9y73sYTaf7sUUUdBP1PRliq4MNs= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1739304670; c=relaxed/simple; bh=OIZFmvq9m6B+zRdnsvIrXlwVlYqTTU7o0peTdP2owTE=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=rXqEQVykNtnHIhAhpjiT71opl20H+wocqphBwS5QDgPpSfBeVlLOieXjajEafF1GLTzNoEZmN2LHsh4AwcP/V19WOcRscLSUy+63AiIgSDlaKpDyWJ21W2GxZu85htESfbEMD5Ed0iEgGkvlIVqPw8lARty2I/OTTPoVsaTXBoQ= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C61073858D33 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1739304670; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wKtU67mN5jxMO1M0nu70urjvLSTaN3y0fu5xPFSUOSM=; b=S40j2NUAK6UmVSPGjjelhCegrfZaOJEqQd+sSVhSxF9bAX0O25S3rH1wLI5AuRs3mAScDR ciiie60e03dToUn0Mn5QuI/CLqKd+m0t72XVIF7cHjrxQLLqaI7dYmXAB2VGM5Y0Fsbhco v93F//+vBithXLm9+dR+3gT2Xpk2q7U= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-512-tbO-ZZ9NM-2ttBA_pYAMYw-1; Tue, 11 Feb 2025 15:11:07 -0500 X-MC-Unique: tbO-ZZ9NM-2ttBA_pYAMYw-1 X-Mimecast-MFC-AGG-ID: tbO-ZZ9NM-2ttBA_pYAMYw Received: from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 77E82195608C; Tue, 11 Feb 2025 20:11:05 +0000 (UTC) Received: from f41-zbm-amd (unknown [10.22.81.226]) by mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id EEAC319560AD; Tue, 11 Feb 2025 20:11:02 +0000 (UTC) Date: Tue, 11 Feb 2025 13:10:58 -0700 From: Kevin Buettner To: Milica Matic Cc: gdb-patches@sourceware.org, Djordje Todorovic , Milos Kalicanin , "simark@simark.ca" , "cfu@wavecomp.com" , "aburgess@redhat.com" , "macro@orcam.me.uk" Subject: Re: [PATCH^11] gdb: mips: Add MIPSR6 support Message-ID: <20250211131058.4962d6f6@f41-zbm-amd> In-Reply-To: <20250210172801.43302-1-milica.matic@htecgroup.com> References: <20250210172801.43302-1-milica.matic@htecgroup.com> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.40 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: T34g5zabILhbKKV7Ggf-U5TuwfHgkjJGS7oDL_oW9gI_1739304666 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Hi Milica, On Mon, 10 Feb 2025 17:28:12 +0000 Milica Matic wrote: > Introduce new instruction encodings from Release 6 of the MIPS > architecture [1]. Support breakpoints and single stepping with > compact branches, forbidden slots, new branch instruction and > new atomic load-store instruction encodings. > > Changes from v10: Apply suggestions provided by Kevin Buettner. > Additionaly, format mips-tdep.c code as described on links: > https://sourceware.org/gdb/wiki/Internals%20GDB-C-Coding-Standards > https://www.gnu.org/prep/standards/standards.html#Comments > > [1] "MIPS64 Architecture for Programmers Volume II-A: The MIPS64 > Instruction Set Reference Manual", Document Number: MD00087, > Revision 6.06, December 15, 2016, Section 3 "The MIPS64 > Instruction Set", pp. 42-530 > https://s3-eu-west-1.amazonaws.com/downloads-mips/documents/MD00087-2B-MIPS64BIS-AFP-6.06.pdf > 2025-02-10 > Andrew Bennett > Matthew Fortune > Faraz Shahbazker The code formatting looks good to me now. Additionally, I don't see anything obviously wrong with the MIPSR6 support that's been added. That said, I'm not especially knowledgeable about MIPS these days, so I ask that you wait a few days for other maintainers to weigh in before pushing this patch. Approved-by: Kevin Buettner