Re: [PATCH^11] gdb: mips: Add MIPSR6 support

[Milica Matic <milica.matic@htecgroup.com>]

HTEC Proprietary

Hello Kevin and Maciej,

I've just separated the patch into 'apply coding guidelines' and 'gdb: add mipsr6 support'.

Many thanks for your suggestions,
Milica

________________________________________
From: Maciej W. Rozycki <macro@orcam.me.uk>
Sent: Tuesday, February 11, 2025 21:45
To: Kevin Buettner; Milica Matic
Cc: gdb-patches@sourceware.org; Djordje Todorovic; Milos Kalicanin; simark@simark.ca; cfu@wavecomp.com; aburgess@redhat.com
Subject: Re: [PATCH^11] gdb: mips: Add MIPSR6 support

CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe.


On Tue, 11 Feb 2025, Kevin Buettner wrote:

> > Changes from v10: Apply suggestions provided by Kevin Buettner.
> > Additionaly, format mips-tdep.c code as described on links:
> > https://sourceware.org/gdb/wiki/Internals%20GDB-C-Coding-Standards
> > https://www.gnu.org/prep/standards/standards.html#Comments
> >
> > [1] "MIPS64 Architecture for Programmers Volume II-A: The MIPS64
> >     Instruction Set Reference Manual", Document Number: MD00087,
> >     Revision 6.06, December 15, 2016, Section 3 "The MIPS64
> >     Instruction Set", pp. 42-530
> > https://s3-eu-west-1.amazonaws.com/downloads-mips/documents/MD00087-2B-MIPS64BIS-AFP-6.06.pdf
> > 2025-02-10
> > Andrew Bennett  <andrew.bennett@imgtec.com>
> > Matthew Fortune  <matthew.fortune@mips.com>
> > Faraz Shahbazker  <fshahbazker@wavecomp.com>
>
> The code formatting looks good to me now.

 I have a concern about formatting changes to lines otherwise not affected
by MIPSr6 additions, as they obfuscate the actual code change and would do
so forever if pushed even if you verified that they are legitimate.

 Milica, can you therefore please filter them out (`diff -w' should help;
there shouldn't be much if anything to fix up afterwards) and submit as a
separate patch, perhaps a preparatory one?  I know this is boring stuff,
but we need to care about our sanity while handling this stuff long-term.

> Additionally, I don't see anything obviously wrong with the MIPSR6
> support that's been added.  That said, I'm not especially
> knowledgeable about MIPS these days, so I ask that you wait a few days
> for other maintainers to weigh in before pushing this patch.

 I'd like to have a look yet at the refreshed change as I've spotted some
suspicious stuff I need to feel comfortable about before moving forward.
Hopefully with the formatting noise moved out of the way it should be more
straightforward for me to verify things.

 Thank you, Kevin, for taking the lead here.

  Maciej