From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id GLwTNl/XtWfeUDYAWB0awg (envelope-from ) for ; Wed, 19 Feb 2025 08:06:39 -0500 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=htecgroup.com header.i=@htecgroup.com header.a=rsa-sha256 header.s=selector1 header.b=lx8D/un/; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id D90A51E105; Wed, 19 Feb 2025 08:06:39 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=unavailable autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 446AA1E05C for ; Wed, 19 Feb 2025 08:06:39 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 2150A3858C3A for ; Wed, 19 Feb 2025 13:06:38 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2150A3858C3A Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=htecgroup.com header.i=@htecgroup.com header.a=rsa-sha256 header.s=selector1 header.b=lx8D/un/ Received: from DU2PR03CU002.outbound.protection.outlook.com (mail-northeuropeazlp170120003.outbound.protection.outlook.com [IPv6:2a01:111:f403:c200::3]) by sourceware.org (Postfix) with ESMTPS id BECF13858C3A for ; Wed, 19 Feb 2025 13:05:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BECF13858C3A Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=htecgroup.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=htecgroup.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org BECF13858C3A Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=2a01:111:f403:c200::3 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1739970334; cv=pass; b=Kyz9QcHCcOfVBDrWnKFD1xDnCLtevYcMJf684Nu+DpmPmflnKseecARKvD0QBpAMD1AIrJq9tDI1tgqoUs6y29be8NDBRAYvoEyS21dhYcIAnK2X6FmzLBK0xNssaD5hi081dnfZFRoKyTwxj174CpgEH0d3Wh2SUB57UzkJN8M= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1739970334; c=relaxed/simple; bh=zu+7aWwGw6N0WWY1CgaYmDJNcbZ/nHqGQSQw6VgpB60=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=kZjQR9Dgg68YO6C8zpOgwgp9UoFC6RPyspjC/L6FGsQgsG/8l8tPZc4iDad2H+hb0n7ishntE2bteAv0sclRW/JwrSrT4GGIGcfRpGCuXOIrGoQKzWX1PKJHjWXOAHVEvzQBt7ux7mOd6bc9Rt2S+g63VRFo0OGlL+9L4+zrNkw= ARC-Authentication-Results: i=2; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BECF13858C3A ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=mAE5AwssSv7AGQloiG0ZQCQwI073NoHy7UZleTkmubPRyJ8l4/mahOCGLb+IhqzmkEtSPgwnvRKbVW8s5Y2RVAW9NVTB1jEiQvrZE5bVkoVAGO9ZW1887oGrf/pVcIb+ogBilg6zozhCFs2+xMTR0JGSiwGx/qKSGnxLuwLovEa9aGqf2mZuj5DlUQIahdpO5BXOt3RSErGOH3xbH82HlEM2GB5+moGr+/GfFCu4zVaPxKZNB8UaSsjkM4+gX0vcezMrL97xrer7R8bBrU1g4UqsxuU3d1wXjjf3Luc+1rN9EuHslXPLQ6RjnpvdqvjbezMMfLaAFNJ/N6Ua0K0e1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+RrcZVILVPQiw76sosC8KIOtG44G10mNrPQruvLAOUc=; b=jPkeHLBvLbHjK6k7dkX+q6pHp0mTt5IHkZiJaHP0YP6vALGaCUpS5s4RFxJRhvQSxg9trrpoqkG5LO/2SS/sGP89JVzaU+MLeNXi2sMSzHBU+rqafQPTAQH20j5lSyBLUfVeVcdegiKV5KZEYxw+BQrYbgjRrQOi+vcNcs8DhqrxWfZUs/UkAKW4U8saaVXBCVfKR9EL+Yy2XnBo5jhArTzbDQduHmg5DepMkH6EsW4LrC07S9MV+POp4kpUCnxx7CgxzfAcPlIdr3Edp3kVaJ17Z4hl/a00vtTlsugoCtA9cu2GCG/uxQ6otvt729hc1STvA88ZQJUTC6BICi7VKQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=htecgroup.com; dmarc=pass action=none header.from=htecgroup.com; dkim=pass header.d=htecgroup.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=htecgroup.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+RrcZVILVPQiw76sosC8KIOtG44G10mNrPQruvLAOUc=; b=lx8D/un/Y1tqAPbUpbkEvFYKRHZX0/QW7c3NGxp6h3ReoYrskVhvb7/EIF4xVCYS7BhABALadZWOfX0UcXsPJko3r+tGRbSjA3CdPh/BQV2Ndge+Y0Z78rdR+QXOeqspMK5i8ToGaH85w0SYyV/T70ULxS3m8T3D6j0IHqRvIdZA6VgTio1bkE8fUeVRPsGzDWGt2BpzJC7l1/TApu84dZs1DOnlWlL7BSImb7yBfXQxCHphSVN53k14ypR8Iz82mpnWUNZKaemk5Ld0GRvKHCsYiwAijNIlMqDzq65IMv6rs0Nzd8CrdTdcvug+pIdBgAa8hbU98IMxX6rty6OlLA== Received: from PR3PR09MB4361.eurprd09.prod.outlook.com (2603:10a6:102:36::24) by PAWPR09MB6726.eurprd09.prod.outlook.com (2603:10a6:102:389::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8445.19; Wed, 19 Feb 2025 13:05:32 +0000 Received: from PR3PR09MB4361.eurprd09.prod.outlook.com ([fe80::5a48:eb91:741a:802c]) by PR3PR09MB4361.eurprd09.prod.outlook.com ([fe80::5a48:eb91:741a:802c%5]) with mapi id 15.20.8466.015; Wed, 19 Feb 2025 13:05:32 +0000 From: Milica Matic To: "Maciej W. Rozycki" , Kevin Buettner CC: "gdb-patches@sourceware.org" , Djordje Todorovic , Milos Kalicanin , "simark@simark.ca" , "cfu@wavecomp.com" , "aburgess@redhat.com" Subject: Re: [PATCH^11] gdb: mips: Add MIPSR6 support Thread-Topic: [PATCH^11] gdb: mips: Add MIPSR6 support Thread-Index: AQHbe+EpSQR+XLmAKk6GG9YCw2+lD7NCil4AgAAJnYCADBHfOw== Date: Wed, 19 Feb 2025 13:05:31 +0000 Message-ID: References: <20250210172801.43302-1-milica.matic@htecgroup.com> <20250211131058.4962d6f6@f41-zbm-amd> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_ac629de7-cfdf-49f2-9483-80ca02e7fb52_Enabled=True; MSIP_Label_ac629de7-cfdf-49f2-9483-80ca02e7fb52_SiteId=9f85665b-7efd-4776-9dfe-b6bfda2565ee; MSIP_Label_ac629de7-cfdf-49f2-9483-80ca02e7fb52_SetDate=2025-02-19T13:05:31.654Z; MSIP_Label_ac629de7-cfdf-49f2-9483-80ca02e7fb52_Name=HTEC Proprietary; MSIP_Label_ac629de7-cfdf-49f2-9483-80ca02e7fb52_ContentBits=0; MSIP_Label_ac629de7-cfdf-49f2-9483-80ca02e7fb52_Method=Standard; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=htecgroup.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PR3PR09MB4361:EE_|PAWPR09MB6726:EE_ x-ms-office365-filtering-correlation-id: b37e5954-6d72-4b1f-9f2b-08dd50e6174d x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; ARA:13230040|366016|376014|1800799024|38070700018|7053199007; x-microsoft-antispam-message-info: =?us-ascii?Q?HTWMYCixFtqTLRlu5hl8g4IqDA6mhg0wrCot8xvh5BW5AC/ZxLCGJZ8nE1av?= =?us-ascii?Q?VBPgDi9sAwxSU5i1NTHNhJxM6JNQe1Xa/O9p2CQpqJd9qxXVAlfEYL8woRpP?= =?us-ascii?Q?j4gTK4z/5K7PqehYEll2AyEN/SS5deJAsrxefc/yz9jFe14OgaBsbDBWKhcJ?= =?us-ascii?Q?F13aNkIWcUdjBBowGUAXrrp5MPZGKZiCMA4MweDaSc4r3heWAxLMM6ul6KIx?= =?us-ascii?Q?ArRdG+79+uDQzUeHxvC4bgTjQ10Xop4h5BZTY6E3xQzHZXba1s1+jKSjBwPe?= =?us-ascii?Q?C7eGV8J0u/S0mCifTQ09A36PGeJZs8JNqCqo0V/RIfPgsULesIizlXAHsxRA?= =?us-ascii?Q?LjT0smB1k7TIndkVYD+Zoni6kTWLyFH0j1KDJ5vRpFFTpawWN1F4k56ojvR7?= =?us-ascii?Q?NRlralkLOx9mMuSOxsEUjJ0jS+bZSgh4JmPly7SuIPBiDnsSyqhzs53YSmdZ?= =?us-ascii?Q?MAXiQZpMvXpnxDLGI3V7k4AL919xgt1JKWYKR2/Y7tr+VwC65O/4BWX01raa?= =?us-ascii?Q?XbaoZhMRds65DC9rLwzDXwEOf8FxlrhM2Z5/Zhc52m8lIuZuJib/izcPDwLq?= =?us-ascii?Q?ENroCtHjKteoiahsuwJWI4crVx7K2RULkn6byh0WYc0izG8cneAuBUEfn7NG?= =?us-ascii?Q?lo7ZuNK02b/wQkBh5JR0VIPZ8Y3+2uBe/oYG4mZOBun/sFahE6dXibGmJTjs?= =?us-ascii?Q?rLSJFy2Wy0AUxTEe9JeQe+S5v50P3boM/hYM43e1KLi80YOF2NlHmtE76fD4?= =?us-ascii?Q?HOX6RgEBXTG/Q8SOdtxDvUaiWoBe6hqRoEuiIuKt50sKA457j8IajlSUxg4q?= =?us-ascii?Q?rI/VeK/pfrjIF0mUI3cTnEoqNC7uIldTSqLvpYBRTta1ZFHh1smTr8mwDbJm?= =?us-ascii?Q?dfoK53jfSMb0uDuIPruTk2eLJkJOPfkg601vkOwkL0Nk4VW8ZOEk7oAk0xyR?= =?us-ascii?Q?s2W70B1RxrNImInNBNJo+M4mpG9wcTYwMGPMhj/rYc5FPjH/aln2gl37bgCk?= =?us-ascii?Q?m4DZc8jXbRLvstD9RJNod4S4syv+pd7MJxX2jGGyALd3GKkiwhaRuSrtd7cv?= =?us-ascii?Q?9BdmIiLLpWbHxem/VZHweM3WmvV8dcfra+FvMcwP85sR4nGlSqI3RQaNQ2l1?= =?us-ascii?Q?PX+RAv1wa7+eVqMqYGjdW72yv894J5EixUatTSoq9Lhd1cf8yOD/hwspjr0x?= =?us-ascii?Q?N8b7MgMC1UrTQi6gzzSDBKDPK3PFleNSMjpSGSeeueSFcHXUYPcIWbMMngsF?= =?us-ascii?Q?eU+l/ZSlBNpGmcIblv4iPpon9RE50A2DOz+gpGHszKjykdAANM2BbIwRsJBV?= =?us-ascii?Q?PMkCXo1XeIYGOMUuEESC1OIuZf1xB/djnfkeFLQo3uJzVK79RrjR6zlvFioq?= =?us-ascii?Q?BODO8fnfrZE1806XDc4hHLM8Aty2?= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PR3PR09MB4361.eurprd09.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(376014)(1800799024)(38070700018)(7053199007); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?YlifpbN9d9LcXpwYVH8+bTT5KN2R4NG0H6LXWwIatfOLmhXgSRe9NW2c2CfU?= =?us-ascii?Q?77g5sPRAjbwq8TkCc1kkKlyvgynrWBH8YPPmp6/GQzHR5E5T87Dyy8paZm1R?= =?us-ascii?Q?uamGjYDqEjWJlCPruPvgi/qJWvdK7MwfjWNONsYjrQGRn4mbzsmAyYldW+Z/?= =?us-ascii?Q?tu2x1P+19+o02yBuxdOybqHuV7NU9rVdKX+jZR1Ewa4TU+qPtbEYkzqvBcvb?= =?us-ascii?Q?UsrF2+pUlMX3SBvoMkFJQdQF1rXCzxIyd5yWKsVL+pKRcIOSYRiPSK0eEujQ?= =?us-ascii?Q?mLcZ4ERfBvgpEzU4AxD3XBji9T8mqL5QASfkxZBiVtE2M7DwYzEP/roJc1zl?= =?us-ascii?Q?/cfyIdp+HXI4cIXZ2ERmAYdU2yhtUD+vRXseczuMjTkobkma38AR1tdvnuss?= =?us-ascii?Q?qDI3RLMd27FjBkqJ33PObZffM2iEKPfniIpGlJRnzSHp1dJcpjE/q2CTLMlT?= =?us-ascii?Q?Hm6bq+hyp0OklejkDB7sd1pmHbVnJ4RzV51GvEsV7pr20W2jSvj/knp+0YJm?= =?us-ascii?Q?WSVuN3K1JK5H8voqXlikIK9fuKcU7nHnlQWJqMuu+CQrZs25vRTBtTQBIctG?= =?us-ascii?Q?QrC/GdKvzkKfUEusqmfOh74vfxLN73240KSedgjSRTkbnpnzOjffWZrukqI8?= =?us-ascii?Q?QSat+OofewE9siipVoGNWxW0yY9la5q7QHQSf5eHrRMjKJSxA4NxbwkAU8t6?= =?us-ascii?Q?yvULiekb7KSkgoUnervKOttsS3EBT5304YhOv3UsdcNKPXjpHnIYy25CsnvQ?= =?us-ascii?Q?kIM1eTcJTasUAldgSvMnCqMJddBPCL+vWePl8qfXWHmw4vMzbtfQMA1gpYDt?= =?us-ascii?Q?mg4IdZj98GVQ0M8MMP/xU6slosPdngcj/OBfc0sdvvC5luEFQ9AS3Rqp3KJd?= =?us-ascii?Q?vjuOfUdE+tfPcpehO9jMvU0FXVzY9Mjkjd7d9FS2SWRIIa60LF9EzXsNCBEr?= =?us-ascii?Q?pg3tDcfFCteLcNq8BbXqubz1St+kd9rje9PdQZluhjqrRDA37Znc+sfT1CEW?= =?us-ascii?Q?0yqmHwxdy8xGQ2OA/nkGF3XkcnMsUpYIoQ8CUqJpVoDq1t7GSmtTqV3ERAbx?= =?us-ascii?Q?6+wv+obMz5kq3dyHvkB4Uh3SvthF2946zWFFGFJpiFAe6fbxBWx8lRURN4Xq?= =?us-ascii?Q?ePEgtcW3S6fbei8Bl6PTku9Ib0+oYfXTWVjhyVf4f/3kNFujgy2gRqI1wDJn?= =?us-ascii?Q?bMuNLW79/gQCTqCLk7XEwODoBLH5IpnFlQOJJ61B2J6ElJt7ufSCcsmXDe2C?= =?us-ascii?Q?hnl4sq1cV9NBLIy5LX95uYBHpRIWwjs3hxm/9lfGgCY/drOvlCHEtcPVybC8?= =?us-ascii?Q?G58KZM2HfQmgHOmo9wiWZyBEIsOOKy9aXztaHZBKKiijgmaHPdPVr29IyoAk?= =?us-ascii?Q?184PbjmTdKosRRWGVYmtp5EvpwnLp9adUCpqj9+JQfIJV2ywJ/99cWg6a4Jw?= =?us-ascii?Q?QGOzci7xYu6eDx9jv+b9/xFNzEyXoM4HvliCGeYd9L8kkocc9Nyb1SoPd3lU?= =?us-ascii?Q?UCGsGwoKcoNIhB/O+TBBQfyKmGI1lrhcWsvZ1U2HmNkw0d4CmykXNkuzsSGv?= =?us-ascii?Q?oJYhy84NCLseyeds8X29hOFAgd4F3dh65mXMITm7jot6AojjqBCd6T3sFZnF?= =?us-ascii?Q?EA=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: htecgroup.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PR3PR09MB4361.eurprd09.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b37e5954-6d72-4b1f-9f2b-08dd50e6174d X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Feb 2025 13:05:31.9597 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 9f85665b-7efd-4776-9dfe-b6bfda2565ee X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: O1oxkvLJwn9b58XD6S8WL5C1u9AApAdoLn/ibFIY//tkK5p3EcGXvYEfA4QBDp6EsNENmatw/SX7rxQygEi448Qhud/raAf4wxsFe6yAx4A= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR09MB6726 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org HTEC Proprietary Hello Kevin and Maciej, I've just separated the patch into 'apply coding guidelines' and 'gdb: add = mipsr6 support'. Many thanks for your suggestions, Milica ________________________________________ From: Maciej W. Rozycki Sent: Tuesday, February 11, 2025 21:45 To: Kevin Buettner; Milica Matic Cc: gdb-patches@sourceware.org; Djordje Todorovic; Milos Kalicanin; simark@= simark.ca; cfu@wavecomp.com; aburgess@redhat.com Subject: Re: [PATCH^11] gdb: mips: Add MIPSR6 support CAUTION: This email originated from outside of the organization. Do not cli= ck links or open attachments unless you recognize the sender and know the c= ontent is safe. On Tue, 11 Feb 2025, Kevin Buettner wrote: > > Changes from v10: Apply suggestions provided by Kevin Buettner. > > Additionaly, format mips-tdep.c code as described on links: > > https://sourceware.org/gdb/wiki/Internals%20GDB-C-Coding-Standards > > https://www.gnu.org/prep/standards/standards.html#Comments > > > > [1] "MIPS64 Architecture for Programmers Volume II-A: The MIPS64 > > Instruction Set Reference Manual", Document Number: MD00087, > > Revision 6.06, December 15, 2016, Section 3 "The MIPS64 > > Instruction Set", pp. 42-530 > > https://s3-eu-west-1.amazonaws.com/downloads-mips/documents/MD00087-2B-= MIPS64BIS-AFP-6.06.pdf > > 2025-02-10 > > Andrew Bennett > > Matthew Fortune > > Faraz Shahbazker > > The code formatting looks good to me now. I have a concern about formatting changes to lines otherwise not affected by MIPSr6 additions, as they obfuscate the actual code change and would do so forever if pushed even if you verified that they are legitimate. Milica, can you therefore please filter them out (`diff -w' should help; there shouldn't be much if anything to fix up afterwards) and submit as a separate patch, perhaps a preparatory one? I know this is boring stuff, but we need to care about our sanity while handling this stuff long-term. > Additionally, I don't see anything obviously wrong with the MIPSR6 > support that's been added. That said, I'm not especially > knowledgeable about MIPS these days, so I ask that you wait a few days > for other maintainers to weigh in before pushing this patch. I'd like to have a look yet at the refreshed change as I've spotted some suspicious stuff I need to feel comfortable about before moving forward. Hopefully with the formatting noise moved out of the way it should be more straightforward for me to verify things. Thank you, Kevin, for taking the lead here. Maciej