[PATCH] sim: common: fix printf formats

[PATCH] sim: common: fix printf formats

[Mike Frysinger via Gdb-patches]

For 32-bit targets, %x happens to work for unsigned_word.  But for
64-bit targets, it's too small, and gcc throws an error.  Use the
right printf format define for them.

* sim-core.c (sim_memory_map): Change %#x to PRIxTW.
---
 sim/common/sim-core.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/sim/common/sim-core.c b/sim/common/sim-core.c
index ade345ef16fb..9b1e16832104 100644
--- a/sim/common/sim-core.c
+++ b/sim/common/sim-core.c
@@ -480,7 +480,8 @@ sim_memory_map (SIM_DESC sd)
 	  if (mapping->level != 0)
 	    continue;
 
-	  entry = xasprintf ("<memory type='ram' start='%#x' length='%#x'/>\n",
+	  entry = xasprintf ("<memory type='ram' start='%#" PRIxTW "' "
+			     "length='%#" PRIxTW "'/>\n",
 			     mapping->base, mapping->nr_bytes);
 	  /* The sim memory map is organized by access, not by addresses.
 	     So a RWX memory map will have three independent mappings.
-- 
2.28.0

Re: [PATCH] sim: common: fix printf formats

[Andrew Burgess]

* Mike Frysinger via Gdb-patches <gdb-patches@sourceware.org> [2021-01-09 14:09:35 -0500]:

> For 32-bit targets, %x happens to work for unsigned_word.  But for
> 64-bit targets, it's too small, and gcc throws an error.  Use the
> right printf format define for them.

Missing ChangeLog, otherwise, LGTM.

Thanks,
Andrew


> 
> * sim-core.c (sim_memory_map): Change %#x to PRIxTW.
> ---
>  sim/common/sim-core.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/sim/common/sim-core.c b/sim/common/sim-core.c
> index ade345ef16fb..9b1e16832104 100644
> --- a/sim/common/sim-core.c
> +++ b/sim/common/sim-core.c
> @@ -480,7 +480,8 @@ sim_memory_map (SIM_DESC sd)
>  	  if (mapping->level != 0)
>  	    continue;
>  
> -	  entry = xasprintf ("<memory type='ram' start='%#x' length='%#x'/>\n",
> +	  entry = xasprintf ("<memory type='ram' start='%#" PRIxTW "' "
> +			     "length='%#" PRIxTW "'/>\n",
>  			     mapping->base, mapping->nr_bytes);
>  	  /* The sim memory map is organized by access, not by addresses.
>  	     So a RWX memory map will have three independent mappings.
> -- 
> 2.28.0
> 

Re: [PATCH] sim: common: fix printf formats

[Mike Frysinger via Gdb-patches]

[-- Attachment #1: Type: text/plain, Size: 469 bytes --]

On 11 Jan 2021 11:33, Andrew Burgess wrote:
> * Mike Frysinger via Gdb-patches <gdb-patches@sourceware.org> [2021-01-09 14:09:35 -0500]:
> > For 32-bit targets, %x happens to work for unsigned_word.  But for
> > 64-bit targets, it's too small, and gcc throws an error.  Use the
> > right printf format define for them.
> 
> Missing ChangeLog, otherwise, LGTM.

it was in the commit message:

> > * sim-core.c (sim_memory_map): Change %#x to PRIxTW.

-mike

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]