From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id QYNCCX83/F+6FQAAWB0awg (envelope-from ) for ; Mon, 11 Jan 2021 06:33:19 -0500 Received: by simark.ca (Postfix, from userid 112) id 1E0B01EEEF; Mon, 11 Jan 2021 06:33:19 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_NONE,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (unknown [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C5DD01E590 for ; Mon, 11 Jan 2021 06:33:18 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 184D4384A87E; Mon, 11 Jan 2021 11:33:18 +0000 (GMT) Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by sourceware.org (Postfix) with ESMTPS id 7439D384A87E for ; Mon, 11 Jan 2021 11:33:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 7439D384A87E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=andrew.burgess@embecosm.com Received: by mail-wm1-x32c.google.com with SMTP id e25so14762657wme.0 for ; Mon, 11 Jan 2021 03:33:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=kQQ/gsHZFj9a1ctnc0tsXb5TWEBaBCorUUqAJPVI4yY=; b=eywcCUKXb3ZsA3mTXJ5HFJIp23Awh6Os5y208pkDRh9NDcQkaKxcl8VoqV+dbRmDHf 5M9we7RZpsJn9kIC+sJSlrv+RvMYbQgxBeFmZzL+mfRxGFgptehYaIe1wfrTVXx+0rKG jcBQ9I9HEwAOyVypHKE0mHmxy2b61MleGZPSv74igc0Y7ZyYmxgtGLU0glojKzExqf6M v2RT/kw5O/oZitJM+ExUfDeHe8W9oqX5Plq5D6zL8oXLaUnXQZdQy0I1Xs+424/+7ZXs //2zpZcfvGCG69URXtVcnisxpZja55PDFh2yrnkK06xjSGGvdGMAT86isHAl4i2oe3ZR +R8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=kQQ/gsHZFj9a1ctnc0tsXb5TWEBaBCorUUqAJPVI4yY=; b=Qm/3W26NYiJ1Ej9SOUVyNRGCGUcVIHWVgveNYrNl1RPDWBgIz5tYDLBEvg1MY389Ql nJss557nhfPUrSH9giizAle25oOls9+CK0xSZvDkzWYfojwqfjE//ZANxo/FFUVP706K VfQ5gQViO1BJ3WfTzTSPOZb4r7hvHS0ugq0CwIWKPGau1BdPwM8DxO+oXy+JmGgYE9Mv 1ohtDCQAmoaFtr1J7H47RA55JZIMS8oJ9AcykTbJAWik8fTd/TU/s3RidQBjz6G+Ssta dtglo4tKKpQeOAIMre9+/ZyTK2UgTW1tF7UcQcixEf3EjmblP93tP+9saNSX3PGXkMTf soPQ== X-Gm-Message-State: AOAM533BzREY1ohAc+quwoZAZwBOz6epWru64L07rZg1DSSItPde0P2W +DZyhZbXh+TIsedC2vbzGsSt0f4Ey1g5xg== X-Google-Smtp-Source: ABdhPJw5SskCEt6VIs3pTv6Q8VwnnvwsFrxrbGa5fFdwVttgWhKtWi5oHIG8rn5ITKFA1AqVB3038A== X-Received: by 2002:a1c:1d85:: with SMTP id d127mr13978962wmd.39.1610364795570; Mon, 11 Jan 2021 03:33:15 -0800 (PST) Received: from localhost (host86-166-129-230.range86-166.btcentralplus.com. [86.166.129.230]) by smtp.gmail.com with ESMTPSA id u66sm22080632wmg.30.2021.01.11.03.33.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Jan 2021 03:33:14 -0800 (PST) Date: Mon, 11 Jan 2021 11:33:14 +0000 From: Andrew Burgess To: Mike Frysinger Subject: Re: [PATCH] sim: common: fix printf formats Message-ID: <20210111113314.GD1175365@embecosm.com> References: <20210109190935.13594-1-vapier@gentoo.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210109190935.13594-1-vapier@gentoo.org> X-Operating-System: Linux/5.8.13-100.fc31.x86_64 (x86_64) X-Uptime: 11:29:17 up 33 days, 16:13, X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" * Mike Frysinger via Gdb-patches [2021-01-09 14:09:35 -0500]: > For 32-bit targets, %x happens to work for unsigned_word. But for > 64-bit targets, it's too small, and gcc throws an error. Use the > right printf format define for them. Missing ChangeLog, otherwise, LGTM. Thanks, Andrew > > * sim-core.c (sim_memory_map): Change %#x to PRIxTW. > --- > sim/common/sim-core.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/sim/common/sim-core.c b/sim/common/sim-core.c > index ade345ef16fb..9b1e16832104 100644 > --- a/sim/common/sim-core.c > +++ b/sim/common/sim-core.c > @@ -480,7 +480,8 @@ sim_memory_map (SIM_DESC sd) > if (mapping->level != 0) > continue; > > - entry = xasprintf ("\n", > + entry = xasprintf (" + "length='%#" PRIxTW "'/>\n", > mapping->base, mapping->nr_bytes); > /* The sim memory map is organized by access, not by addresses. > So a RWX memory map will have three independent mappings. > -- > 2.28.0 >