Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Mike Frysinger via Gdb-patches <gdb-patches@sourceware.org>
To: Andrew Burgess <andrew.burgess@embecosm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] sim: common: fix printf formats
Date: Mon, 11 Jan 2021 08:28:13 -0500	[thread overview]
Message-ID: <20210111132813.GR7494@vapier> (raw)
In-Reply-To: <20210111113314.GD1175365@embecosm.com>

[-- Attachment #1: Type: text/plain, Size: 469 bytes --]

On 11 Jan 2021 11:33, Andrew Burgess wrote:
> * Mike Frysinger via Gdb-patches <gdb-patches@sourceware.org> [2021-01-09 14:09:35 -0500]:
> > For 32-bit targets, %x happens to work for unsigned_word.  But for
> > 64-bit targets, it's too small, and gcc throws an error.  Use the
> > right printf format define for them.
> 
> Missing ChangeLog, otherwise, LGTM.

it was in the commit message:

> > * sim-core.c (sim_memory_map): Change %#x to PRIxTW.

-mike

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

      reply	other threads:[~2021-01-11 13:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-09 19:09 Mike Frysinger via Gdb-patches
2021-01-11 11:33 ` Andrew Burgess
2021-01-11 13:28   ` Mike Frysinger via Gdb-patches [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210111132813.GR7494@vapier \
    --to=gdb-patches@sourceware.org \
    --cc=andrew.burgess@embecosm.com \
    --cc=vapier@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox