Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* [PATCH][OBV] Remove spurious newline on debug printf
@ 2020-12-10 15:18 Luis Machado via Gdb-patches
  2020-12-10 15:21 ` Simon Marchi via Gdb-patches
  0 siblings, 1 reply; 2+ messages in thread
From: Luis Machado via Gdb-patches @ 2020-12-10 15:18 UTC (permalink / raw)
  To: gdb-patches

I noticed a spurious newline on infrun debugging output. The following patch
fixes that. I'll push as obvious.

gdb/ChangeLog:

2020-12-10  Luis Machado  <luis.machado@linaro.org>

	* breakpoint.c (should_be_inserted): Don't output newline.
---
 gdb/breakpoint.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c
index 881686ff7a..baf80b6b19 100644
--- a/gdb/breakpoint.c
+++ b/gdb/breakpoint.c
@@ -2173,7 +2173,7 @@ should_be_inserted (struct bp_location *bl)
       && stepping_past_nonsteppable_watchpoint ())
     {
       infrun_debug_printf ("stepping past non-steppable watchpoint. "
-			   "skipping watchpoint at %s:%d\n",
+			   "skipping watchpoint at %s:%d",
 			   paddress (bl->gdbarch, bl->address), bl->length);
       return 0;
     }
-- 
2.25.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH][OBV] Remove spurious newline on debug printf
  2020-12-10 15:18 [PATCH][OBV] Remove spurious newline on debug printf Luis Machado via Gdb-patches
@ 2020-12-10 15:21 ` Simon Marchi via Gdb-patches
  0 siblings, 0 replies; 2+ messages in thread
From: Simon Marchi via Gdb-patches @ 2020-12-10 15:21 UTC (permalink / raw)
  To: Luis Machado, gdb-patches

On 2020-12-10 10:18 a.m., Luis Machado via Gdb-patches wrote:
> I noticed a spurious newline on infrun debugging output. The following patch
> fixes that. I'll push as obvious.
> 
> gdb/ChangeLog:
> 
> 2020-12-10  Luis Machado  <luis.machado@linaro.org>
> 
> 	* breakpoint.c (should_be_inserted): Don't output newline.
> ---
>  gdb/breakpoint.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c
> index 881686ff7a..baf80b6b19 100644
> --- a/gdb/breakpoint.c
> +++ b/gdb/breakpoint.c
> @@ -2173,7 +2173,7 @@ should_be_inserted (struct bp_location *bl)
>        && stepping_past_nonsteppable_watchpoint ())
>      {
>        infrun_debug_printf ("stepping past non-steppable watchpoint. "
> -			   "skipping watchpoint at %s:%d\n",
> +			   "skipping watchpoint at %s:%d",
>  			   paddress (bl->gdbarch, bl->address), bl->length);
>        return 0;
>      }
> 

Oops, thanks for fixing this!

Simon

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-12-10 15:21 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-10 15:18 [PATCH][OBV] Remove spurious newline on debug printf Luis Machado via Gdb-patches
2020-12-10 15:21 ` Simon Marchi via Gdb-patches

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox