From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id hKfSJQY90l+jQgAAWB0awg (envelope-from ) for ; Thu, 10 Dec 2020 10:21:42 -0500 Received: by simark.ca (Postfix, from userid 112) id 8E8DB1F0A9; Thu, 10 Dec 2020 10:21:42 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_NONE,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (unknown [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 3CB771E590 for ; Thu, 10 Dec 2020 10:21:42 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C72553836C08; Thu, 10 Dec 2020 15:21:41 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C72553836C08 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1607613701; bh=erMnQqNy+S9WxQqFsdQ+92FyR+P5GrL5lxipwvdfZ90=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=srBCUgse9HALsYvZlE8sa5fQumWfZwXoQZvzalCViSZk/ZJy8q/jYQgXEhIofkTqE 3ATNt1jWCyemTiVkl1HGRNXfEgK8mofJ5dtmZBdZbD6i+SF1vQ9jxvcz+TrCez2EFa DZHNveE6RUKQynJRxVlt2ckqFRu/T0+W/4N1qjrc= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 14ED63836C08 for ; Thu, 10 Dec 2020 15:21:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 14ED63836C08 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 0BAFLTn7026926 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 10 Dec 2020 10:21:33 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 0BAFLTn7026926 Received: from [10.0.0.11] (173-246-6-90.qc.cable.ebox.net [173.246.6.90]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id EE46D1E590; Thu, 10 Dec 2020 10:21:28 -0500 (EST) Subject: Re: [PATCH][OBV] Remove spurious newline on debug printf To: Luis Machado , gdb-patches@sourceware.org References: <20201210151853.1590525-1-luis.machado@linaro.org> Message-ID: <6f3e8905-ac53-e2fd-b719-10d99fb04b9a@polymtl.ca> Date: Thu, 10 Dec 2020 10:21:28 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.3 MIME-Version: 1.0 In-Reply-To: <20201210151853.1590525-1-luis.machado@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Thu, 10 Dec 2020 15:21:29 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 2020-12-10 10:18 a.m., Luis Machado via Gdb-patches wrote: > I noticed a spurious newline on infrun debugging output. The following patch > fixes that. I'll push as obvious. > > gdb/ChangeLog: > > 2020-12-10 Luis Machado > > * breakpoint.c (should_be_inserted): Don't output newline. > --- > gdb/breakpoint.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c > index 881686ff7a..baf80b6b19 100644 > --- a/gdb/breakpoint.c > +++ b/gdb/breakpoint.c > @@ -2173,7 +2173,7 @@ should_be_inserted (struct bp_location *bl) > && stepping_past_nonsteppable_watchpoint ()) > { > infrun_debug_printf ("stepping past non-steppable watchpoint. " > - "skipping watchpoint at %s:%d\n", > + "skipping watchpoint at %s:%d", > paddress (bl->gdbarch, bl->address), bl->length); > return 0; > } > Oops, thanks for fixing this! Simon