From: Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
To: Luis Machado <luis.machado@linaro.org>, gdb-patches@sourceware.org
Subject: Re: [PATCH][OBV] Remove spurious newline on debug printf
Date: Thu, 10 Dec 2020 10:21:28 -0500 [thread overview]
Message-ID: <6f3e8905-ac53-e2fd-b719-10d99fb04b9a@polymtl.ca> (raw)
In-Reply-To: <20201210151853.1590525-1-luis.machado@linaro.org>
On 2020-12-10 10:18 a.m., Luis Machado via Gdb-patches wrote:
> I noticed a spurious newline on infrun debugging output. The following patch
> fixes that. I'll push as obvious.
>
> gdb/ChangeLog:
>
> 2020-12-10 Luis Machado <luis.machado@linaro.org>
>
> * breakpoint.c (should_be_inserted): Don't output newline.
> ---
> gdb/breakpoint.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c
> index 881686ff7a..baf80b6b19 100644
> --- a/gdb/breakpoint.c
> +++ b/gdb/breakpoint.c
> @@ -2173,7 +2173,7 @@ should_be_inserted (struct bp_location *bl)
> && stepping_past_nonsteppable_watchpoint ())
> {
> infrun_debug_printf ("stepping past non-steppable watchpoint. "
> - "skipping watchpoint at %s:%d\n",
> + "skipping watchpoint at %s:%d",
> paddress (bl->gdbarch, bl->address), bl->length);
> return 0;
> }
>
Oops, thanks for fixing this!
Simon
prev parent reply other threads:[~2020-12-10 15:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-10 15:18 Luis Machado via Gdb-patches
2020-12-10 15:21 ` Simon Marchi via Gdb-patches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6f3e8905-ac53-e2fd-b719-10d99fb04b9a@polymtl.ca \
--to=gdb-patches@sourceware.org \
--cc=luis.machado@linaro.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox