[PATCH] Fix Value.format_string docu for static members argument

[PATCH] Fix Value.format_string docu for static members argument

[Hannes Domani via Gdb-patches]

The argument is called static_members, not static_fields.

gdb/doc/ChangeLog:

2020-11-24  Hannes Domani  <ssbssa@yahoo.de>

	* python.texi: Fix docu for static members argument.
---
 gdb/doc/python.texi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gdb/doc/python.texi b/gdb/doc/python.texi
index 8e6d88f3fc..60ae20f2c1 100644
--- a/gdb/doc/python.texi
+++ b/gdb/doc/python.texi
@@ -926,7 +926,7 @@ identify the @emph{actual} (derived) type of the object rather than the
 the @emph{declared} type should be used.  (See @code{set print object} in
 @ref{Print Settings}).
 
-@item static_fields
+@item static_members
 @code{True} if static members should be included in the string
 representation of a C@t{++} object, @code{False} if they shouldn't (see
 @code{set print static-members} in @ref{Print Settings}).
-- 
2.29.2

Re: [PATCH] Fix Value.format_string docu for static members argument

[Eli Zaretskii via Gdb-patches]

> Date: Tue, 24 Nov 2020 19:49:38 +0100
> From: Hannes Domani via Gdb-patches <gdb-patches@sourceware.org>
> 
> The argument is called static_members, not static_fields.
> 
> gdb/doc/ChangeLog:
> 
> 2020-11-24  Hannes Domani  <ssbssa@yahoo.de>
> 
> 	* python.texi: Fix docu for static members argument.

OK, thanks.

Re: [PATCH] Fix Value.format_string docu for static members argument

[Simon Marchi]

On 2020-11-24 2:10 p.m., Eli Zaretskii via Gdb-patches wrote:
>> Date: Tue, 24 Nov 2020 19:49:38 +0100
>> From: Hannes Domani via Gdb-patches <gdb-patches@sourceware.org>
>>
>> The argument is called static_members, not static_fields.
>>
>> gdb/doc/ChangeLog:
>>
>> 2020-11-24  Hannes Domani  <ssbssa@yahoo.de>
>>
>> 	* python.texi: Fix docu for static members argument.
> 
> OK, thanks.
> 

It wouldn't hurt to push this patch to the GDB 10 branch, I think.

Simon

Re: [PATCH] Fix Value.format_string docu for static members argument

[Hannes Domani via Gdb-patches]

 Am Dienstag, 24. November 2020, 20:13:25 MEZ hat Simon Marchi <simark@simark.ca> Folgendes geschrieben:

> On 2020-11-24 2:10 p.m., Eli Zaretskii via Gdb-patches wrote:
>
> >> Date: Tue, 24 Nov 2020 19:49:38 +0100
> >> From: Hannes Domani via Gdb-patches <gdb-patches@sourceware.org>
> >>
> >> The argument is called static_members, not static_fields.
> >>
> >> gdb/doc/ChangeLog:
> >>
> >> 2020-11-24  Hannes Domani  <ssbssa@yahoo.de>
> >>
> >>     * python.texi: Fix docu for static members argument.
> >
> > OK, thanks.
>
> >
>
> It wouldn't hurt to push this patch to the GDB 10 branch, I think.

So would this need a PR then?


Hannes

Re: [PATCH] Fix Value.format_string docu for static members argument

[Simon Marchi]

On 2020-11-24 2:15 p.m., Hannes Domani via Gdb-patches wrote:
>  Am Dienstag, 24. November 2020, 20:13:25 MEZ hat Simon Marchi <simark@simark.ca> Folgendes geschrieben:
>
>> On 2020-11-24 2:10 p.m., Eli Zaretskii via Gdb-patches wrote:
>>
>>>> Date: Tue, 24 Nov 2020 19:49:38 +0100
>>>> From: Hannes Domani via Gdb-patches <gdb-patches@sourceware.org>
>>>>
>>>> The argument is called static_members, not static_fields.
>>>>
>>>> gdb/doc/ChangeLog:
>>>>
>>>> 2020-11-24  Hannes Domani  <ssbssa@yahoo.de>
>>>>
>>>>      * python.texi: Fix docu for static members argument.
>>>
>>> OK, thanks.
>>
>>>
>>
>> It wouldn't hurt to push this patch to the GDB 10 branch, I think.
>
> So would this need a PR then?

Hmm, right.  Well, if you don't mind creating one it would be nice, but
otherwise it's not the end of the world.

Simon

Re: [PATCH] Fix Value.format_string docu for static members argument

[Hannes Domani via Gdb-patches]

 Am Dienstag, 24. November 2020, 20:18:14 MEZ hat Simon Marchi <simark@simark.ca> Folgendes geschrieben:

> On 2020-11-24 2:15 p.m., Hannes Domani via Gdb-patches wrote:
> >  Am Dienstag, 24. November 2020, 20:13:25 MEZ hat Simon Marchi <simark@simark.ca> Folgendes geschrieben:
> >
> >> On 2020-11-24 2:10 p.m., Eli Zaretskii via Gdb-patches wrote:
> >>
> >>>> Date: Tue, 24 Nov 2020 19:49:38 +0100
> >>>> From: Hannes Domani via Gdb-patches <gdb-patches@sourceware.org>
> >>>>
> >>>> The argument is called static_members, not static_fields.
> >>>>
> >>>> gdb/doc/ChangeLog:
> >>>>
> >>>> 2020-11-24  Hannes Domani  <ssbssa@yahoo.de>
> >>>>
> >>>>      * python.texi: Fix docu for static members argument.
> >>>
> >>> OK, thanks.
> >>
> >>>
> >>
> >> It wouldn't hurt to push this patch to the GDB 10 branch, I think.
> >
> > So would this need a PR then?
>
> Hmm, right.  Well, if you don't mind creating one it would be nice, but
> otherwise it's not the end of the world.

I've create PR python/26974, and pushed this to master and gdb 10, thanks.


Hannes