Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: gdb-patches@sourceware.org
Subject: Re: Problem building today's snapshot with MinGW
Date: Thu, 17 Sep 2020 06:57:15 -0700	[thread overview]
Message-ID: <20200917135715.GK5797@adacore.com> (raw)
In-Reply-To: <838sd87daz.fsf@gnu.org>

> > At Joel's request, I've built today's snapshot of the GDB master
> > branch using mingw.org's MinGW, and found a problem when running the
> > produced gdb.exe on versions of Windows older than 8.0 (in my case it
> > was XP).  The details are described in my report to the Gnulib folks:
> > 
> >   https://lists.gnu.org/archive/html/bug-gnulib/2020-09/index.html
> 
> The Gnulib folks confirmed my report and provided a patch, see
> 
>   https://lists.gnu.org/archive/html/bug-gnulib/2020-09/msg00075.html
> 
> How should we proceed?  Do we import the updated Gnulib, or do we
> patch our copy?

I think we should take different approaches for master and branch.

  - On master, we should attempt a gnulib update, so as to keep
    out list of patches down to the absolute bare minimum.

    Alternatively, if there is an unforseen complication with doing
    that, we could include those two changes as local patches
    specifically, but this would only create more work for the next
    person who wants to do an update. That's why I think we should
    first try the regular update.

  - On the branch, I think we should go with Bruno's patches,
    after review and testing. gnulib updates are always tricky,
    so outside of some particular circumstances, I think they are
    in general too risky to do on a release branch.

-- 
Joel


      reply	other threads:[~2020-09-17 13:57 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-10 15:35 Eli Zaretskii
2020-09-12 16:33 ` Joel Brobecker
2020-09-12 17:36   ` Eli Zaretskii
2020-09-17 13:17 ` Eli Zaretskii
2020-09-17 13:57   ` Joel Brobecker [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200917135715.GK5797@adacore.com \
    --to=brobecker@adacore.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox