From: Eli Zaretskii <eliz@gnu.org>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: Problem building today's snapshot with MinGW
Date: Sat, 12 Sep 2020 20:36:09 +0300 [thread overview]
Message-ID: <83lfhedhiu.fsf@gnu.org> (raw)
In-Reply-To: <20200912163346.GB5423@adacore.com> (message from Joel Brobecker on Sat, 12 Sep 2020 09:33:46 -0700)
> Date: Sat, 12 Sep 2020 09:33:46 -0700
> From: Joel Brobecker <brobecker@adacore.com>
> Cc: gdb-patches@sourceware.org
>
> From what I understood of the analysis, gnulib is doing something
> pretty questionable (forcing _WIN32_WINNT to the wrong value) in
> order to get FILE_ID_INFO being defined; and looking at your patch
> and the explanation you gave in the report to gnulib, you found
> that the APIs in question are only needed if _GL_WINDOWS_STAT_INODES
> and so fixed this by only enabling the redefined based on
> this variable. So for me, this is more of a workaround than an actual
> fix.
It's indeed a workaround, because I actually believe the code is
wrong, and the entire part that redefines _WIN32_WINNT should be
dropped, as the rest of the code is well equipped to handle any
reasonable value of _WIN32_WINNT.
I used the workaround because I'm still not 100% sure I'm not missing
something, which could explain why the Gnulib folks have this code
there. It is also the reason why I didn't post the patch to the
Gnulib list, but instead asked them why that part of the code was at
all necessary.
next prev parent reply other threads:[~2020-09-12 17:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-10 15:35 Eli Zaretskii
2020-09-12 16:33 ` Joel Brobecker
2020-09-12 17:36 ` Eli Zaretskii [this message]
2020-09-17 13:17 ` Eli Zaretskii
2020-09-17 13:57 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83lfhedhiu.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox