Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: gdb-patches@sourceware.org
Subject: Problem building today's snapshot with MinGW
Date: Thu, 10 Sep 2020 18:35:34 +0300	[thread overview]
Message-ID: <83tuw5ir09.fsf@gnu.org> (raw)

At Joel's request, I've built today's snapshot of the GDB master
branch using mingw.org's MinGW, and found a problem when running the
produced gdb.exe on versions of Windows older than 8.0 (in my case it
was XP).  The details are described in my report to the Gnulib folks:

  https://lists.gnu.org/archive/html/bug-gnulib/2020-09/index.html

The provisional patch I used to solve this problem is this:

--- gnulib/import/stat-w32.c~	2020-09-10 04:47:11.000000000 +0300
+++ gnulib/import/stat-w32.c	2020-09-10 16:05:46.789125000 +0300
@@ -20,10 +20,14 @@
 
 #if defined _WIN32 && ! defined __CYGWIN__
 
+#if _GL_WINDOWS_STAT_INODES == 2
 /* Ensure that <windows.h> defines FILE_ID_INFO.  */
-#if !defined _WIN32_WINNT || (_WIN32_WINNT < _WIN32_WINNT_WIN8)
-# undef _WIN32_WINNT
-# define _WIN32_WINNT _WIN32_WINNT_WIN8
+# if !defined _WIN32_WINNT || (_WIN32_WINNT < _WIN32_WINNT_WIN8)
+#  undef _WIN32_WINNT
+#  define _WIN32_WINNT _WIN32_WINNT_WIN8
+# endif
+#elif !defined VOLUME_NAME_NONE
+# define VOLUME_NAME_NONE 0x4
 #endif
 
 #include <sys/types.h>


             reply	other threads:[~2020-09-10 15:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-10 15:35 Eli Zaretskii [this message]
2020-09-12 16:33 ` Joel Brobecker
2020-09-12 17:36   ` Eli Zaretskii
2020-09-17 13:17 ` Eli Zaretskii
2020-09-17 13:57   ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83tuw5ir09.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox